Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-09 07:23:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

scsi: target: cxgbit: Check connection state before issuing hardware command

Browse Source 
Current code does not check connection state before issuing
header/data digest offload and DDP page size setup hardware command.

Add a connection state check to issue hardware command only
if connection is in established state.

Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Varun Prakash 2020-07-01 22:16:10 +05:30 committed by Martin K. Petersen
parent e33c248228
commit f178842224
1 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
drivers/target/iscsi/cxgbit/cxgbit_cm.c
View File

@ -1485,6 +1485,26 @@ u32 cxgbit_send_tx_flowc_wr(struct cxgbit_sock *csk)
return flowclen16;
}
static int
cxgbit_send_tcb_skb(struct cxgbit_sock *csk, struct sk_buff *skb)
{
spin_lock_bh(&csk->lock);
if (unlikely(csk->com.state != CSK_STATE_ESTABLISHED)) {
spin_unlock_bh(&csk->lock);
pr_err("%s: csk 0x%p, tid %u, state %u\n",
__func__, csk, csk->tid, csk->com.state);
__kfree_skb(skb);
return -1;
}
cxgbit_get_csk(csk);
cxgbit_init_wr_wait(&csk->com.wr_wait);
cxgbit_ofld_send(csk->com.cdev, skb);
spin_unlock_bh(&csk->lock);
return 0;
}
int cxgbit_setup_conn_digest(struct cxgbit_sock *csk)
{
struct sk_buff *skb;
@ -1510,10 +1530,8 @@ int cxgbit_setup_conn_digest(struct cxgbit_sock *csk)
(dcrc ? ULP_CRC_DATA : 0)) << 4);
set_wr_txq(skb, CPL_PRIORITY_CONTROL, csk->ctrlq_idx);
cxgbit_get_csk(csk);
cxgbit_init_wr_wait(&csk->com.wr_wait);
cxgbit_ofld_send(csk->com.cdev, skb);
if (cxgbit_send_tcb_skb(csk, skb))
return -1;
ret = cxgbit_wait_for_reply(csk->com.cdev,
&csk->com.wr_wait,
@ -1545,10 +1563,8 @@ int cxgbit_setup_conn_pgidx(struct cxgbit_sock *csk, u32 pg_idx)
req->val = cpu_to_be64(pg_idx << 8);
set_wr_txq(skb, CPL_PRIORITY_CONTROL, csk->ctrlq_idx);
cxgbit_get_csk(csk);
cxgbit_init_wr_wait(&csk->com.wr_wait);
cxgbit_ofld_send(csk->com.cdev, skb);
if (cxgbit_send_tcb_skb(csk, skb))
return -1;
ret = cxgbit_wait_for_reply(csk->com.cdev,
&csk->com.wr_wait,