Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-13 01:08:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

V4L/DVB (6325): Double-free in cx23885_initdev

Browse Source 
Both cx23885_initdev and cx23885_dev_setup free the device in their
error path so a failure in the latter causes a double-free. Since
cx23885_dev_setup is only called from cx23885_initdev, it should be safe
to remove its deallocation and leave the cleanup up to the allocating
function.

Coverity CID 1922.

Signed-off-by: Florin Malita <fmalita@gmail.com>
CC: Steven Toth <stoth@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
This commit is contained in:
Florin Malita 2007-10-13 11:49:52 -03:00 committed by Mauro Carvalho Chehab
parent a13625c518
commit fcf94c89af
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/video/cx23885/cx23885-core.c
View File

@ -793,7 +793,7 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
dev->pci->subsystem_device); dev->pci->subsystem_device);
cx23885_devcount--; cx23885_devcount--;
goto fail_free; return -ENODEV;
} }
/* PCIe stuff */ /* PCIe stuff */
@ -835,10 +835,6 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
} }
return 0; return 0;
fail_free:
kfree(dev);
return -ENODEV;
} }
void cx23885_dev_unregister(struct cx23885_dev *dev) void cx23885_dev_unregister(struct cx23885_dev *dev)