mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2025-01-12 08:48:48 +00:00
ASoC: amd: acp: Fix return value check in acp_machine_select()
In case of error, platform_device_register_data() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: e646b51f5dd5 ("ASoC: amd: acp: Add callback for machine driver on ACP") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20211027065228.833825-1-yangyingliang@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
f88ee76b86
commit
fdde18b977
@ -81,7 +81,7 @@ int acp_machine_select(struct acp_dev_data *adata)
|
||||
|
||||
adata->mach_dev = platform_device_register_data(adata->dev, mach->drv_name,
|
||||
PLATFORM_DEVID_NONE, mach, size);
|
||||
if (!adata->mach_dev)
|
||||
if (IS_ERR(adata->mach_dev))
|
||||
dev_warn(adata->dev, "Unable to register Machine device\n");
|
||||
|
||||
return 0;
|
||||
|
Loading…
x
Reference in New Issue
Block a user