mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2024-12-29 17:22:07 +00:00
e1a261ba59
kmsg_dump doesn't forward the panic reason string to the kmsg_dumper callback. This patch adds a new struct kmsg_dump_detail, that will hold the reason and description, and pass it to the dump() callback. To avoid updating all kmsg_dump() call, it adds a kmsg_dump_desc() function and a macro for backward compatibility. I've written this for drm_panic, but it can be useful for other kmsg_dumper. It allows to see the panic reason, like "sysrq triggered crash" or "VFS: Unable to mount root fs on xxxx" on the drm panic screen. v2: * Use a struct kmsg_dump_detail to hold the reason and description pointer, for more flexibility if we want to add other parameters. (Kees Cook) * Fix powerpc/nvram_64 build, as I didn't update the forward declaration of oops_to_nvram() Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com> Acked-by: Petr Mladek <pmladek@suse.com> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Acked-by: Kees Cook <kees@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240702122639.248110-1-jfalempe@redhat.com
66 lines
1.4 KiB
C
66 lines
1.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/kmsg_dump.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/console.h>
|
|
#include <linux/string.h>
|
|
#include <shared/init.h>
|
|
#include <shared/kern.h>
|
|
#include <os.h>
|
|
|
|
static void kmsg_dumper_stdout(struct kmsg_dumper *dumper,
|
|
struct kmsg_dump_detail *detail)
|
|
{
|
|
static struct kmsg_dump_iter iter;
|
|
static DEFINE_SPINLOCK(lock);
|
|
static char line[1024];
|
|
struct console *con;
|
|
unsigned long flags;
|
|
size_t len = 0;
|
|
int cookie;
|
|
|
|
/*
|
|
* If no consoles are available to output crash information, dump
|
|
* the kmsg buffer to stdout.
|
|
*/
|
|
|
|
cookie = console_srcu_read_lock();
|
|
for_each_console_srcu(con) {
|
|
/*
|
|
* The ttynull console and disabled consoles are ignored
|
|
* since they cannot output. All other consoles are
|
|
* expected to output the crash information.
|
|
*/
|
|
if (strcmp(con->name, "ttynull") != 0 &&
|
|
(console_srcu_read_flags(con) & CON_ENABLED)) {
|
|
break;
|
|
}
|
|
}
|
|
console_srcu_read_unlock(cookie);
|
|
if (con)
|
|
return;
|
|
|
|
if (!spin_trylock_irqsave(&lock, flags))
|
|
return;
|
|
|
|
kmsg_dump_rewind(&iter);
|
|
|
|
printf("kmsg_dump:\n");
|
|
while (kmsg_dump_get_line(&iter, true, line, sizeof(line), &len)) {
|
|
line[len] = '\0';
|
|
printf("%s", line);
|
|
}
|
|
|
|
spin_unlock_irqrestore(&lock, flags);
|
|
}
|
|
|
|
static struct kmsg_dumper kmsg_dumper = {
|
|
.dump = kmsg_dumper_stdout
|
|
};
|
|
|
|
static int __init kmsg_dumper_stdout_init(void)
|
|
{
|
|
return kmsg_dump_register(&kmsg_dumper);
|
|
}
|
|
|
|
__uml_postsetup(kmsg_dumper_stdout_init);
|