mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2024-12-29 17:22:07 +00:00
1d25e3eeed
Fix 2 printk format warnings (this driver is currently only used by
arch/sh/) by using "%pap" instead of "%lx".
Fixes these build warnings:
../drivers/mtd/maps/solutionengine.c: In function 'init_soleng_maps':
../include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
../drivers/mtd/maps/solutionengine.c:62:54: note: format string is defined here
printk(KERN_NOTICE "Solution Engine: Flash at 0x%08lx, EPROM at 0x%08lx\n",
~~~~^
%08x
../include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
../drivers/mtd/maps/solutionengine.c:62:72: note: format string is defined here
printk(KERN_NOTICE "Solution Engine: Flash at 0x%08lx, EPROM at 0x%08lx\n",
~~~~^
%08x
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
96 lines
2.4 KiB
C
96 lines
2.4 KiB
C
/*
|
|
* Flash and EPROM on Hitachi Solution Engine and similar boards.
|
|
*
|
|
* (C) 2001 Red Hat, Inc.
|
|
*
|
|
* GPL'd
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <asm/io.h>
|
|
#include <linux/mtd/mtd.h>
|
|
#include <linux/mtd/map.h>
|
|
#include <linux/mtd/partitions.h>
|
|
#include <linux/errno.h>
|
|
|
|
static struct mtd_info *flash_mtd;
|
|
static struct mtd_info *eprom_mtd;
|
|
|
|
struct map_info soleng_eprom_map = {
|
|
.name = "Solution Engine EPROM",
|
|
.size = 0x400000,
|
|
.bankwidth = 4,
|
|
};
|
|
|
|
struct map_info soleng_flash_map = {
|
|
.name = "Solution Engine FLASH",
|
|
.size = 0x400000,
|
|
.bankwidth = 4,
|
|
};
|
|
|
|
static const char * const probes[] = { "RedBoot", "cmdlinepart", NULL };
|
|
|
|
static int __init init_soleng_maps(void)
|
|
{
|
|
/* First probe at offset 0 */
|
|
soleng_flash_map.phys = 0;
|
|
soleng_flash_map.virt = (void __iomem *)P2SEGADDR(0);
|
|
soleng_eprom_map.phys = 0x01000000;
|
|
soleng_eprom_map.virt = (void __iomem *)P1SEGADDR(0x01000000);
|
|
simple_map_init(&soleng_eprom_map);
|
|
simple_map_init(&soleng_flash_map);
|
|
|
|
printk(KERN_NOTICE "Probing for flash chips at 0x00000000:\n");
|
|
flash_mtd = do_map_probe("cfi_probe", &soleng_flash_map);
|
|
if (!flash_mtd) {
|
|
/* Not there. Try swapping */
|
|
printk(KERN_NOTICE "Probing for flash chips at 0x01000000:\n");
|
|
soleng_flash_map.phys = 0x01000000;
|
|
soleng_flash_map.virt = P2SEGADDR(0x01000000);
|
|
soleng_eprom_map.phys = 0;
|
|
soleng_eprom_map.virt = P1SEGADDR(0);
|
|
flash_mtd = do_map_probe("cfi_probe", &soleng_flash_map);
|
|
if (!flash_mtd) {
|
|
/* Eep. */
|
|
printk(KERN_NOTICE "Flash chips not detected at either possible location.\n");
|
|
return -ENXIO;
|
|
}
|
|
}
|
|
printk(KERN_NOTICE "Solution Engine: Flash at 0x%pap, EPROM at 0x%pap\n",
|
|
&soleng_flash_map.phys,
|
|
&soleng_eprom_map.phys);
|
|
flash_mtd->owner = THIS_MODULE;
|
|
|
|
eprom_mtd = do_map_probe("map_rom", &soleng_eprom_map);
|
|
if (eprom_mtd) {
|
|
eprom_mtd->owner = THIS_MODULE;
|
|
mtd_device_register(eprom_mtd, NULL, 0);
|
|
}
|
|
|
|
mtd_device_parse_register(flash_mtd, probes, NULL, NULL, 0);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void __exit cleanup_soleng_maps(void)
|
|
{
|
|
if (eprom_mtd) {
|
|
mtd_device_unregister(eprom_mtd);
|
|
map_destroy(eprom_mtd);
|
|
}
|
|
|
|
mtd_device_unregister(flash_mtd);
|
|
map_destroy(flash_mtd);
|
|
}
|
|
|
|
module_init(init_soleng_maps);
|
|
module_exit(cleanup_soleng_maps);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("David Woodhouse <dwmw2@infradead.org>");
|
|
MODULE_DESCRIPTION("MTD map driver for Hitachi SolutionEngine (and similar) boards");
|
|
|