Jan Beulich 7b55984c96 xen-netback: properly sync TX responses ... Invoking the make_tx_response() / push_tx_responses() pair with no lock held would be acceptable only if all such invocations happened from the same context (NAPI instance or dealloc thread). Since this isn't the case, and since the interface "spec" also doesn't demand that multicast operations may only be performed with no in-flight transmits, MCAST_{ADD,DEL} processing also needs to acquire the response lock around the invocations. To prevent similar mistakes going forward, "downgrade" the present functions to private helpers of just the two remaining ones using them directly, with no forward declarations anymore. This involves renaming what so far was make_tx_response(), for the new function of that name to serve the new (wrapper) purpose. While there, - constify the txp parameters, - correct xenvif_idx_release()'s status parameter's type, - rename {,_}make_tx_response()'s status parameters for consistency with xenvif_idx_release()'s. Fixes: 210c34dcd8 ("xen-netback: add support for multicast control") Cc: stable@vger.kernel.org Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Paul Durrant <paul@xen.org> Link: https://lore.kernel.org/r/980c6c3d-e10e-4459-8565-e8fbde122f00@suse.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-02-01 08:29:36 -08:00
..
common.h	xen/netback: don't do grant copy across page boundary	2023-03-28 14:16:40 +02:00
hash.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
interface.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
netback.c	xen-netback: properly sync TX responses	2024-02-01 08:29:36 -08:00
rx.c	xen/netback: don't call kfree_skb() with interrupts disabled	2022-12-06 16:00:33 +01:00
xenbus.c	driver core: make struct bus_type.uevent() take a const *	2023-01-27 13:45:52 +01:00