Darrick J. Wong
13eaec4b2a
xfs: don't commit sunit/swidth updates to disk if that would cause repair failures ...
Alex Lyakas reported[1] that mounting an xfs filesystem with new sunit
and swidth values could cause xfs_repair to fail loudly. The problem
here is that repair calculates the where mkfs should have allocated the
root inode, based on the superblock geometry. The allocation decisions
depend on sunit, which means that we really can't go updating sunit if
it would lead to a subsequent repair failure on an otherwise correct
filesystem.
Port from xfs_repair some code that computes the location of the root
inode and teach mount to skip the ondisk update if it would cause
problems for repair. Along the way we'll update the documentation,
provide a function for computing the minimum AGFL size instead of
open-coding it, and cut down some indenting in the mount code.
Note that we allow the mount to proceed (and new allocations will
reflect this new geometry) because we've never screened this kind of
thing before. We'll have to wait for a new future incompat feature to
enforce correct behavior, alas.
Note that the geometry reporting always uses the superblock values, not
the incore ones, so that is what xfs_info and xfs_growfs will report.
[1] https://lore.kernel.org/linux-xfs/20191125130744.GA44777@bfoster/T/#m00f9594b511e076e2fcdd489d78bc30216d72a7d
Reported-by: Alex Lyakas <alex@zadara.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
2019-12-19 07:53:48 -08:00
2019-09-27 15:10:34 -07:00
2019-07-19 11:33:22 -07:00
2019-11-18 14:26:43 +01:00
2019-11-30 10:57:22 -08:00
2019-12-05 17:11:48 -08:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2019-12-01 13:46:15 -08:00
2019-05-24 17:27:11 +02:00
2019-12-05 13:06:51 -08:00
2019-12-08 12:12:18 -08:00
2019-09-19 09:42:37 -07:00
2019-11-06 18:36:01 +01:00
2019-11-23 21:44:49 -05:00
2019-11-06 12:34:36 -08:00
2019-12-06 09:06:58 -08:00
2019-09-03 09:30:56 -04:00
2019-07-12 17:37:53 -07:00
2019-12-01 13:46:15 -08:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:17 -07:00
2019-11-24 11:02:41 +08:00
2019-11-11 09:21:59 -05:00
2019-11-30 11:16:07 -08:00
2019-12-01 13:46:15 -08:00
2019-12-01 13:46:15 -08:00
2019-10-23 17:23:43 +02:00
2019-08-30 07:27:17 -07:00
2019-07-10 18:43:43 -07:00
2019-12-06 13:57:04 -08:00
2019-12-05 13:20:11 -08:00
2019-05-21 10:50:46 +02:00
2019-07-16 19:23:23 -07:00
2019-05-12 17:52:13 -04:00
2019-10-23 17:23:46 +02:00
2019-12-01 12:59:08 -08:00
2019-12-05 07:41:16 -08:00
2019-09-19 09:42:37 -07:00
2019-11-30 10:53:02 -08:00
2019-11-29 11:29:58 +01:00
2019-09-19 09:42:37 -07:00
2019-12-06 09:06:58 -08:00
2019-11-03 21:28:45 -05:00
2019-08-30 07:27:17 -07:00
2019-11-18 11:04:32 +01:00
2019-05-21 10:50:46 +02:00
2019-12-07 16:56:00 -08:00
2019-10-23 17:23:46 +02:00
2019-05-21 10:50:46 +02:00
2019-12-01 13:46:15 -08:00
2019-09-26 10:10:44 -07:00
2019-12-01 20:36:41 -08:00
2019-08-30 08:11:25 -07:00
2019-07-19 10:42:02 -07:00
2019-12-04 08:52:55 -05:00
2019-11-15 13:49:04 -05:00
2019-12-04 19:44:11 -08:00
2019-10-29 09:43:03 -07:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2019-12-06 09:06:58 -08:00
2019-09-12 21:05:34 -04:00
2019-11-05 12:25:22 +01:00
2019-09-19 10:06:57 -07:00
2019-09-19 10:06:57 -07:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:18 -07:00
2019-10-12 20:49:07 -04:00
2019-11-17 22:22:54 +01:00
2019-09-04 18:19:43 +02:00
2019-09-19 09:42:37 -07:00
2019-09-17 11:48:24 -04:00
2019-08-12 19:33:50 -07:00
2019-12-19 07:53:48 -08:00
2019-12-01 14:00:59 -08:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:17 -07:00
2018-07-12 10:04:20 -04:00
2019-05-21 10:50:45 +02:00
2019-11-15 14:38:29 +01:00
2019-12-04 19:44:13 -08:00
2019-05-21 10:50:45 +02:00
2019-07-16 19:23:22 -07:00
2019-07-19 10:42:02 -07:00
2019-05-21 10:50:45 +02:00
2019-12-02 18:49:30 -07:00
2019-12-01 06:29:17 -08:00
2019-05-24 20:50:36 +02:00
2019-11-15 14:38:29 +01:00
2019-12-02 14:46:22 -08:00
2019-06-19 17:09:55 +02:00
2019-08-03 07:02:01 -07:00
2019-08-30 19:31:09 -04:00
2019-11-30 10:44:49 -08:00
2019-12-08 11:08:28 -08:00
2019-05-21 10:50:45 +02:00
2019-12-01 06:29:18 -08:00
2019-02-01 15:46:24 -08:00
2019-05-21 10:50:45 +02:00
2019-12-04 19:44:13 -08:00
2019-12-03 12:20:25 -08:00
2019-12-08 11:08:28 -08:00
2019-08-07 21:51:47 -04:00
2019-08-19 11:00:39 -04:00
2019-11-26 11:34:06 -08:00
2019-02-28 03:29:26 -05:00
2019-09-06 21:28:49 +02:00
2019-09-12 21:06:14 -04:00
2019-07-16 22:52:37 -04:00
2019-05-21 10:50:45 +02:00
2019-01-21 17:48:13 +01:00
2019-11-08 13:37:24 -07:00
2019-07-19 10:42:02 -07:00
2019-09-24 15:54:11 -07:00
2019-10-25 14:08:24 -04:00
2019-12-05 07:59:37 -07:00
2019-12-02 08:50:00 -07:00
2019-12-04 17:26:57 -07:00
2019-12-02 14:46:22 -08:00
2019-10-29 12:43:00 -06:00
2019-06-24 09:16:47 +10:00
2019-10-14 15:04:01 -07:00
2019-09-27 17:00:27 -07:00
2019-10-29 12:43:00 -06:00
2019-05-21 10:50:45 +02:00
2019-07-16 22:52:37 -04:00
2019-07-10 09:00:57 -06:00
2019-12-06 09:06:58 -08:00
2019-12-08 11:08:28 -08:00
2019-05-30 11:26:32 -07:00
2019-05-25 18:00:06 -04:00
2019-11-26 11:34:06 -08:00
2019-12-07 13:53:09 -08:00
2019-06-17 17:36:09 -04:00
2019-05-30 11:29:53 -07:00
2019-05-21 10:50:45 +02:00
2019-09-06 21:28:49 +02:00
2019-08-16 18:43:24 -07:00
2019-10-18 18:41:16 -04:00
2019-11-15 14:38:29 +01:00
2019-08-13 16:06:52 -07:00
2019-04-08 18:21:02 -05:00
2019-12-07 13:21:01 -08:00
2019-05-21 10:50:45 +02:00
2019-02-01 01:55:45 -05:00
2019-10-03 14:21:35 -07:00
2019-10-10 08:16:44 -07:00
2019-05-14 09:47:50 -07:00
2019-11-15 14:38:30 +01:00
2019-12-01 20:36:41 -08:00
2019-11-15 14:38:29 +01:00
2019-05-21 10:50:45 +02:00
13eaec4b2a