mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2025-01-16 05:26:07 +00:00
bca92922e2
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230302144732.1903781-17-u.kleine-koenig@pengutronix.de Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
94 lines
2.3 KiB
C
94 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Power-button driver for Dollar Cove TI PMIC
|
|
* Copyright (C) 2014 Intel Corp
|
|
* Copyright (c) 2017 Takashi Iwai <tiwai@suse.de>
|
|
*/
|
|
|
|
#include <linux/input.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/device.h>
|
|
#include <linux/mfd/intel_soc_pmic.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_wakeirq.h>
|
|
#include <linux/slab.h>
|
|
|
|
#define CHTDC_TI_SIRQ_REG 0x3
|
|
#define SIRQ_PWRBTN_REL BIT(0)
|
|
|
|
static irqreturn_t chtdc_ti_pwrbtn_interrupt(int irq, void *dev_id)
|
|
{
|
|
struct input_dev *input = dev_id;
|
|
struct device *dev = input->dev.parent;
|
|
struct regmap *regmap = dev_get_drvdata(dev);
|
|
int state;
|
|
|
|
if (!regmap_read(regmap, CHTDC_TI_SIRQ_REG, &state)) {
|
|
dev_dbg(dev, "SIRQ_REG=0x%x\n", state);
|
|
input_report_key(input, KEY_POWER, !(state & SIRQ_PWRBTN_REL));
|
|
input_sync(input);
|
|
}
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int chtdc_ti_pwrbtn_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct intel_soc_pmic *pmic = dev_get_drvdata(dev->parent);
|
|
struct input_dev *input;
|
|
int irq, err;
|
|
|
|
irq = platform_get_irq(pdev, 0);
|
|
if (irq < 0)
|
|
return irq;
|
|
input = devm_input_allocate_device(dev);
|
|
if (!input)
|
|
return -ENOMEM;
|
|
input->name = pdev->name;
|
|
input->phys = "power-button/input0";
|
|
input->id.bustype = BUS_HOST;
|
|
input_set_capability(input, EV_KEY, KEY_POWER);
|
|
err = input_register_device(input);
|
|
if (err)
|
|
return err;
|
|
|
|
dev_set_drvdata(dev, pmic->regmap);
|
|
|
|
err = devm_request_threaded_irq(dev, irq, NULL,
|
|
chtdc_ti_pwrbtn_interrupt,
|
|
IRQF_ONESHOT, KBUILD_MODNAME, input);
|
|
if (err)
|
|
return err;
|
|
|
|
device_init_wakeup(dev, true);
|
|
dev_pm_set_wake_irq(dev, irq);
|
|
return 0;
|
|
}
|
|
|
|
static void chtdc_ti_pwrbtn_remove(struct platform_device *pdev)
|
|
{
|
|
dev_pm_clear_wake_irq(&pdev->dev);
|
|
device_init_wakeup(&pdev->dev, false);
|
|
}
|
|
|
|
static const struct platform_device_id chtdc_ti_pwrbtn_id_table[] = {
|
|
{ .name = "chtdc_ti_pwrbtn" },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(platform, chtdc_ti_pwrbtn_id_table);
|
|
|
|
static struct platform_driver chtdc_ti_pwrbtn_driver = {
|
|
.driver = {
|
|
.name = KBUILD_MODNAME,
|
|
},
|
|
.probe = chtdc_ti_pwrbtn_probe,
|
|
.remove_new = chtdc_ti_pwrbtn_remove,
|
|
.id_table = chtdc_ti_pwrbtn_id_table,
|
|
};
|
|
module_platform_driver(chtdc_ti_pwrbtn_driver);
|
|
|
|
MODULE_DESCRIPTION("Power-button driver for Dollar Cove TI PMIC");
|
|
MODULE_LICENSE("GPL v2");
|