Andrii Nakryiko 46ba0e49b6 bpf: fix multi-uprobe PID filtering logic ... Current implementation of PID filtering logic for multi-uprobes in uprobe_prog_run() is filtering down to exact *thread*, while the intent for PID filtering it to filter by *process* instead. The check in uprobe_prog_run() also differs from the analogous one in uprobe_multi_link_filter() for some reason. The latter is correct, checking task->mm, not the task itself. Fix the check in uprobe_prog_run() to perform the same task->mm check. While doing this, we also update get_pid_task() use to use PIDTYPE_TGID type of lookup, given the intent is to get a representative task of an entire process. This doesn't change behavior, but seems more logical. It would hold task group leader task now, not any random thread task. Last but not least, given multi-uprobe support is half-broken due to this PID filtering logic (depending on whether PID filtering is important or not), we need to make it easy for user space consumers (including libbpf) to easily detect whether PID filtering logic was already fixed. We do it here by adding an early check on passed pid parameter. If it's negative (and so has no chance of being a valid PID), we return -EINVAL. Previous behavior would eventually return -ESRCH ("No process found"), given there can't be any process with negative PID. This subtle change won't make any practical change in behavior, but will allow applications to detect PID filtering fixes easily. Libbpf fixes take advantage of this in the next patch. Cc: stable@vger.kernel.org Acked-by: Jiri Olsa <jolsa@kernel.org> Fixes: b733eeade4 ("bpf: Add pid filter support for uprobe_multi link") Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/r/20240521163401.3005045-2-andrii@kernel.org Signed-off-by: Alexei Starovoitov <ast@kernel.org>		2024-05-25 10:46:02 -07:00
..
rv	tracing/tools: Updates for 6.4	2023-04-28 16:11:26 -07:00
blktrace.c	block: remove more NULL checks after bdev_get_queue()	2023-02-21 09:23:22 -07:00
bpf_trace.c	bpf: fix multi-uprobe PID filtering logic	2024-05-25 10:46:02 -07:00
bpf_trace.h
error_report-traces.c	tracing: add error_report_end trace point	2021-02-26 09:41:02 -08:00
fgraph.c	ftrace: Remove unused global 'ftrace_direct_func_count'	2024-05-14 02:09:40 -04:00
fprobe.c	fprobe: Fix to allocate entry_data_size buffer with rethook instances	2024-03-01 09:18:24 +09:00
ftrace_internal.h	tracing: arm64: Avoid missing-prototype warnings	2023-07-12 12:06:04 -04:00
ftrace.c	tracing cleanups for v6.10:	2024-05-17 18:34:27 -07:00
Kconfig	Probes updates for v6.10:	2024-05-17 18:29:30 -07:00
kprobe_event_gen_test.c	tracing: Fix wrong return in kprobe_event_gen_test.c	2023-03-19 12:20:48 -04:00
Makefile	tracing/probes: Move finding func-proto API and getting func-param API to trace_btf	2023-08-23 09:39:45 +09:00
pid_list.c	tracing: Cleanup double word in comment	2022-04-26 17:58:50 -04:00
pid_list.h	tracing: Create a sparse bitmask for pid filtering	2021-10-05 17:38:45 -04:00
power-traces.c
preemptirq_delay_test.c	kernel: trace: preemptirq_delay_test: add cpu affinity	2021-02-02 17:02:07 -05:00
rethook.c	rethook: honor CONFIG_FTRACE_VALIDATE_RCU_IS_WATCHING in rethook_try_get()	2024-05-01 23:18:48 +09:00
ring_buffer_benchmark.c	ring-buffer: Read and write to ring buffers with custom sub buffer size	2023-12-20 07:54:56 -05:00
ring_buffer.c	ring-buffer: Add cast to unsigned long addr passed to virt_to_page()	2024-05-15 01:28:42 -04:00
rpm-traces.c
synth_event_gen_test.c	tracing / synthetic: Disable events after testing in synth_event_gen_test_init()	2023-12-21 10:04:45 -05:00
trace_benchmark.c	tracing: Improve benchmark test performance by using do_div()	2024-05-13 20:00:57 -04:00
trace_benchmark.h	tracing: Add numeric delta time to the trace event benchmark	2022-09-26 13:01:09 -04:00
trace_boot.c	tracing: Allow creating instances with specified system events	2023-12-18 23:14:16 -05:00
trace_branch.c	tracing: Merge irqflags + preempt counter.	2021-02-02 17:02:06 -05:00
trace_btf.c	tracing/probes: Fix to search structure fields correctly	2024-02-17 21:25:42 +09:00
trace_btf.h	tracing/probes: Add a function to search a member of a struct/union	2023-08-23 09:40:16 +09:00
trace_clock.c	tracing: Do no increment trace_clock_global() by one	2021-06-18 09:10:00 -04:00
trace_dynevent.c	tracing: Free buffers when a used dynamic event is removed	2022-11-23 19:07:12 -05:00
trace_dynevent.h	tracing: Add DYNAMIC flag for dynamic events	2021-08-18 18:10:32 -04:00
trace_entries.h	tracing: Add back FORTIFY_SOURCE logic to kernel_stack event structure	2023-07-30 18:11:44 -04:00
trace_eprobe.c	tracing/probes: Support $argN in return probe (kprobe and fprobe)	2024-03-07 00:27:34 +09:00
trace_event_perf.c	tracing/perf: Use strndup_user instead of kzalloc/strncpy_from_user	2022-11-23 19:08:31 -05:00
trace_events_filter_test.h
trace_events_filter.c	tracing: Have trace_event_file have ref counters	2023-11-01 23:44:44 -04:00
trace_events_hist.c	tracing histograms: Simplify parse_actions() function	2024-01-08 13:24:56 -05:00
trace_events_inject.c	tracing: Have event inject files inc the trace array ref count	2023-09-07 16:38:54 -04:00
trace_events_synth.c	tracing/synthetic: Fix trace_string() return value	2024-02-15 11:40:01 -05:00
trace_events_trigger.c	tracing: Decrement the snapshot if the snapshot trigger fails to register	2024-03-18 10:33:05 -04:00
trace_events_user.c	user-event updates for v6.10:	2024-05-17 18:46:30 -07:00
trace_events.c	eventfs/tracing: Add callback for release of an eventfs_inode	2024-05-04 04:25:37 -04:00
trace_export.c	tracing: Add back FORTIFY_SOURCE logic to kernel_stack event structure	2023-07-30 18:11:44 -04:00
trace_fprobe.c	tracing/probes: support '%pd' type for print struct dentry's name	2024-05-01 23:18:47 +09:00
trace_functions_graph.c	function_graph: Support recording and printing the return value of function	2023-06-20 18:38:37 -04:00
trace_functions.c	ftrace: disable preemption when recursion locked	2021-10-27 11:21:49 -04:00
trace_hwlat.c	tracing: Remove extra space at the end of hwlat_detector/mode	2023-09-01 21:00:00 -04:00
trace_irqsoff.c	tracing: Fix memleak due to race between current_tracer and trace	2023-08-17 13:49:37 -04:00
trace_kdb.c	kdb: Rename members of struct kdbtab_t	2021-07-27 17:05:06 +01:00
trace_kprobe_selftest.c	tracing: arm64: Avoid missing-prototype warnings	2023-07-12 12:06:04 -04:00
trace_kprobe_selftest.h
trace_kprobe.c	Probes updates for v6.10:	2024-05-17 18:29:30 -07:00
trace_mmiotrace.c	tracing: Remove definition of DEBUG in trace_mmiotrace.c	2021-02-02 17:02:07 -05:00
trace_nop.c
trace_osnoise.c	tracing/timerlat: Move hrtimer_init to timerlat_fd open()	2024-02-01 11:50:13 -05:00
trace_output.c	tracing: Remove precision vsnprintf() check from print event	2024-03-06 13:26:26 -05:00
trace_output.h	tracing: Add "fields" option to show raw trace event fields	2023-03-29 06:52:08 -04:00
trace_preemptirq.c	cpuidle: tracing, preempt: Squash _rcuidle tracing	2023-01-31 15:01:46 +01:00
trace_printk.c	tracing: Disable "other" permission bits in the tracefs files	2021-10-08 18:08:43 -04:00
trace_probe_kernel.h	tracing/probes: Fix to record 0-length data_loc in fetch_store_string*() if fails	2023-07-14 17:04:58 +09:00
trace_probe_tmpl.h	tracing/probes: Support $argN in return probe (kprobe and fprobe)	2024-03-07 00:27:34 +09:00
trace_probe.c	Probes updates for v6.10:	2024-05-17 18:29:30 -07:00
trace_probe.h	tracing/probes: support '%pd' type for print struct dentry's name	2024-05-01 23:18:47 +09:00
trace_recursion_record.c	tracing: Use trace_create_file() to simplify creation of tracefs entries	2022-05-26 21:12:52 -04:00
trace_sched_switch.c	tracing: Move saved_cmdline code into trace_sched_switch.c	2024-03-17 07:58:53 -04:00
trace_sched_wakeup.c	tracing: Fix memleak due to race between current_tracer and trace	2023-08-17 13:49:37 -04:00
trace_selftest_dynamic.c
trace_selftest.c	tracing: Support to dump instance traces by ftrace_dump_on_oops	2024-03-18 10:33:06 -04:00
trace_seq.c	trace_seq: Increase the buffer size to almost two pages	2023-12-18 23:14:16 -05:00
trace_stack.c	tracing: Disable "other" permission bits in the tracefs files	2021-10-08 18:08:43 -04:00
trace_stat.c	tracing: Disable "other" permission bits in the tracefs files	2021-10-08 18:08:43 -04:00
trace_stat.h
trace_synth.h	tracing: Allow synthetic events to pass around stacktraces	2023-01-25 10:31:24 -05:00
trace_syscalls.c	bpf: Change syscall_nr type to int in struct syscall_tp_t	2023-10-13 12:39:36 -07:00
trace_uprobe.c	uprobes: add speculative lockless system-wide uprobe filter check	2024-05-01 23:18:46 +09:00
trace.c	tracing ring buffer updates for v6.10:	2024-05-17 18:40:37 -07:00
trace.h	tracing: Allow user-space mapping of the ring-buffer	2024-05-13 18:09:56 -04:00
tracing_map.c	tracing: Ensure visibility when inserting an element into tracing_map	2024-01-22 17:15:40 -05:00
tracing_map.h	tracing: Remove unused extern declaration tracing_map_set_field_descr()	2023-07-23 11:08:14 -04:00