Andreas Gruenbacher
49edd5bf42
gfs2: Fixes to "Implement iomap for block_map"
...
It turns out that commit 3974320ca6 "Implement iomap for block_map"
introduced a few bugs that trigger occasional failures with xfstest
generic/476:
In gfs2_iomap_begin, we jump to do_alloc when we determine that we are
beyond the end of the allocated metadata (height > ip->i_height).
There, we can end up calling hole_size with a metapath that doesn't
match the current metadata tree, which doesn't make sense. After
untangling the code at do_alloc, fix this by checking if the block we
are looking for is within the range of allocated metadata.
In addition, add a BUG() in case gfs2_iomap_begin is accidentally called
for reading stuffed files: this is handled separately. Make sure we
don't truncate iomap->length for reads beyond the end of the file; in
that case, the entire range counts as a hole.
Finally, revert to taking a bitmap write lock when doing allocations.
It's unclear why that change didn't lead to any failures during testing.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
2018-02-13 13:38:10 -07:00
..
2018-01-01 12:45:37 -07:00
2017-11-27 13:05:09 -08:00
2018-01-29 06:42:20 -05:00
2018-01-29 13:33:53 -08:00
2018-01-30 14:43:12 -08:00
2018-01-15 12:07:54 -08:00
2017-11-02 11:10:55 +01:00
2018-01-31 19:25:25 -08:00
2017-11-27 16:20:05 -05:00
2018-01-31 19:25:25 -08:00
2018-02-03 16:25:42 -08:00
2018-01-30 17:58:07 -08:00
2017-10-19 16:15:16 +02:00
2017-12-17 12:20:58 -08:00
2018-02-01 10:51:18 -05:00
2017-11-27 16:20:05 -05:00
2018-01-31 08:48:37 -08:00
2018-01-30 18:59:03 -08:00
2018-01-30 17:58:07 -08:00
2017-07-11 06:09:21 -04:00
2017-11-27 13:05:09 -08:00
2018-02-03 16:25:42 -08:00
2017-03-03 11:38:56 -08:00
2018-02-03 16:25:42 -08:00
2018-02-04 10:43:12 -08:00
2018-02-04 10:43:12 -08:00
2018-01-29 06:42:20 -05:00
2018-01-15 12:07:57 -08:00
2017-11-16 11:41:22 -08:00
2018-01-30 17:58:07 -08:00
2018-02-13 13:38:10 -07:00
2017-11-27 13:05:09 -08:00
2018-01-01 12:45:37 -07:00
2017-11-02 11:10:55 +01:00
2017-12-10 12:58:18 -08:00
2018-01-31 17:18:39 -08:00
2017-11-27 13:05:09 -08:00
2018-01-10 00:27:29 -05:00
2018-01-31 19:25:25 -08:00
2018-02-03 16:25:42 -08:00
2018-01-30 17:58:07 -08:00
2018-01-24 17:33:57 -05:00
2017-11-27 13:05:09 -08:00
2018-01-31 09:25:20 -08:00
2017-11-27 16:45:11 -05:00
2018-01-29 13:33:53 -08:00
2017-11-27 13:05:09 -08:00
2017-11-02 11:10:55 +01:00
2018-01-30 17:58:07 -08:00
2018-01-01 10:09:33 -05:00
2018-01-31 17:18:35 -08:00
2017-11-02 11:10:55 +01:00
2017-11-27 13:05:09 -08:00
2018-02-03 16:25:42 -08:00
2017-12-14 11:14:52 +01:00
2018-01-31 17:18:38 -08:00
2017-11-28 16:39:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-29 16:46:48 +01:00
2017-09-06 17:27:26 -07:00
2018-01-01 12:45:37 -07:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2018-02-01 13:36:15 -08:00
2017-11-27 13:05:09 -08:00
2017-07-06 03:31:46 -04:00
2018-02-04 10:43:12 -08:00
2017-11-27 13:05:09 -08:00
2018-02-03 16:25:42 -08:00
2018-02-03 13:49:22 -08:00
2017-11-17 11:54:55 -08:00
2016-12-24 11:46:01 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-09-04 19:05:15 -04:00
2017-11-17 12:54:01 -08:00
2017-11-16 12:50:35 -08:00
2017-11-02 11:10:55 +01:00
2017-10-13 16:18:33 -07:00
2017-10-03 17:54:25 -07:00
2017-11-14 15:32:19 -08:00
2018-01-31 09:25:20 -08:00
2017-11-02 11:10:55 +01:00
2017-02-01 09:13:51 +01:00
2017-11-17 12:54:01 -08:00
2017-04-17 12:52:27 -04:00
2017-11-17 11:54:55 -08:00
2018-02-03 13:49:22 -08:00
2018-02-03 16:25:42 -08:00
2016-12-24 11:46:01 -08:00
2018-01-08 10:41:39 -08:00
2017-11-02 11:10:55 +01:00
2018-01-31 09:25:20 -08:00
2017-11-28 19:56:15 -05:00
2018-01-03 10:13:36 -08:00
2018-01-31 17:18:39 -08:00
2018-01-15 12:07:51 -08:00
2017-12-07 14:23:30 -05:00
2018-01-31 09:25:20 -08:00
2017-11-02 11:10:55 +01:00
2017-11-07 10:32:44 +01:00
2017-03-02 08:42:35 +01:00
2018-01-06 09:18:00 -07:00
2018-01-29 06:42:21 -05:00
2017-11-10 08:48:46 -05:00
2017-11-02 11:10:55 +01:00
2018-01-29 07:27:24 -08:00
2018-02-01 09:51:57 -08:00
2017-09-10 19:31:46 -04:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-28 13:55:01 +01:00
2018-01-09 23:57:52 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-31 09:25:20 -08:00
2017-12-09 20:16:33 -05:00
2017-12-31 16:12:23 +01:00
2017-09-05 12:53:12 +02:00
2017-11-27 16:20:05 -05:00
2017-05-23 08:41:17 -05:00
2017-02-04 00:01:06 +13:00
2018-01-02 19:27:28 -08:00
2018-01-30 17:58:07 -08:00
2017-11-17 12:08:18 -08:00
2017-11-07 10:32:44 +01:00
2017-11-29 19:00:41 -05:00
2017-11-02 11:10:55 +01:00
2017-11-27 16:20:05 -05:00
2017-10-25 11:01:08 +02:00
2017-11-02 11:10:55 +01:00
2017-11-27 13:05:09 -08:00
2018-01-31 09:25:20 -08:00
2017-11-14 15:32:19 -08:00
2017-11-27 16:20:05 -05:00
2018-01-31 17:18:39 -08:00
2017-11-02 11:10:55 +01:00
2017-10-04 18:03:15 +11:00