Takashi Iwai
088e861edf
ALSA: control: Hardening for potential Spectre v1 ...
As recently Smatch suggested, a few places in ALSA control core codes
may expand the array directly from the user-space value with
speculation:
sound/core/control.c:1003 snd_ctl_elem_lock() warn: potential spectre issue 'kctl->vd'
sound/core/control.c:1031 snd_ctl_elem_unlock() warn: potential spectre issue 'kctl->vd'
sound/core/control.c:844 snd_ctl_elem_info() warn: potential spectre issue 'kctl->vd'
sound/core/control.c:891 snd_ctl_elem_read() warn: potential spectre issue 'kctl->vd'
sound/core/control.c:939 snd_ctl_elem_write() warn: potential spectre issue 'kctl->vd'
Although all these seem doing only the first load without further
reference, we may want to stay in a safer side, so hardening with
array_index_nospec() would still make sense.
In this patch, we put array_index_nospec() to the common
snd_ctl_get_ioff*() helpers instead of each caller. These helpers are
also referred from some drivers, too, and basically all usages are to
calculate the array index from the user-space value, hence it's better
to cover there.
BugLink: https://marc.info/?l=linux-kernel&m=152411496503418&w=2
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2018-04-25 10:37:46 +02:00
2018-02-12 08:38:42 +01:00
2017-09-04 18:24:56 +01:00
2017-11-02 11:10:55 +01:00
2015-01-02 16:26:20 +01:00
2008-07-14 09:01:02 +02:00
2011-08-17 00:53:54 +09:00
2013-02-10 11:22:23 -07:00
2009-09-21 15:44:51 +02:00
2017-05-17 07:13:03 +02:00
2017-05-17 07:13:03 +02:00
2017-05-17 07:13:03 +02:00
2012-10-02 18:01:25 +01:00
2011-05-19 14:10:45 -07:00
2017-11-02 11:10:55 +01:00
2012-10-09 09:49:13 +01:00
2012-10-09 09:49:13 +01:00
2012-04-18 08:00:36 +02:00
2016-11-15 07:28:15 +01:00
2018-04-25 10:37:46 +02:00
2017-10-11 15:06:10 +02:00
2016-06-27 17:39:06 +01:00
2016-10-21 12:02:44 +01:00
2017-05-19 17:31:34 +01:00
2013-11-28 10:20:51 +00:00
2014-05-05 18:20:22 -07:00
2013-10-18 00:37:29 +01:00
2009-11-18 07:23:16 +01:00
2012-12-24 15:53:28 +00:00
2007-10-16 16:51:18 +02:00
2014-04-03 14:59:48 +02:00
2015-10-07 15:11:34 +01:00
2015-11-30 12:24:12 +00:00
2015-10-02 18:11:27 +01:00
2018-03-09 17:40:41 +00:00
2012-09-28 14:21:54 +01:00
2017-06-28 19:01:12 +01:00
2018-03-13 09:42:08 -07:00
2012-10-02 18:01:25 +01:00
2018-02-14 07:46:55 +01:00
2012-10-02 18:01:25 +01:00
2012-10-02 18:01:25 +01:00
2017-06-09 22:09:45 +02:00
2015-01-02 16:27:03 +01:00
2015-01-28 16:49:33 +01:00
2017-11-02 11:10:55 +01:00
2007-10-16 15:58:10 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-01 12:48:16 +00:00
2018-04-05 10:42:07 -07:00
2017-05-24 18:45:29 +01:00
2017-11-27 16:19:52 -05:00
2015-11-30 11:40:08 +01:00
2017-11-27 16:19:52 -05:00
2012-08-03 12:57:44 +02:00
2016-02-23 09:03:07 +01:00
2017-11-02 11:10:55 +01:00
2012-01-30 21:50:55 +00:00
2010-10-18 16:46:27 -07:00
2013-03-20 10:54:12 +01:00
2012-05-13 23:33:53 +01:00
2014-01-09 07:32:10 +01:00
2011-12-23 10:07:46 +01:00
2017-05-17 07:13:04 +02:00
2012-10-02 18:01:25 +01:00
2017-08-16 12:52:41 +03:00
2014-05-26 15:32:32 +01:00
2017-06-09 22:09:45 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-03-23 22:18:05 +01:00
2015-02-24 00:43:18 +09:00
2017-05-25 23:34:45 +02:00
2017-11-29 09:26:33 +01:00
2017-11-10 21:31:02 +00:00
2017-05-17 07:13:04 +02:00
2014-07-04 18:50:51 +01:00
2015-07-09 12:00:11 +01:00
2017-11-07 11:23:36 +01:00
2015-10-22 13:33:00 +01:00
2017-12-12 10:41:56 +00:00
2018-02-12 09:31:26 +00:00
2016-09-24 19:51:57 +01:00
2017-09-19 12:57:59 +01:00
2017-02-25 12:12:50 -08:00
2015-03-11 12:08:20 +00:00
2017-11-02 11:10:55 +01:00
2012-10-09 09:49:13 +01:00
2015-01-28 16:49:33 +01:00
2015-02-12 14:15:54 +01:00
2017-11-06 20:25:31 +01:00
2012-10-02 18:01:25 +01:00
2012-10-02 18:01:25 +01:00
2012-10-02 18:01:25 +01:00
2017-10-09 14:10:13 +02:00
2009-11-04 09:17:40 +01:00
2012-12-24 15:57:20 +00:00
2017-09-01 11:34:23 +01:00
2016-07-01 17:34:02 +02:00
2017-11-13 15:45:57 +01:00
2018-01-08 15:56:34 +00:00
2018-01-12 21:20:29 +00:00
2018-01-18 11:56:17 +00:00
2018-03-13 09:45:01 -07:00
2015-04-09 11:32:29 +01:00
2017-06-09 18:46:08 +01:00
2018-03-28 10:28:30 +08:00
2012-10-02 18:01:25 +01:00
2015-04-28 16:31:01 +01:00
2012-06-23 11:58:10 +01:00
2015-01-27 17:13:25 +00:00
2014-05-05 12:52:59 -07:00
2014-07-17 17:57:05 +01:00
2017-11-02 11:10:55 +01:00
2012-10-02 18:01:25 +01:00
2017-11-06 10:41:24 +01:00
2013-02-04 18:35:19 +00:00
2017-07-17 16:22:28 +01:00
2011-05-11 16:12:35 +01:00
2016-09-25 22:16:49 +02:00
2011-09-21 16:07:45 +01:00
2014-11-24 18:04:49 +00:00
2009-06-15 21:54:48 +01:00
2014-09-15 15:52:03 +02:00
2012-08-23 16:12:12 +01:00
2011-09-23 17:05:38 +01:00
2012-12-24 15:42:35 +00:00
2013-02-05 15:53:07 +00:00
2011-09-20 16:02:16 +01:00
2011-12-06 10:29:22 +00:00
2015-10-20 15:46:09 +01:00
2009-12-18 13:06:47 +00:00
2012-09-21 08:35:06 -04:00
2014-07-31 20:51:26 +01:00
2012-08-22 19:00:37 +01:00
2011-08-08 14:30:37 +09:00
2011-03-01 23:30:53 +00:00
2010-04-30 16:12:44 +01:00
2015-01-02 16:30:08 +01:00
088e861edf