Neill Kapron 4ca651df07 phy: rockchip-typec: fix tcphy_get_mode error case ...

The existing logic in tcphy_get_mode() can cause the phy to be
incorrectly configured to USB UFP or DisplayPort mode when
extcon_get_state returns an error code.

extcon_get_state() can return 0, 1, or a negative error code.

It is possible to get into the failing state with an extcon driver
which does not support the extcon connector id specified as the
second argument to extcon_get_state().

tcphy_get_mode()
->extcon_get_state()
-->find_cable_index_by_id()
--->return -EINVAL;

Fixes: e96be45cb84e ("phy: Add USB Type-C PHY driver for rk3399")
Signed-off-by: Neill Kapron <nkapron@google.com>
Reviewed-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230126001013.3707873-1-nkapron@google.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

2023-02-14 19:25:28 +05:30

..

Kconfig

phy: rockchip: Support PCIe v3

2022-09-04 20:35:48 +05:30

Makefile

phy: rockchip: Support PCIe v3

2022-09-04 20:35:48 +05:30

phy-rockchip-dp.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 178

2019-05-30 11:29:19 -07:00

phy-rockchip-dphy-rx0.c

phy/rockchip: Use of_device_get_match_data()

2022-04-13 15:23:23 +05:30

phy-rockchip-emmc.c

phy: rockchip: emmc, add vendor prefix to dts properties

2021-01-13 17:28:24 +05:30

phy-rockchip-inno-csidphy.c

phy: rockchip: add support for the rk356x variant to rockchip-inno-csidphy

2022-09-02 23:00:47 +05:30

phy-rockchip-inno-dsidphy.c

phy: rockchip: inno-dsidphy: Add support for rk3568

2022-09-20 11:39:47 +05:30

phy-rockchip-inno-hdmi.c

phy: rockchip: remove redundant initialization of pointer cfg

2021-06-21 09:22:37 +05:30

phy-rockchip-inno-usb2.c

phy: rockchip-inno-usb2: Return zero after otg sync

2022-09-04 20:53:40 +05:30

phy-rockchip-naneng-combphy.c

phy: rockchip: add naneng combo phy for RK3568

2022-02-24 20:13:52 +05:30

phy-rockchip-pcie.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235

2019-06-19 17:09:07 +02:00

phy-rockchip-snps-pcie3.c

phy: rockchip-snps-pcie3: only look for rockchip,pipe-grf on rk3588

2022-09-29 11:43:04 +05:30

phy-rockchip-typec.c

phy: rockchip-typec: fix tcphy_get_mode error case

2023-02-14 19:25:28 +05:30

phy-rockchip-usb.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235

2019-06-19 17:09:07 +02:00