Steven Rostedt (Google)
5677a3d713
tracing: Fix last_cmd_set() string management in histogram code ...
Using strnlen(dest, str, n) is confusing, as the size of dest must be
strlen(dest) + n + 1. Even more confusing, using sizeof(string constant)
gives you strlen(string constant) + 1 and not just strlen().
These two together made using strncat() with a constant string a bit off
in the calculations as we have:
len = sizeof(HIST_PREFIX) + strlen(str) + 1;
kfree(last_cmd);
last_cmd = kzalloc(len, GFP_KERNEL);
strcpy(last_cmd, HIST_PREFIX);
len -= sizeof(HIST_PREFIX) + 1;
strncat(last_cmd, str, len);
The above works if we s/sizeof/strlen/ with HIST_PREFIX (which is defined
as "hist:", but because sizeof(HIST_PREFIX) is equal to
strlen(HIST_PREFIX) + 1, we can drop the +1 in the code. But at least
comment that we are doing so.
Link: https://lore.kernel.org/all/202203082112.Iu7tvFl4-lkp@intel.com/
Fixes: 9f8e5aee93ed2 ("tracing: Fix allocation of last_cmd in last_cmd_set()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
2022-03-10 17:41:18 -05:00
2022-01-19 01:21:46 +01:00
2022-01-11 09:14:37 -08:00
2022-01-20 08:52:55 +02:00
2021-11-03 17:21:37 +00:00
2022-01-16 15:53:00 +02:00
2021-12-01 00:06:43 +01:00
2022-01-12 16:26:58 -08:00
2022-01-17 05:49:30 +02:00
2021-12-02 17:25:21 +09:00
2022-01-22 08:33:37 +02:00
2022-01-11 09:51:26 -08:00
2022-01-16 10:08:13 +02:00
2022-01-22 08:33:37 +02:00
2021-12-08 16:06:10 +01:00
2022-01-22 08:33:36 +02:00
2022-01-15 20:37:06 +02:00
2022-01-17 05:49:30 +02:00
2022-01-23 06:20:44 +02:00
2022-03-10 17:41:18 -05:00
2021-05-02 00:43:35 +09:00
2021-10-18 06:17:01 -06:00
2021-05-07 00:26:33 -07:00
2021-10-27 12:32:34 +02:00
2021-12-14 17:39:42 -05:00
2021-11-06 16:43:20 -07:00
2022-01-11 13:08:21 -08:00
2021-11-01 21:17:39 -07:00
2022-01-11 13:08:21 -08:00
2021-11-22 17:52:47 -05:00
2021-01-24 14:27:16 +01:00
2021-08-11 13:11:12 -07:00
2021-09-08 15:32:35 -07:00
2021-08-16 18:55:32 +02:00
2021-11-24 12:20:27 +01:00
2021-12-25 12:20:55 -08:00
2021-10-20 10:45:34 -05:00
2022-01-20 08:52:55 +02:00
2022-01-08 12:43:57 -06:00
2021-11-09 10:02:51 -08:00
2020-12-15 22:46:19 -08:00
2022-01-17 05:49:30 +02:00
2021-06-18 11:43:08 +02:00
2021-05-27 04:01:50 +09:00
2021-02-26 09:41:03 -08:00
2022-01-22 08:33:34 +02:00
2021-10-15 11:25:18 +02:00
2021-07-05 10:46:20 +02:00
2022-01-16 10:08:13 +02:00
2020-12-15 19:36:48 -08:00
2021-08-17 17:50:51 +02:00
2021-11-11 13:09:33 +01:00
2021-11-09 10:02:52 -08:00
2021-12-13 12:04:45 -06:00
2021-11-06 13:30:42 -07:00
2021-02-22 12:33:26 +00:00
2021-09-08 15:32:34 -07:00
2021-05-07 00:26:33 -07:00
2022-01-22 08:33:36 +02:00
2022-01-20 10:41:01 +02:00
2022-01-11 18:45:02 -08:00
2022-01-13 07:17:47 -08:00
2021-01-19 10:24:45 +01:00
2021-01-19 10:24:45 +01:00
2022-01-11 18:45:02 -08:00
2022-01-17 07:32:51 +02:00
2021-12-29 10:37:33 +01:00
2021-09-03 09:58:12 -07:00
2021-08-27 16:30:18 +08:00
2022-01-20 08:52:55 +02:00
2021-12-28 11:26:18 +01:00
2021-09-03 09:58:12 -07:00
2021-10-14 13:29:18 +02:00
2022-01-08 12:43:57 -06:00
2022-01-08 12:43:57 -06:00
2021-11-12 11:53:16 -08:00
2020-12-15 22:46:18 -08:00
2020-11-25 18:52:35 +01:00
2022-01-22 08:33:37 +02:00
2021-09-22 10:24:01 -04:00
2021-12-07 16:36:17 -08:00
2021-09-30 09:37:27 +01:00
2021-09-01 14:52:05 -07:00
2022-01-17 05:49:30 +02:00
2021-10-22 15:32:46 +02:00
2021-08-10 14:57:42 +02:00
2021-12-02 15:07:22 +01:00
2022-01-22 08:33:35 +02:00
2021-11-06 13:30:43 -07:00
2021-07-05 10:46:33 +02:00
2021-03-23 16:01:58 +01:00
2022-01-15 16:30:30 +02:00
2022-01-20 10:41:01 +02:00
2021-06-23 16:41:24 -06:00
2022-01-22 08:33:37 +02:00
2021-04-30 11:20:42 -07:00
2020-11-16 08:08:54 -08:00
2021-12-07 16:36:17 -08:00
2021-08-16 11:39:51 -04:00
2022-01-08 12:43:57 -06:00
2021-12-09 15:37:18 -06:00
2021-05-07 00:26:34 -07:00
2021-05-09 13:07:03 -07:00
2021-09-03 09:58:12 -07:00
2021-09-08 11:50:27 -07:00
2021-07-03 11:41:14 -07:00
2021-01-26 11:16:34 +00:00
2022-01-22 08:33:34 +02:00
2021-08-17 07:49:10 -10:00
2022-01-10 07:54:04 -10:00
5677a3d713