Alexei Starovoitov
cdc4e47da8
bpf: avoid copying junk bytes in bpf_get_current_comm()
...
Lots of places in the kernel use memcpy(buf, comm, TASK_COMM_LEN); but
the result is typically passed to print("%s", buf) and extra bytes
after zero don't cause any harm.
In bpf the result of bpf_get_current_comm() is used as the part of
map key and was causing spurious hash map mismatches.
Use strlcpy() to guarantee zero-terminated string.
bpf verifier checks that output buffer is zero-initialized,
so even for short task names the output buffer don't have junk bytes.
Note it's not a security concern, since kprobe+bpf is root only.
Fixes: ffeedafbf023 ("bpf: introduce current->pid, tgid, uid, gid, comm accessors")
Reported-by: Tobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-03-09 23:27:30 -05:00
..
2016-03-09 23:27:30 -05:00
2015-06-16 11:04:29 +01:00
2015-12-04 22:46:25 +01:00
2016-03-08 12:34:12 -05:00
2015-12-04 22:46:25 +01:00
2016-01-31 14:48:58 -08:00
2015-12-04 22:51:07 +01:00
2016-02-14 12:02:05 -08:00
2016-01-27 23:20:14 +01:00
2016-01-20 17:09:18 -08:00
2015-12-07 17:02:54 -08:00
2016-02-17 10:02:00 +01:00
2016-01-31 15:49:06 -08:00
2016-03-08 15:28:30 -05:00
2015-10-21 15:18:35 +01:00
2015-04-11 22:27:55 -04:00
2015-11-19 17:51:48 +01:00
2016-01-22 18:04:28 -05:00
2015-11-04 08:23:51 -05:00
2016-01-22 18:04:28 -05:00
2016-01-17 19:13:15 -08:00
2015-12-24 11:09:39 -05:00
2015-11-04 08:23:51 -05:00
2015-12-24 11:09:39 -05:00
2014-06-04 16:54:14 -07:00
2014-08-08 15:57:18 -07:00
2015-04-15 16:35:22 -07:00
2015-12-03 10:24:08 -05:00
2015-12-14 14:54:37 -05:00
2016-01-22 10:42:58 -05:00
2015-06-04 23:57:18 +02:00
2015-11-24 09:56:43 +01:00
2015-09-03 02:42:20 +02:00
2016-01-20 17:09:18 -08:00
2016-01-22 10:22:46 -05:00
2014-08-25 15:42:19 -07:00
2016-01-14 16:00:49 -08:00
2016-01-14 16:00:49 -08:00
2015-04-12 21:03:31 +02:00
2016-01-20 17:09:18 -08:00
2015-09-10 13:29:01 -07:00
2016-01-14 16:00:49 -08:00
2014-10-21 23:44:20 +02:00
2016-01-20 17:09:18 -08:00
2016-01-26 11:08:35 +01:00
2015-04-15 16:35:22 -07:00
2015-04-15 16:35:22 -07:00
2015-11-23 09:44:58 +01:00
2015-11-23 09:44:58 +01:00
2014-10-14 02:18:16 +02:00
2016-01-20 17:09:18 -08:00
2015-05-12 09:46:00 +02:00
2016-01-20 17:09:18 -08:00
2016-01-20 17:09:18 -08:00
2016-01-20 17:09:18 -08:00
2016-01-20 17:09:18 -08:00
2015-10-23 17:55:10 +09:00
2015-08-04 10:16:54 +02:00
2015-12-07 16:59:37 -08:00
2015-09-04 16:54:41 -07:00
2014-06-04 16:54:15 -07:00
2015-09-11 15:21:34 -07:00
2015-09-11 15:21:34 -07:00
2016-02-25 18:54:53 -08:00
2015-10-21 15:18:36 +01:00
2016-02-18 16:34:15 -08:00
2015-09-01 08:40:25 -07:00
2014-12-04 14:34:54 -05:00
2015-02-13 21:21:38 -08:00
2016-01-16 11:17:25 -08:00
2015-11-09 15:53:39 -08:00
2014-12-16 15:53:03 -08:00
2016-01-31 15:44:04 -08:00
2015-09-08 15:35:28 -07:00
2016-01-20 17:09:18 -08:00
2015-01-17 10:02:23 +13:00
2015-09-10 13:29:01 -07:00
2016-01-22 18:04:28 -05:00
2016-02-20 08:57:52 -08:00
2016-01-27 07:38:25 -08:00
2016-02-05 18:10:40 -08:00
2015-11-06 17:50:42 -08:00
2015-10-20 10:23:55 +02:00
2015-02-09 15:24:03 -08:00
2014-12-13 12:42:48 -08:00
2016-01-16 11:17:24 -08:00
2015-12-01 14:00:53 -05:00
2016-01-20 17:09:18 -08:00
2014-12-10 17:41:10 -08:00
2016-01-22 10:24:03 -08:00
2015-09-05 13:46:58 -07:00
2015-01-18 01:03:45 -05:00
2014-08-08 15:57:18 -07:00
2015-10-06 11:25:01 -07:00
2015-10-25 21:33:54 -04:00
2014-07-23 10:18:05 -07:00
2014-12-05 17:19:27 -06:00
2016-01-04 10:27:55 -05:00
2014-08-26 13:45:45 -04:00
2014-12-17 12:31:40 -08:00
2014-06-06 16:08:16 -07:00
2014-12-04 14:34:47 -05:00
2016-01-11 18:53:13 -08:00
2014-05-20 10:59:32 -04:00
2016-02-10 12:13:05 -05:00