Alexei Starovoitov cdc4e47da8 bpf: avoid copying junk bytes in bpf_get_current_comm()
Lots of places in the kernel use memcpy(buf, comm, TASK_COMM_LEN); but
the result is typically passed to print("%s", buf) and extra bytes
after zero don't cause any harm.
In bpf the result of bpf_get_current_comm() is used as the part of
map key and was causing spurious hash map mismatches.
Use strlcpy() to guarantee zero-terminated string.
bpf verifier checks that output buffer is zero-initialized,
so even for short task names the output buffer don't have junk bytes.
Note it's not a security concern, since kprobe+bpf is root only.

Fixes: ffeedafbf023 ("bpf: introduce current->pid, tgid, uid, gid, comm accessors")
Reported-by: Tobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-03-09 23:27:30 -05:00
..
2015-12-04 22:46:25 +01:00
2016-03-08 15:28:30 -05:00
2015-04-11 22:27:55 -04:00
2015-11-19 17:51:48 +01:00
2016-01-22 18:04:28 -05:00
2016-01-22 18:04:28 -05:00
2014-08-08 15:57:18 -07:00
2015-12-14 14:54:37 -05:00
2015-04-12 21:03:31 +02:00
2016-01-14 16:00:49 -08:00
2016-01-26 11:08:35 +01:00
2015-11-23 09:44:58 +01:00
2014-12-04 14:34:54 -05:00
2015-01-17 10:02:23 +13:00
2016-01-22 18:04:28 -05:00
2014-12-10 17:41:10 -08:00