Richard Fitzgerald
900fdc4573
lib: vsprintf: Fix handling of number field widths in vsscanf
...
The existing code attempted to handle numbers by doing a strto[u]l(),
ignoring the field width, and then repeatedly dividing to extract the
field out of the full converted value. If the string contains a run of
valid digits longer than will fit in a long or long long, this would
overflow and no amount of dividing can recover the correct value.
This patch fixes vsscanf() to obey number field widths when parsing
the number.
A new _parse_integer_limit() is added that takes a limit for the number
of characters to parse. The number field conversion in vsscanf is changed
to use this new function.
If a number starts with a radix prefix, the field width must be long
enough for at last one digit after the prefix. If not, it will be handled
like this:
sscanf("0x4", "%1i", &i): i=0, scanning continues with the 'x'
sscanf("0x4", "%2i", &i): i=0, scanning continues with the '4'
This is consistent with the observed behaviour of userland sscanf.
Note that this patch does NOT fix the problem of a single field value
overflowing the target type. So for example:
sscanf("123456789abcdef", "%x", &i);
Will not produce the correct result because the value obviously overflows
INT_MAX. But sscanf will report a successful conversion.
Note that where a very large number is used to mean "unlimited", the value
INT_MAX is used for consistency with the behaviour of vsnprintf().
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20210514161206.30821-2-rf@opensource.cirrus.com
2021-05-19 15:05:11 +02:00
..
2020-08-10 01:32:59 +09:00
2021-04-22 17:31:29 +10:00
2020-11-18 14:15:17 -06:00
2021-01-07 21:06:25 +01:00
2021-02-08 16:09:27 -07:00
2020-08-09 14:10:26 -07:00
2020-12-15 22:46:16 -08:00
2020-12-15 22:46:19 -08:00
2021-03-24 16:42:54 -07:00
2020-10-30 17:34:45 +11:00
2020-07-28 17:07:06 -07:00
2021-01-04 10:38:11 +09:00
2020-08-10 01:32:59 +09:00
2020-08-06 10:57:30 +02:00
2020-11-18 14:15:17 -06:00
2020-08-10 01:32:59 +09:00
2020-12-29 15:36:49 -08:00
2020-11-19 07:23:47 -06:00
2020-11-19 07:23:47 -06:00
2020-03-25 11:50:48 +01:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-11-18 14:15:17 -06:00
2021-04-14 16:30:30 +03:00
2020-11-18 14:15:17 -06:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-05-24 20:48:11 +02:00
2020-10-16 13:25:14 -06:00
2020-10-16 11:11:19 -07:00
2019-05-21 10:50:45 +02:00
2020-11-18 14:15:17 -06:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-02-08 12:24:26 +01:00
2019-05-24 17:27:11 +02:00
2021-01-14 19:29:58 -08:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2020-08-20 15:45:14 -04:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2021-02-15 11:43:31 +01:00
2021-02-26 09:41:04 -08:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-10-18 15:01:57 +02:00
2021-02-05 23:28:29 +01:00
2019-06-19 17:09:06 +02:00
2021-01-21 14:06:00 -07:00
2017-09-26 15:01:20 -06:00
2019-06-19 17:09:06 +02:00
2020-10-16 11:11:20 -07:00
2018-07-27 19:04:33 +08:00
2020-11-02 12:14:19 -08:00
2020-08-12 10:58:00 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-06-18 17:26:43 +10:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-05-19 15:47:21 +02:00
2020-10-01 16:13:54 +02:00
2018-06-12 23:33:24 +02:00
2020-10-16 11:11:19 -07:00
2020-01-31 10:30:40 -08:00
2019-06-19 17:09:55 +02:00
2020-08-12 10:58:00 -07:00
2019-05-24 17:37:53 +02:00
2015-09-10 13:29:01 -07:00
2020-09-03 10:13:09 +02:00
2020-07-31 11:49:08 +02:00
2020-12-11 12:28:08 -08:00
2021-04-08 20:18:38 +09:00
2020-11-20 14:45:33 +11:00
2020-11-10 18:38:57 +01:00
2020-12-09 20:10:12 +01:00
2020-10-16 11:11:20 -07:00
2021-04-16 16:10:37 -07:00
2020-12-15 22:46:15 -08:00
2020-12-15 22:46:19 -08:00
2020-12-15 22:46:15 -08:00
2021-01-03 20:05:18 -05:00
2020-10-16 11:11:22 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2014-04-30 19:49:37 +01:00
2019-06-05 17:36:38 +02:00
2020-12-15 22:46:15 -08:00
2020-06-04 19:06:25 -07:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-02-26 09:41:04 -08:00
2019-10-14 15:04:00 -07:00
2020-11-18 14:15:17 -06:00
2017-02-24 17:46:57 -08:00
2020-10-16 11:11:19 -07:00
2019-05-13 11:07:33 +02:00
2020-10-20 14:39:37 -07:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2020-08-14 19:56:57 -07:00
2018-05-09 06:55:44 +02:00
2021-04-26 22:55:12 +01:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2021-04-14 16:30:30 +03:00
2021-04-26 08:44:23 -07:00
2021-04-16 16:10:36 -07:00
2020-08-24 15:09:58 -07:00
2021-02-26 09:41:02 -08:00
2020-09-28 12:14:08 +01:00
2021-02-26 09:41:05 -08:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2021-04-10 11:09:41 +02:00
2020-09-07 11:24:17 +02:00
2021-05-19 15:05:11 +02:00
2021-05-19 15:05:11 +02:00
2020-10-16 11:11:19 -07:00
2020-12-28 12:24:47 +00:00
2018-04-11 10:28:35 -07:00
2021-04-08 16:04:22 -07:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-01-14 11:20:18 +01:00
2019-06-07 13:15:06 -07:00
2021-02-17 17:31:06 -06:00
2021-04-16 16:10:37 -07:00
2019-05-24 17:39:02 +02:00
2021-04-14 16:30:30 +03:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2020-12-16 00:24:16 -08:00
2020-08-24 14:24:25 -07:00
2017-11-02 11:10:55 +01:00
2019-07-03 16:57:18 +02:00
2017-11-02 11:10:55 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2021-03-26 19:41:58 +11:00
2017-11-04 09:26:51 +09:00
2020-06-28 20:45:27 -07:00
2021-04-16 16:10:37 -07:00
2021-02-03 19:10:42 +01:00
2018-01-26 11:45:16 -06:00
2020-10-16 11:11:20 -07:00
2019-05-21 10:50:45 +02:00
2021-01-22 15:24:23 -08:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2021-04-16 16:10:37 -07:00
2020-10-24 20:21:57 +02:00
2019-06-05 17:37:16 +02:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2019-11-25 09:15:32 +01:00
2020-07-28 17:09:49 -07:00
2020-12-07 17:12:49 -07:00
2020-10-29 08:55:45 -06:00
2020-06-15 18:22:43 -07:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2020-11-20 14:45:33 +11:00
2019-09-24 15:54:09 -07:00
2020-11-18 14:15:17 -06:00
2020-11-24 11:25:44 +01:00
2019-11-14 13:15:11 -05:00
2021-02-26 09:41:04 -08:00
2019-05-30 11:26:32 -07:00
2020-09-30 10:50:30 +02:00
2020-12-15 22:46:16 -08:00
2020-11-19 11:56:16 -08:00
2020-05-01 12:35:21 +10:00
2020-12-03 09:52:44 -08:00
2021-02-15 11:01:42 +01:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2021-01-20 14:13:48 -08:00
2019-05-21 10:50:45 +02:00
2020-12-15 22:46:16 -08:00
2021-01-18 11:03:26 +01:00
2020-12-15 22:46:16 -08:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2020-07-10 16:24:28 -03:00
2020-10-16 11:11:20 -07:00
2018-10-15 16:31:29 -04:00
2021-04-09 14:54:23 -07:00
2021-04-11 10:57:45 +01:00
2020-12-15 22:46:16 -08:00
2020-05-08 18:18:12 +01:00
2021-04-08 16:04:22 -07:00
2020-12-15 22:46:16 -08:00
2018-10-16 13:45:44 +02:00
2019-12-04 19:44:13 -08:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2019-07-16 19:23:22 -07:00
2017-02-26 11:03:38 -05:00
2021-03-19 16:38:49 +01:00
2020-09-20 14:10:06 -07:00
2017-01-09 13:58:57 -05:00
2019-05-21 10:50:45 +02:00
2020-04-07 10:43:43 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2020-10-16 11:11:20 -07:00
2021-02-26 09:41:05 -08:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2020-06-29 11:59:26 -07:00
2021-03-30 13:42:33 -04:00
2015-09-10 13:29:01 -07:00
2020-07-15 12:45:06 +03:00
2019-10-03 12:12:23 -04:00
2021-02-17 14:08:01 +01:00
2020-08-12 10:58:00 -07:00
2020-11-18 14:15:17 -06:00
2020-04-07 10:43:43 -07:00
2021-02-26 09:41:05 -08:00
2021-02-05 11:03:47 -08:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2020-10-16 11:11:22 -07:00
2020-03-23 17:01:47 +01:00
2021-05-19 15:05:11 +02:00
2017-11-02 11:10:55 +01:00
2021-03-30 13:42:33 -04:00
2020-08-12 10:58:00 -07:00