Julia Lawall 971370cc18 drivers/rtc: introduce missing kfree
Error handling code following a kzalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: David Brownell <david-b@pacbell.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-09-23 07:39:45 -07:00
..
2009-09-23 07:39:45 -07:00
2009-09-23 07:39:45 -07:00
2009-09-17 09:47:24 +02:00
2009-02-11 14:25:36 -08:00
2009-09-23 07:39:45 -07:00
2009-02-05 12:56:46 -08:00
2009-01-06 15:59:25 -08:00
2009-09-23 07:39:43 -07:00
2009-07-06 13:57:03 -07:00
2009-09-23 07:39:43 -07:00
2009-06-18 13:03:43 -07:00
2009-09-23 07:39:43 -07:00
2009-04-01 08:59:24 -07:00
2008-10-20 08:52:41 -07:00
2009-09-23 07:39:43 -07:00
2008-10-20 08:52:41 -07:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:45 -07:00
2009-01-11 01:34:24 +01:00
2009-04-02 01:05:32 +00:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:43 -07:00
2008-11-21 01:24:38 -08:00
2008-11-14 16:37:54 -08:00
2009-06-18 13:03:43 -07:00
2009-04-01 08:59:26 -07:00
2008-10-20 08:52:41 -07:00