Eric Biggers 97c6327f71 fscrypt: use smp_load_acquire() for fscrypt_prepared_key
Normally smp_store_release() or cmpxchg_release() is paired with
smp_load_acquire().  Sometimes smp_load_acquire() can be replaced with
the more lightweight READ_ONCE().  However, for this to be safe, all the
published memory must only be accessed in a way that involves the
pointer itself.  This may not be the case if allocating the object also
involves initializing a static or global variable, for example.

fscrypt_prepared_key includes a pointer to a crypto_skcipher object,
which is internal to and is allocated by the crypto subsystem.  By using
READ_ONCE() for it, we're relying on internal implementation details of
the crypto subsystem.

Remove this fragile assumption by using smp_load_acquire() instead.

(Note: I haven't seen any real-world problems here.  This change is just
fixing the code to be guaranteed correct and less fragile.)

Fixes: 5fee36095cda ("fscrypt: add inline encryption support")
Cc: Satya Tangirala <satyat@google.com>
Link: https://lore.kernel.org/r/20200721225920.114347-3-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
2020-07-21 16:02:13 -07:00
..
2020-03-27 09:29:56 +00:00
2020-06-27 22:04:24 -07:00
2020-06-23 09:20:11 -07:00
2020-06-05 16:43:16 -07:00
2019-11-11 09:21:59 -05:00
2020-07-08 10:29:43 -07:00
2020-07-08 10:29:43 -07:00
2020-06-09 15:48:24 -07:00
2020-06-02 15:29:19 -07:00
2020-06-13 12:44:30 -07:00
2020-06-02 15:29:19 -07:00
2020-06-02 20:11:35 -07:00
2020-06-09 15:40:50 -07:00
\n
2020-06-04 13:53:10 -07:00
2020-06-05 14:05:57 -07:00
2020-06-02 15:29:19 -07:00
2020-06-04 13:50:13 -07:00
2020-07-08 10:29:43 -07:00
2020-06-14 09:47:25 -07:00
2020-05-14 16:44:25 +02:00
2020-02-07 14:48:35 -05:00
2020-06-05 16:26:36 -07:00
2020-06-15 08:51:38 -06:00
2020-06-11 10:33:13 -07:00
2020-03-05 21:00:40 -05:00
2020-05-14 16:44:24 +02:00
2019-12-08 14:37:36 +01:00
2020-06-02 19:45:12 -07:00
2020-06-09 15:40:50 -07:00
2020-05-14 16:44:24 +02:00
2020-04-09 15:33:09 -04:00