Toke Høiland-Jørgensen a543ada7db crypto: api - Demote BUG_ON() in crypto_unregister_alg() to a WARN_ON()
The crypto_unregister_alg() function expects callers to ensure that any
algorithm that is unregistered has a refcnt of exactly 1, and issues a
BUG_ON() if this is not the case. However, there are in fact drivers that
will call crypto_unregister_alg() without ensuring that the refcnt has been
lowered first, most notably on system shutdown. This causes the BUG_ON() to
trigger, which prevents a clean shutdown and hangs the system.

To avoid such hangs on shutdown, demote the BUG_ON() in
crypto_unregister_alg() to a WARN_ON() with early return. Cc stable because
this problem was observed on a 6.2 kernel, cf the link below.

Link: https://lore.kernel.org/r/87r0tyq8ph.fsf@toke.dk
Cc: stable@vger.kernel.org
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2023-03-24 18:22:28 +08:00
..
2022-03-03 10:49:20 +12:00
2021-03-26 19:55:55 +11:00
2023-02-14 13:39:33 +08:00
2020-02-28 08:43:21 +08:00
2023-02-14 13:39:33 +08:00
2022-12-02 18:12:40 +08:00
2022-04-08 16:12:46 +08:00
2022-12-02 18:12:40 +08:00
2022-06-10 16:40:16 +08:00
2021-11-08 16:55:21 -08:00