Johan Hovold
cb3543cff9
regulator: core: fix deadlock on regulator enable ...
When updating the operating mode as part of regulator enable, the caller
has already locked the regulator tree and drms_uA_update() must not try
to do the same in order not to trigger a deadlock.
The lock inversion is reported by lockdep as:
======================================================
WARNING: possible circular locking dependency detected
6.1.0-next-20221215 #142 Not tainted
------------------------------------------------------
udevd/154 is trying to acquire lock:
ffffc11f123d7e50 (regulator_list_mutex){+.+.}-{3:3}, at: regulator_lock_dependent+0x54/0x280
but task is already holding lock:
ffff80000e4c36e8 (regulator_ww_class_acquire){+.+.}-{0:0}, at: regulator_enable+0x34/0x80
which lock already depends on the new lock.
...
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(regulator_ww_class_acquire);
lock(regulator_list_mutex);
lock(regulator_ww_class_acquire);
lock(regulator_list_mutex);
*** DEADLOCK ***
just before probe of a Qualcomm UFS controller (occasionally) deadlocks
when enabling one of its regulators.
Fixes: 9243a195be7a ("regulator: core: Change voltage setting path")
Fixes: f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
Cc: stable@vger.kernel.org # 5.0
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20221215104646.19818-1-johan+linaro@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
2022-12-15 11:56:26 +00:00
2020-08-21 17:28:09 +01:00
2020-05-08 18:18:13 +01:00
2019-06-19 17:09:55 +02:00
2019-06-05 17:37:07 +02:00
2021-01-13 11:36:19 +00:00
2021-01-13 11:36:19 +00:00
2022-11-24 13:54:00 +00:00
2020-05-08 18:18:13 +01:00
2022-11-23 14:17:40 +00:00
2020-06-18 13:47:31 +01:00
2020-05-08 18:18:13 +01:00
2022-11-22 17:05:04 +00:00
2020-05-08 18:18:13 +01:00
2020-11-23 18:46:31 +00:00
2022-04-04 08:59:43 +01:00
2021-01-20 18:48:20 +00:00
2020-05-08 18:18:13 +01:00
2022-11-23 13:09:06 +00:00
2021-03-15 15:42:12 +00:00
2022-11-23 13:09:05 +00:00
2022-11-23 13:09:05 +00:00
2022-11-23 13:09:05 +00:00
2022-12-15 11:56:26 +00:00
2022-06-10 14:51:35 +02:00
2022-06-08 08:14:53 +00:00
2020-06-25 15:29:21 +01:00
2021-06-23 12:34:40 +01:00
2020-09-07 18:35:25 +01:00
2020-09-07 18:35:25 +01:00
2021-07-15 17:24:50 +01:00
2022-11-22 19:37:23 +00:00
2021-11-30 13:08:18 +00:00
2020-09-07 18:35:25 +01:00
2019-05-03 15:07:39 +09:00
2020-09-07 18:35:25 +01:00
2019-05-03 15:07:39 +09:00
2020-05-06 15:16:59 +01:00
2021-07-11 23:50:43 +01:00
2019-05-30 11:29:22 -07:00
2022-12-08 13:02:37 +00:00
2021-09-27 13:01:20 +01:00
2019-05-30 11:26:32 -07:00
2022-11-24 13:54:02 +00:00
2022-11-24 16:30:19 +00:00
2018-09-17 14:32:22 -07:00
2022-04-04 08:48:30 +01:00
2022-09-29 15:20:14 +01:00
2021-05-19 14:31:43 +01:00
2021-06-21 13:02:05 +01:00
2021-07-11 23:44:37 +01:00
2020-07-22 14:43:48 +01:00
2021-10-05 08:56:08 +01:00
2022-11-03 13:34:53 +00:00
2021-11-24 12:57:30 +00:00
2022-11-24 13:54:03 +00:00
2020-01-13 15:03:06 +00:00
2022-12-02 12:23:19 +00:00
2019-07-22 13:18:13 +01:00
2020-09-07 18:49:13 +01:00
2022-11-23 14:17:41 +00:00
2022-06-10 14:51:36 +02:00
2020-01-13 15:03:06 +00:00
2022-11-22 19:37:25 +00:00
2022-11-22 19:37:25 +00:00
2020-05-08 18:18:13 +01:00
2019-09-09 10:53:48 +01:00
2021-05-19 13:34:00 +01:00
2022-11-23 14:17:42 +00:00
2020-09-07 18:35:25 +01:00
2022-12-02 12:23:19 +00:00
2022-08-24 12:21:30 +01:00
2022-11-22 19:37:26 +00:00
2022-11-22 19:37:27 +00:00
2022-11-23 14:17:43 +00:00
2021-06-21 13:07:44 +01:00
2020-06-18 13:47:34 +01:00
2019-06-19 17:09:55 +02:00
2022-11-22 19:37:28 +00:00
2022-11-23 14:17:44 +00:00
2020-06-18 13:47:35 +01:00
2020-06-26 15:34:18 +01:00
2021-09-17 13:16:38 +01:00
2022-01-19 16:47:39 +00:00
2021-05-24 09:50:20 +01:00
2020-05-08 18:18:13 +01:00
2021-06-07 16:24:07 +01:00
2021-06-03 14:04:51 +01:00
2020-08-21 17:28:15 +01:00
2019-03-04 00:01:08 +00:00
2019-05-30 11:26:32 -07:00
2019-03-04 00:01:08 +00:00
2020-12-11 13:23:07 +00:00
2021-06-01 14:05:26 +01:00
2022-11-24 16:30:19 +00:00
2022-06-07 17:21:36 +01:00
2020-05-08 18:18:13 +01:00
2020-01-14 15:25:00 +00:00
2020-01-17 15:34:31 +00:00
2020-01-13 15:03:06 +00:00
2019-04-26 10:38:23 +01:00
2021-06-23 16:56:31 +01:00
2020-05-08 18:18:13 +01:00
2022-09-13 15:04:56 +01:00
2022-09-13 15:04:58 +01:00
2022-12-02 12:23:19 +00:00
2022-04-04 15:16:10 +01:00
2021-07-11 23:50:36 +01:00
2021-03-24 19:50:21 +00:00
2022-06-29 16:31:42 +01:00
2022-07-27 13:14:46 +01:00
2021-07-11 23:50:37 +01:00
2021-07-07 12:01:32 +01:00
2022-12-08 13:02:37 +00:00
2020-05-08 18:18:13 +01:00
2020-07-22 14:43:48 +01:00
2022-11-22 19:37:29 +00:00
2019-10-01 12:46:37 +01:00
2019-05-30 11:26:32 -07:00
2021-03-10 12:47:46 +00:00
2022-11-24 13:54:08 +00:00
2020-09-07 18:35:25 +01:00
2019-05-03 15:05:52 +09:00
2022-11-24 13:54:09 +00:00
2019-05-03 15:05:52 +09:00
2020-09-07 18:35:25 +01:00
2019-05-03 15:05:52 +09:00
2021-09-27 13:01:19 +01:00
2022-09-09 22:27:12 +01:00
2022-11-10 12:52:29 +00:00
2022-08-23 18:07:56 +01:00
2021-05-10 13:06:50 +01:00
2022-12-07 14:19:18 +00:00
2022-11-23 16:08:35 +00:00
2019-05-30 11:29:52 -07:00
2022-11-28 13:04:41 +00:00
2019-12-17 13:08:41 -08:00
2021-11-18 13:57:47 +00:00
2022-11-22 19:37:30 +00:00
2022-04-25 14:00:47 +01:00
2022-03-25 16:09:31 +00:00
2021-07-11 23:50:39 +01:00
2022-06-23 13:07:50 +01:00
2022-06-06 12:39:10 +01:00
2022-04-04 08:48:13 +01:00
2021-06-16 15:41:16 +01:00
2022-11-02 14:38:36 +00:00
2021-07-15 17:24:49 +01:00
2021-07-11 23:45:15 +01:00
2022-04-04 08:38:57 +01:00
2021-09-15 13:12:39 +01:00
2021-04-21 15:51:42 +01:00
2021-04-21 15:51:43 +01:00
2021-10-08 17:24:30 +01:00
2022-03-07 13:15:01 +00:00
2022-06-30 13:25:37 +01:00
2020-05-08 18:18:13 +01:00
2020-09-17 18:25:39 +01:00
2019-05-13 11:07:43 +01:00
2022-04-26 15:13:48 +01:00
2020-08-21 17:28:20 +01:00
2020-08-21 17:28:17 +01:00
2022-12-08 13:02:37 +00:00
2021-06-21 13:08:41 +01:00
2020-09-14 14:24:38 +01:00
2022-02-08 09:27:28 +00:00
2022-11-24 16:30:19 +00:00
2022-11-24 16:30:19 +00:00
2022-11-24 16:30:19 +00:00
2022-09-19 15:44:17 +01:00
2020-09-01 15:48:52 +01:00
2022-11-22 19:37:32 +00:00
2022-06-10 14:51:35 +02:00
2019-04-15 09:44:41 +01:00
2020-09-01 15:48:56 +01:00
2022-11-22 19:37:31 +00:00
2022-11-23 14:17:45 +00:00
2022-11-23 14:17:46 +00:00
2022-06-10 14:51:36 +02:00
2020-09-01 15:48:55 +01:00
2020-01-13 15:03:06 +00:00
2022-06-10 14:51:35 +02:00
2022-06-10 14:51:36 +02:00
2022-09-26 16:10:33 +01:00
2021-07-11 23:50:38 +01:00
2022-06-10 14:51:36 +02:00
2021-12-15 22:16:53 +00:00
2020-08-23 17:36:59 -05:00
2021-12-13 19:35:43 +00:00
2021-10-21 16:08:07 +01:00
2022-11-03 13:35:06 +00:00
2022-03-15 12:03:51 +00:00
2019-11-18 12:58:24 +00:00
2022-03-02 13:45:31 +00:00
2021-09-13 01:59:24 +01:00
2020-09-07 18:35:25 +01:00
2020-09-07 18:35:25 +01:00
2020-09-07 18:35:25 +01:00
2022-03-07 13:15:01 +00:00
2020-06-26 15:34:24 +01:00
2022-04-04 08:38:56 +01:00
cb3543cff9