Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-08 14:13:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes

Browse Source 
Currently, it is possible to let some PHYs to advertise not supported
EEE link modes. So, validate them before overwriting existing
configuration.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
Oleksij Rempel 2023-02-22 06:50:43 +01:00 committed by Paolo Abeni
parent 3eeca4e199
commit 186b1da76b
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/net/phy/phy-c45.c
View File

@ -1438,12 +1438,23 @@ int genphy_c45_ethtool_set_eee(struct phy_device *phydev,
int ret; int ret;
if (data->eee_enabled) { if (data->eee_enabled) {
if (data->advertised) if (data->advertised) {
__ETHTOOL_DECLARE_LINK_MODE_MASK(adv);
ethtool_convert_legacy_u32_to_link_mode(adv,
data->advertised);
linkmode_andnot(adv, adv, phydev->supported_eee);
if (!linkmode_empty(adv)) {
phydev_warn(phydev, "At least some EEE link modes are not supported.\n");
return -EINVAL;
}
ethtool_convert_legacy_u32_to_link_mode(phydev->advertising_eee, ethtool_convert_legacy_u32_to_link_mode(phydev->advertising_eee,
data->advertised); data->advertised);
else } else {
linkmode_copy(phydev->advertising_eee, linkmode_copy(phydev->advertising_eee,
phydev->supported_eee); phydev->supported_eee);
}
phydev->eee_enabled = true; phydev->eee_enabled = true;
} else { } else {