Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-18 19:27:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

Browse Source 
mv_u3d_nuke() expects to be calles with ep->u3d->lock held,
because mv_u3d_done() does. But mv_u3d_ep_disable() calls it
without lock that can lead to unpleasant consequences.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Alexey Khoroshilov 2013-07-24 00:20:17 +04:00 committed by Felipe Balbi
parent 272b98c645
commit 2389df458b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/gadget/mv_u3d_core.c
View File

@ -645,6 +645,7 @@ static int mv_u3d_ep_disable(struct usb_ep *_ep)
struct mv_u3d_ep *ep; struct mv_u3d_ep *ep;
struct mv_u3d_ep_context *ep_context; struct mv_u3d_ep_context *ep_context;
u32 epxcr, direction; u32 epxcr, direction;
unsigned long flags;
if (!_ep) if (!_ep)
return -EINVAL; return -EINVAL;
@ -661,7 +662,9 @@ static int mv_u3d_ep_disable(struct usb_ep *_ep)
direction = mv_u3d_ep_dir(ep); direction = mv_u3d_ep_dir(ep);
/* nuke all pending requests (does flush) */ /* nuke all pending requests (does flush) */
spin_lock_irqsave(&u3d->lock, flags);
mv_u3d_nuke(ep, -ESHUTDOWN); mv_u3d_nuke(ep, -ESHUTDOWN);
spin_unlock_irqrestore(&u3d->lock, flags);
/* Disable the endpoint for Rx or Tx and reset the endpoint type */ /* Disable the endpoint for Rx or Tx and reset the endpoint type */
if (direction == MV_U3D_EP_DIR_OUT) { if (direction == MV_U3D_EP_DIR_OUT) {