fs/backing_file: fix wrong argument in callback

Commit 48b50624ae ("backing-file: clean up the API") unintentionally
changed the argument in the ->accessed() callback from the user file to
the backing file.

Fixes: 48b50624ae ("backing-file: clean up the API")
Reported-by: syzbot+8d1206605b05ca9a0e6a@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/linux-unionfs/67447b3c.050a0220.1cc393.0085.GAE@google.com/
Tested-by: syzbot+8d1206605b05ca9a0e6a@syzkaller.appspotmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://lore.kernel.org/r/20241126145342.364869-1-amir73il@gmail.com
Acked-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Amir Goldstein 2024-11-26 15:53:42 +01:00 committed by Christian Brauner
parent e7675238b9
commit 2957fa4931
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2

View File

@ -327,6 +327,7 @@ int backing_file_mmap(struct file *file, struct vm_area_struct *vma,
struct backing_file_ctx *ctx) struct backing_file_ctx *ctx)
{ {
const struct cred *old_cred; const struct cred *old_cred;
struct file *user_file = vma->vm_file;
int ret; int ret;
if (WARN_ON_ONCE(!(file->f_mode & FMODE_BACKING))) if (WARN_ON_ONCE(!(file->f_mode & FMODE_BACKING)))
@ -342,7 +343,7 @@ int backing_file_mmap(struct file *file, struct vm_area_struct *vma,
revert_creds_light(old_cred); revert_creds_light(old_cred);
if (ctx->accessed) if (ctx->accessed)
ctx->accessed(vma->vm_file); ctx->accessed(user_file);
return ret; return ret;
} }