Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-04 04:06:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rpmsg: glink: Use complete_all for open states

Browse Source 
The open_req and open_ack completion variables are the state variables
to represet a remote channel as open. Use complete_all so there are no
races with waiters and using completion_done.

Signed-off-by: Chris Lew <clew@codeaurora.org>
Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org>
Link: https://lore.kernel.org/r/1593017121-7953-2-git-send-email-deesin@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This commit is contained in:
Chris Lew 2020-06-24 22:15:18 +05:30 committed by Bjorn Andersson
parent 6c09ea0b0a
commit 4fcdaf6e28
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/rpmsg/qcom_glink_native.c
View File

@ -970,7 +970,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid)
return -EINVAL; return -EINVAL;
} }
complete(&channel->open_ack); complete_all(&channel->open_ack);
return 0; return 0;
} }
@ -1178,7 +1178,7 @@ static int qcom_glink_announce_create(struct rpmsg_device *rpdev)
__be32 *val = defaults; __be32 *val = defaults;
int size; int size;
if (glink->intentless) if (glink->intentless || !completion_done(&channel->open_ack))
return 0; return 0;
prop = of_find_property(np, "qcom,intents", NULL); prop = of_find_property(np, "qcom,intents", NULL);
@ -1413,7 +1413,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid,
channel->rcid = ret; channel->rcid = ret;
spin_unlock_irqrestore(&glink->idr_lock, flags); spin_unlock_irqrestore(&glink->idr_lock, flags);
complete(&channel->open_req); complete_all(&channel->open_req);
if (create_device) { if (create_device) {
rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL); rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL);