Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-09 14:43:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

coresight: cti: Reduce scope for the variable 'cs_fwnode' in cti_plat_create_connection()

Browse Source 
A local variable was used only within an else branch.
Thus move the definition for the variable “cs_fwnode” into
the corresponding code block.

This issue was detected by using the Coccinelle software.

Link: https://lore.kernel.org/r/c1b09b27-9012-324f-28d0-ba820dc468a5@web.de
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20210201181351.1475223-2-mathieu.poirier@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Markus Elfring 2021-02-01 11:13:21 -07:00 committed by Greg Kroah-Hartman
parent 11a0b5e0ec
commit 65b2728145
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/hwtracing/coresight/coresight-cti-platform.c
View File

@ -343,7 +343,6 @@ static int cti_plat_create_connection(struct device *dev,
{ {
struct cti_trig_con *tc = NULL; struct cti_trig_con *tc = NULL;
int cpuid = -1, err = 0; int cpuid = -1, err = 0;
struct fwnode_handle *cs_fwnode = NULL;
struct coresight_device *csdev = NULL; struct coresight_device *csdev = NULL;
const char *assoc_name = "unknown"; const char *assoc_name = "unknown";
char cpu_name_str[16]; char cpu_name_str[16];
@ -397,8 +396,9 @@ static int cti_plat_create_connection(struct device *dev,
assoc_name = cpu_name_str; assoc_name = cpu_name_str;
} else { } else {
/* associated device ? */ /* associated device ? */
cs_fwnode = fwnode_find_reference(fwnode, struct fwnode_handle *cs_fwnode = fwnode_find_reference(fwnode,
CTI_DT_CSDEV_ASSOC, 0); CTI_DT_CSDEV_ASSOC,
0);
if (!IS_ERR(cs_fwnode)) { if (!IS_ERR(cs_fwnode)) {
assoc_name = cti_plat_get_csdev_or_node_name(cs_fwnode, assoc_name = cti_plat_get_csdev_or_node_name(cs_fwnode,
&csdev); &csdev);