Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-01 10:45:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

sparc64: fix incorrect sign extension in sys_sparc64_personality

Browse Source 
commit 525fd5a94e upstream.

The value returned by sys_personality has type "long int".
It is saved to a variable of type "int", which is not a problem
yet because the type of task_struct->pesonality is "unsigned int".
The problem is the sign extension from "int" to "long int"
that happens on return from sys_sparc64_personality.

For example, a userspace call personality((unsigned) -EINVAL) will
result to any subsequent personality call, including absolutely
harmless read-only personality(0xffffffff) call, failing with
errno set to EINVAL.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
This commit is contained in:
Dmitry V. Levin 2015-12-27 02:13:27 +03:00 committed by Willy Tarreau
parent 67022807f8
commit 7cbfc44269
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/sparc/kernel/sys_sparc_64.c
View File

@ -524,7 +524,7 @@ SYSCALL_DEFINE1(sparc64_newuname, struct new_utsname __user *, name)
SYSCALL_DEFINE1(sparc64_personality, unsigned long, personality) SYSCALL_DEFINE1(sparc64_personality, unsigned long, personality)
{ {
int ret; long ret;
if (current->personality == PER_LINUX32 && if (current->personality == PER_LINUX32 &&
personality == PER_LINUX) personality == PER_LINUX)