Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-10 07:00:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

NFS: Fix a use-before-initialised warning in fs/nfs/write.c and fs/nfs/pnfs.c

Browse Source 
If the allocation of nfs_write_header fails, the list of nfs_pages that
needs to be cleaned up is still on desc->pg_list...

Reported-by: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Acked-by: Fred Isaman <iisaman@netapp.com>
This commit is contained in:
Trond Myklebust 2012-04-27 14:31:47 -04:00
parent 80a16b21a8
commit 9b5415b536
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/nfs/pnfs.c
View File

@ -1308,7 +1308,7 @@ pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
whdr = nfs_writehdr_alloc(); whdr = nfs_writehdr_alloc();
if (!whdr) { if (!whdr) {
desc->pg_completion_ops->error_cleanup(&hdr->pages); desc->pg_completion_ops->error_cleanup(&desc->pg_list);
put_lseg(desc->pg_lseg); put_lseg(desc->pg_lseg);
desc->pg_lseg = NULL; desc->pg_lseg = NULL;
return -ENOMEM; return -ENOMEM;

2
fs/nfs/write.c
View File

@ -1164,7 +1164,7 @@ static int nfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
whdr = nfs_writehdr_alloc(); whdr = nfs_writehdr_alloc();
if (!whdr) { if (!whdr) {
desc->pg_completion_ops->error_cleanup(&hdr->pages); desc->pg_completion_ops->error_cleanup(&desc->pg_list);
return -ENOMEM; return -ENOMEM;
} }
hdr = &whdr->header; hdr = &whdr->header;