Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-17 18:56:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_buttonpad

Browse Source 
The function performs a check on the hdev input parameters, however, it
is used before the check.

Initialize the udev variable after the sanity check to avoid a
possible NULL pointer dereference.

Fixes: 9614219e9310e ("HID: uclogic: Extract tablet parameter discovery into a module")
Addresses-Coverity-ID: 1443763 ("Null pointer dereference")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
José Expósito 2022-01-05 18:29:15 +01:00 committed by Jiri Kosina
parent ff6b548afe
commit aa320fdbbb
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hid/hid-uclogic-params.c
View File

@ -452,7 +452,7 @@ static int uclogic_params_frame_init_v1_buttonpad(
{ {
int rc; int rc;
bool found = false; bool found = false;
struct usb_device *usb_dev = hid_to_usb_dev(hdev); struct usb_device *usb_dev;
char *str_buf = NULL; char *str_buf = NULL;
const size_t str_len = 16; const size_t str_len = 16;
@ -462,6 +462,8 @@ static int uclogic_params_frame_init_v1_buttonpad(
goto cleanup; goto cleanup;
} }
usb_dev = hid_to_usb_dev(hdev);
/* /*
* Enable generic button mode * Enable generic button mode
*/ */