Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-10 07:00:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

igb: Fix potential memory leak in igb_add_ethtool_nfc_entry

Browse Source 
[ Upstream commit 8c0b48e01daba5ca58f939a8425855d3f4f2ed14 ]

Add check for return of igb_update_ethtool_nfc_entry so that in case
of any potential errors the memory alocated for input will be freed.

Fixes: 0e71def25281 ("igb: add support of RX network flow classification")
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
Tested-by: Arpana Arland <arpanax.arland@intel.com> (A Contingent worker at Intel)
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Mateusz Palczewski 2023-10-19 13:40:35 -07:00 committed by Greg Kroah-Hartman
parent 9a194064fa
commit c166dd51b6
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/intel/igb/igb_ethtool.c
View File

@ -2978,11 +2978,15 @@ static int igb_add_ethtool_nfc_entry(struct igb_adapter *adapter,
if (err) if (err)
goto err_out_w_lock; goto err_out_w_lock;
igb_update_ethtool_nfc_entry(adapter, input, input->sw_idx); err = igb_update_ethtool_nfc_entry(adapter, input, input->sw_idx);
if (err)
goto err_out_input_filter;
spin_unlock(&adapter->nfc_lock); spin_unlock(&adapter->nfc_lock);
return 0; return 0;
err_out_input_filter:
igb_erase_filter(adapter, input);
err_out_w_lock: err_out_w_lock:
spin_unlock(&adapter->nfc_lock); spin_unlock(&adapter->nfc_lock);
err_out: err_out: