Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-16 02:14:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

time/tick-broadcast: Remove RCU_NONIDLE() usage

Browse Source 
No callers left that have already disabled RCU.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Tony Lindgren <tony@atomide.com>
Tested-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20230112195540.927904612@infradead.org
This commit is contained in:
Peter Zijlstra 2023-01-12 20:43:40 +01:00 committed by Ingo Molnar
parent 880970b56b
commit e3ee5e66f7
1 changed files with 13 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
kernel/time/tick-broadcast-hrtimer.c
View File

@ -56,25 +56,20 @@ static int bc_set_next(ktime_t expires, struct clock_event_device *bc)
* hrtimer callback function is currently running, then * hrtimer callback function is currently running, then
* hrtimer_start() cannot move it and the timer stays on the CPU on * hrtimer_start() cannot move it and the timer stays on the CPU on
* which it is assigned at the moment. * which it is assigned at the moment.
*
* As this can be called from idle code, the hrtimer_start()
* invocation has to be wrapped with RCU_NONIDLE() as
* hrtimer_start() can call into tracing.
*/ */
RCU_NONIDLE( { hrtimer_start(&bctimer, expires, HRTIMER_MODE_ABS_PINNED_HARD);
hrtimer_start(&bctimer, expires, HRTIMER_MODE_ABS_PINNED_HARD); /*
/* * The core tick broadcast mode expects bc->bound_on to be set
* The core tick broadcast mode expects bc->bound_on to be set * correctly to prevent a CPU which has the broadcast hrtimer
* correctly to prevent a CPU which has the broadcast hrtimer * armed from going deep idle.
* armed from going deep idle. *
* * As tick_broadcast_lock is held, nothing can change the cpu
* As tick_broadcast_lock is held, nothing can change the cpu * base which was just established in hrtimer_start() above. So
* base which was just established in hrtimer_start() above. So * the below access is safe even without holding the hrtimer
* the below access is safe even without holding the hrtimer * base lock.
* base lock. */
*/ bc->bound_on = bctimer.base->cpu_base->cpu;
bc->bound_on = bctimer.base->cpu_base->cpu;
} );
return 0; return 0;
} }