linux-stable/ipc
Dan Rosenberg 5572adc7b7 sys_semctl: fix kernel stack leakage
commit 982f7c2b2e upstream.

The semctl syscall has several code paths that lead to the leakage of
uninitialized kernel stack memory (namely the IPC_INFO, SEM_INFO,
IPC_STAT, and SEM_STAT commands) during the use of the older, obsolete
version of the semid_ds struct.

The copy_semid_to_user() function declares a semid_ds struct on the stack
and copies it back to the user without initializing or zeroing the
"sem_base", "sem_pending", "sem_pending_last", and "undo" pointers,
allowing the leakage of 16 bytes of kernel stack memory.

The code is still reachable on 32-bit systems - when calling semctl()
newer glibc's automatically OR the IPC command with the IPC_64 flag, but
invoking the syscall directly allows users to use the older versions of
the struct.

Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Cc: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-21 12:43:49 -07:00
..
compat_mq.c ipc: initialize structure memory to zero for compat functions 2011-03-21 12:43:48 -07:00
compat.c ipc: initialize structure memory to zero for compat functions 2011-03-21 12:43:48 -07:00
ipc_sysctl.c sysctl ipc: Remove dead binary sysctl support code. 2009-11-12 02:04:54 -08:00
ipcns_notifier.c ipc: do not use a negative value to re-enable msgmni automatic recomputing 2008-07-25 10:53:42 -07:00
Makefile namespaces: mqueue namespace: adapt sysctl 2009-04-07 08:31:09 -07:00
mq_sysctl.c sysctl ipc: Remove dead binary sysctl support code. 2009-11-12 02:04:54 -08:00
mqueue.c mqueue: fix mq_open() file descriptor leak on user-space processes 2010-04-01 16:01:21 -07:00
msg.c ipc ns: fix memory leak (idr) 2009-12-16 07:20:09 -08:00
msgutil.c namespaces: ipc namespaces: implement support for posix msqueues 2009-04-07 08:31:09 -07:00
namespace.c ipcns: make free_ipc_ns() static 2009-06-18 13:03:56 -07:00
sem.c sys_semctl: fix kernel stack leakage 2011-03-21 12:43:49 -07:00
shm.c ipc: shm: fix information leak to userland 2011-03-21 12:43:49 -07:00
util.c seq_file: constify seq_operations 2009-09-23 07:39:29 -07:00
util.h ipc: unbreak 32-bit shmctl/semctl/msgctl 2009-06-21 12:48:43 -07:00