Alan Stern 5d43e07228 fs: sysfs: Fix reference leak in sysfs_break_active_protection() ... commit a90bca2228 upstream. The sysfs_break_active_protection() routine has an obvious reference leak in its error path. If the call to kernfs_find_and_get() fails then kn will be NULL, so the companion sysfs_unbreak_active_protection() routine won't get called (and would only cause an access violation by trying to dereference kn->parent if it was called). As a result, the reference to kobj acquired at the start of the function will never be released. Fix the leak by adding an explicit kobject_put() call when kn is NULL. Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Fixes: 2afc9166f7 ("scsi: sysfs: Introduce sysfs_{un,}break_active_protection()") Cc: Bart Van Assche <bvanassche@acm.org> Cc: stable@vger.kernel.org Reviewed-by: Bart Van Assche <bvanassche@acm.org> Acked-by: Tejun Heo <tj@kernel.org> Link: https://lore.kernel.org/r/8a4d3f0f-c5e3-4b70-a188-0ca433f9e6f9@rowland.harvard.edu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-04-27 17:07:16 +02:00
..
dir.c	fs/sysfs/dir.c: replace S_IRWXU|S_IRUGO|S_IXUGO with 0755 sysfs_create_dir_ns()	2021-10-05 16:35:05 +02:00
file.c	fs: sysfs: Fix reference leak in sysfs_break_active_protection()	2024-04-27 17:07:16 +02:00
group.c	sysfs: split out binary attribute handling from sysfs_add_file_mode_ns	2021-09-14 16:59:46 +02:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
mount.c	kernfs: move struct kernfs_root out of the public view.	2022-02-23 15:46:34 +01:00
symlink.c	docs: filesystems: fix renamed references	2020-04-20 15:45:22 -06:00
sysfs.h	sysfs: split out binary attribute handling from sysfs_add_file_mode_ns	2021-09-14 16:59:46 +02:00