Neil Horman c5c7774d7e sctp: fully initialize sctp_outq in sctp_outq_init ...

In commit 2f94aabd9f6c925d77aecb3ff020f1cc12ed8f86
(refactor sctp_outq_teardown to insure proper re-initalization)
we modified sctp_outq_teardown to use sctp_outq_init to fully re-initalize the
outq structure.  Steve West recently asked me why I removed the q->error = 0
initalization from sctp_outq_teardown.  I did so because I was operating under
the impression that sctp_outq_init would properly initalize that value for us,
but it doesn't.  sctp_outq_init operates under the assumption that the outq
struct is all 0's (as it is when called from sctp_association_init), but using
it in __sctp_outq_teardown violates that assumption. We should do a memset in
sctp_outq_init to ensure that the entire structure is in a known state there
instead.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: "West, Steve (NSN - US/Fort Worth)" <steve.west@nsn.com>
CC: Vlad Yasevich <vyasevich@gmail.com>
CC: netdev@vger.kernel.org
CC: davem@davemloft.net
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2013-06-13 18:05:24 -07:00

..

associola.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

2013-05-01 14:08:52 -07:00

auth.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2013-02-08 18:02:14 -05:00

bind_addr.c

net: sctp: sctp_bind_addr: remove dead code

2013-04-17 14:13:02 -04:00

chunk.c

sctp: fix -ENOMEM result with invalid user space pointer in sendto() syscall

2012-11-28 11:11:17 -05:00

command.c

[SCTP]: Remove sctp_add_cmd_sf wrapper bloat

2008-03-27 17:54:29 -07:00

debug.c

sctp: remove completely unsed EMPTY state

2011-04-20 01:51:03 -07:00

endpointola.c

net: sctp: minor: make sctp_ep_common's member 'dead' a bool

2013-04-15 14:11:37 -04:00

input.c

hlist: drop the node parameter from iterators

2013-02-27 19:10:24 -08:00

inqueue.c

net: sctp: sctp_inq: remove dead code

2013-04-17 14:13:02 -04:00

ipv6.c

net: sctp: sctp_v6_get_dst: fix boolean test in dst cache

2013-02-13 13:42:34 -05:00

Kconfig

net, sctp: remove CONFIG_EXPERIMENTAL

2013-02-13 13:57:27 -05:00

Makefile

sctp: implement sctp association probing module

2010-04-30 22:41:09 -04:00

objcnt.c

sctp: Make the proc files per network namespace.

2012-08-14 23:29:53 -07:00

output.c

net: sctp: minor: remove dead code from sctp_packet

2013-04-22 16:25:21 -04:00

outqueue.c

sctp: fully initialize sctp_outq in sctp_outq_init

2013-06-13 18:05:24 -07:00

primitive.c

sctp: Push struct net down to sctp_chunk_event_lookup

2012-08-14 23:30:37 -07:00

probe.c

net: sctp: attribute printl with __printf for gcc fmt checks

2013-05-01 15:04:10 -04:00

proc.c

sctp: Add buffer utilization fields to /proc/net/sctp/assocs

2013-04-16 16:43:34 -04:00

protocol.c

net: sctp: remove cast for kmalloc/kzalloc return value

2013-03-18 14:16:00 +01:00

sm_make_chunk.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

2013-02-21 17:40:58 -08:00

sm_sideeffect.c

net: remove redundant check for timer pending state before del_timer

2013-02-04 13:26:49 -05:00

sm_statefuns.c

sctp: Use correct sideffect command in duplicate cookie handling

2013-03-13 09:59:21 -04:00

sm_statetable.c

sctp: Make sysctl tunables per net

2012-08-14 23:32:16 -07:00

socket.c

net: sctp: fix NULL pointer dereference in socket destruction

2013-06-11 02:49:05 -07:00

ssnmap.c

net: sctp: sctp_ssnmap: remove 'malloced' element from struct

2013-04-17 14:13:02 -04:00

sysctl.c

SCTP: Free the per-net sysctl table on net exit. v2

2013-01-28 00:09:32 -05:00

transport.c

net: sctp: sctp_transport: remove unused variable

2013-04-17 14:13:02 -04:00

tsnmap.c

sctp: fix association hangs due to off-by-one errors in sctp_tsnmap_grow()

2013-02-28 15:34:26 -05:00

ulpevent.c

netvm: prevent a stream-specific deadlock

2012-07-31 18:42:47 -07:00

ulpqueue.c

net: sctp: sctp_ulpq: remove 'malloced' struct member

2013-04-17 14:13:02 -04:00