mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-08 14:13:53 +00:00
49094d9286
Remove the temporary @mask_, this may cause build warning when use clang
compiler for powerpc, but can't reproduce it when compile for arm64.
the build warning is caused by:
"warning: result of comparison of constant 18446744073709551615 with
expression of type (aka 'unsigned long') is always false
[-Wtautological-constant-out-of-range-compare]"
More information provided in below lore link.
After removing @mask_, there is a "CHECK:MACRO_ARG_REUSE" when run
checkpatch.pl, but due to @mask is constant, no reuse problem will happen.
Link: https://lore.kernel.org/lkml/202212160357.jJuesD8n-lkp@intel.com/t/
Fixes: 84513eccd6 ("phy: mediatek: fix build warning of FIELD_PREP()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230118084343.26913-1-chunfeng.yun@mediatek.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
47 lines
897 B
C
47 lines
897 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (C) 2021 MediaTek Inc.
|
|
*
|
|
* Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
|
|
*/
|
|
|
|
#ifndef __PHY_MTK_H__
|
|
#define __PHY_MTK_H__
|
|
|
|
#include <linux/bitfield.h>
|
|
#include <linux/io.h>
|
|
|
|
static inline void mtk_phy_clear_bits(void __iomem *reg, u32 bits)
|
|
{
|
|
u32 tmp = readl(reg);
|
|
|
|
tmp &= ~bits;
|
|
writel(tmp, reg);
|
|
}
|
|
|
|
static inline void mtk_phy_set_bits(void __iomem *reg, u32 bits)
|
|
{
|
|
u32 tmp = readl(reg);
|
|
|
|
tmp |= bits;
|
|
writel(tmp, reg);
|
|
}
|
|
|
|
static inline void mtk_phy_update_bits(void __iomem *reg, u32 mask, u32 val)
|
|
{
|
|
u32 tmp = readl(reg);
|
|
|
|
tmp &= ~mask;
|
|
tmp |= val & mask;
|
|
writel(tmp, reg);
|
|
}
|
|
|
|
/* field @mask shall be constant and continuous */
|
|
#define mtk_phy_update_field(reg, mask, val) \
|
|
({ \
|
|
BUILD_BUG_ON_MSG(!__builtin_constant_p(mask), "mask is not constant"); \
|
|
mtk_phy_update_bits(reg, mask, FIELD_PREP(mask, val)); \
|
|
})
|
|
|
|
#endif
|