Oleg Nesterov
3245d6acab
exit: fix race between wait_consider_task() and wait_task_zombie() ...
wait_consider_task() checks EXIT_ZOMBIE after EXIT_DEAD/EXIT_TRACE and
both checks can fail if we race with EXIT_ZOMBIE -> EXIT_DEAD/EXIT_TRACE
change in between, gcc needs to reload p->exit_state after
security_task_wait(). In this case ->notask_error will be wrongly
cleared and do_wait() can hang forever if it was the last eligible
child.
Many thanks to Arne who carefully investigated the problem.
Note: this bug is very old but it was pure theoretical until commit
b3ab03160dfa ("wait: completely ignore the EXIT_DEAD tasks"). Before
this commit "-O2" was probably enough to guarantee that compiler won't
read ->exit_state twice.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Arne Goedeke <el@laramies.com>
Tested-by: Arne Goedeke <el@laramies.com>
Cc: <stable@vger.kernel.org> [3.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-01-08 15:10:51 -08:00
2014-12-05 21:47:32 -08:00
2014-08-08 16:30:24 -07:00
2014-10-14 02:18:25 +02:00
2014-12-19 13:15:24 -08:00
2014-12-13 12:42:51 -08:00
2014-12-13 13:33:07 +01:00
2014-10-28 10:55:08 +01:00
2014-12-19 22:55:06 +01:00
2014-12-13 14:04:41 -08:00
2014-11-13 10:39:04 -08:00
2014-12-10 17:41:09 -08:00
2014-12-19 13:29:20 -08:00
2014-12-18 20:28:33 -08:00
2013-12-10 18:21:34 +00:00
2014-10-09 22:26:04 -04:00
2014-10-09 22:26:04 -04:00
2014-12-13 12:42:53 -08:00
2014-09-23 16:37:53 -04:00
2014-12-30 10:45:47 -08:00
2014-09-23 16:37:51 -04:00
2014-12-23 18:13:16 -08:00
2014-12-31 14:52:18 -08:00
2014-06-04 16:54:14 -07:00
2014-08-08 15:57:18 -07:00
2014-07-24 21:53:47 +10:00
2014-07-15 11:05:09 -04:00
2014-11-18 02:49:52 -05:00
2014-09-06 12:58:18 +02:00
2014-10-28 10:46:05 +01:00
2014-11-03 19:21:01 -08:00
2014-12-11 18:57:19 -08:00
2014-08-25 15:42:19 -07:00
2014-07-23 10:18:06 -07:00
2013-11-09 00:16:23 -05:00
2014-06-04 16:54:15 -07:00
2015-01-08 15:10:51 -08:00
2014-11-19 15:25:26 -05:00
2014-12-13 12:42:45 -08:00
2014-10-21 23:44:20 +02:00
2014-02-02 14:09:12 -08:00
2014-10-26 16:16:18 +01:00
2014-12-09 16:58:40 -06:00
2014-06-04 16:54:15 -07:00
2014-10-29 11:18:18 -04:00
2013-10-19 19:45:35 -04:00
2014-10-14 02:18:16 +02:00
2014-09-10 15:42:12 -07:00
2013-11-15 09:32:22 +09:00
2014-07-16 14:57:13 +02:00
2014-12-13 12:42:51 -08:00
2014-12-10 17:41:17 -08:00
2014-12-11 17:30:55 -08:00
2014-04-25 12:00:49 -07:00
2014-10-09 22:25:51 -04:00
2014-06-04 16:54:15 -07:00
2014-12-10 17:41:04 -08:00
2013-10-25 17:15:18 -04:00
2013-09-25 17:17:01 +01:00
2014-12-18 20:55:41 -08:00
2014-04-24 10:26:39 +02:00
2014-12-04 14:34:54 -05:00
2013-12-05 21:28:42 +08:00
2014-12-10 17:41:10 -08:00
2014-12-18 12:38:51 +10:30
2014-12-16 15:53:03 -08:00
2014-12-16 15:53:03 -08:00
2014-06-06 16:08:13 -07:00
2014-12-10 17:41:10 -08:00
2014-09-26 00:00:06 -07:00
2014-04-12 14:49:50 -07:00
2014-10-14 02:18:22 +02:00
2014-10-14 02:27:06 +02:00
2014-12-10 09:34:43 -08:00
2014-10-15 07:48:18 +02:00
2014-10-28 10:56:24 +01:00
2014-11-03 19:20:34 -08:00
2014-12-13 12:42:48 -08:00
2014-06-04 16:54:15 -07:00
2014-12-13 12:42:51 -08:00
2014-11-18 00:58:53 +01:00
2014-12-10 17:41:10 -08:00
2014-12-16 12:53:59 -08:00
2013-12-10 18:25:28 +00:00
2014-07-17 09:35:17 -04:00
2014-11-19 13:01:25 -05:00
2014-08-08 15:57:18 -07:00
2014-09-16 13:41:06 -07:00
2014-06-21 00:15:26 -04:00
2014-07-23 10:18:05 -07:00
2014-12-05 17:19:27 -06:00
2014-02-24 14:47:15 -08:00
2014-12-17 12:31:40 -08:00
2014-08-26 13:45:45 -04:00
2014-12-17 12:31:40 -08:00
2014-06-06 16:08:16 -07:00
2014-12-04 14:34:47 -05:00
2014-10-15 07:48:18 +02:00
2014-05-20 10:59:32 -04:00
2014-12-08 12:39:16 -05:00
3245d6acab