linux-stable/arch
Robert Richter d57c4ca8b0 oprofile, x86: Fix nmi-unsafe callgraph support
commit a0e3e70243 upstream.

Backport for stable kernel v2.6.32.y to v2.6.36.y.

Current oprofile's x86 callgraph support may trigger page faults
throwing the BUG_ON(in_nmi()) message below. This patch fixes this by
using the same nmi-safe copy-from-user code as in perf.

------------[ cut here ]------------
kernel BUG at .../arch/x86/kernel/traps.c:436!
invalid opcode: 0000 [#1] SMP
last sysfs file: /sys/devices/pci0000:00/0000:00:0a.0/0000:07:00.0/0000:08:04.0/net/eth0/broadcast
CPU 5
Modules linked in:

Pid: 8611, comm: opcontrol Not tainted 2.6.39-00007-gfe47ae7 #1 Advanced Micro Device Anaheim/Anaheim
RIP: 0010:[<ffffffff813e8e35>]  [<ffffffff813e8e35>] do_nmi+0x22/0x1ee
RSP: 0000:ffff88042fd47f28  EFLAGS: 00010002
RAX: ffff88042c0a7fd8 RBX: 0000000000000001 RCX: 00000000c0000101
RDX: 00000000ffff8804 RSI: ffffffffffffffff RDI: ffff88042fd47f58
RBP: ffff88042fd47f48 R08: 0000000000000004 R09: 0000000000001484
R10: 0000000000000001 R11: 0000000000000000 R12: ffff88042fd47f58
R13: 0000000000000000 R14: ffff88042fd47d98 R15: 0000000000000020
FS:  00007fca25e56700(0000) GS:ffff88042fd40000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000074 CR3: 000000042d28b000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process opcontrol (pid: 8611, threadinfo ffff88042c0a6000, task ffff88042c532310)
Stack:
 0000000000000000 0000000000000001 ffff88042c0a7fd8 0000000000000000
 ffff88042fd47de8 ffffffff813e897a 0000000000000020 ffff88042fd47d98
 0000000000000000 ffff88042c0a7fd8 ffff88042fd47de8 0000000000000074
Call Trace:
 <NMI>
 [<ffffffff813e897a>] nmi+0x1a/0x20
 [<ffffffff813f08ab>] ? bad_to_user+0x25/0x771
 <<EOE>>
Code: ff 59 5b 41 5c 41 5d c9 c3 55 65 48 8b 04 25 88 b5 00 00 48 89 e5 41 55 41 54 49 89 fc 53 48 83 ec 08 f6 80 47 e0 ff ff 04 74 04 <0f> 0b eb fe 81 80 44 e0 ff ff 00 00 01 04 65 ff 04 25 c4 0f 01
RIP  [<ffffffff813e8e35>] do_nmi+0x22/0x1ee
 RSP <ffff88042fd47f28>
---[ end trace ed6752185092104b ]---
Kernel panic - not syncing: Fatal exception in interrupt
Pid: 8611, comm: opcontrol Tainted: G      D     2.6.39-00007-gfe47ae7 #1
Call Trace:
 <NMI>  [<ffffffff813e5e0a>] panic+0x8c/0x188
 [<ffffffff813e915c>] oops_end+0x81/0x8e
 [<ffffffff8100403d>] die+0x55/0x5e
 [<ffffffff813e8c45>] do_trap+0x11c/0x12b
 [<ffffffff810023c8>] do_invalid_op+0x91/0x9a
 [<ffffffff813e8e35>] ? do_nmi+0x22/0x1ee
 [<ffffffff8131e6fa>] ? oprofile_add_sample+0x83/0x95
 [<ffffffff81321670>] ? op_amd_check_ctrs+0x4f/0x2cf
 [<ffffffff813ee4d5>] invalid_op+0x15/0x20
 [<ffffffff813e8e35>] ? do_nmi+0x22/0x1ee
 [<ffffffff813e8e7a>] ? do_nmi+0x67/0x1ee
 [<ffffffff813e897a>] nmi+0x1a/0x20
 [<ffffffff813f08ab>] ? bad_to_user+0x25/0x771
 <<EOE>>

Cc: John Lumby <johnlumby@hotmail.com>
Cc: Maynard Johnson <maynardj@us.ibm.com>
Signed-off-by: Robert Richter <robert.richter@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
2012-02-11 15:38:13 +01:00
..
alpha alpha: fix several security issues 2012-02-11 15:37:38 +01:00
arm ARM: 6891/1: prevent heap corruption in OABI semtimedop 2012-02-11 15:37:17 +01:00
avr32 avr32: nmi_enter() without nmi_exit() 2008-09-19 20:08:08 +02:00
blackfin Blackfin arch: Fix PM building on BF52x: No ROTWE on BF52x, add USBWE 2008-08-28 17:32:01 +08:00
cris Rename old_readdir to sys_old_readdir 2009-01-18 10:35:31 -08:00
frv FRV: Wire up new system calls 2008-08-01 13:03:49 -07:00
h8300 Rename old_readdir to sys_old_readdir 2009-01-18 10:35:31 -08:00
ia64 tioca: Fix assignment from incompatible pointer warnings 2011-04-30 16:53:37 +02:00
m32r m32r/kernel/: cleanups 2008-09-27 18:27:21 +09:00
m68k tty: Mark generic_serial users as BROKEN 2009-11-09 16:52:18 -08:00
m68knommu m68knommu: set NO_DMA 2009-02-06 14:00:35 -08:00
mips MIPS: CVE-2009-0029: Enable syscall wrappers 2009-05-08 14:54:35 -07:00
mn10300 Rename old_readdir to sys_old_readdir 2009-01-18 10:35:31 -08:00
parisc set memory ranges in N_NORMAL_MEMORY when onlined 2012-02-11 15:37:10 +01:00
powerpc powerpc: pseries: Fix kexec on machines with more than 4TB of RAM 2012-02-11 15:37:41 +01:00
s390 KVM: s390: check cpu_id prior to using it 2012-02-11 15:37:46 +01:00
sh Remove __attribute__((weak)) from sys_pipe/sys_pipe2 2009-01-18 10:35:33 -08:00
sparc compat: Make compat_alloc_user_space() incorporate the access_ok() 2010-09-20 13:03:21 -07:00
sparc64 sparc64: Reschedule KGDB capture to a software interrupt. 2009-06-11 20:01:15 -07:00
um um: fix ubd cow size 2012-02-11 15:37:48 +01:00
x86 oprofile, x86: Fix nmi-unsafe callgraph support 2012-02-11 15:38:13 +01:00
xtensa remove unneeded #include <linux/ide.h>'s 2008-08-05 18:17:00 +02:00
.gitignore arch: Ignore arch/i386 and arch/x86_64 2008-01-19 21:29:39 -08:00
Kconfig System call wrapper infrastructure 2009-01-18 10:35:33 -08:00