Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-18 19:27:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
linux-stable/drivers/iio
History
Alexandru Ardelean 519808425e iio: imu: adis16460: fix variable signedness 
Caught via static-analysis checker:
```
drivers/iio/imu/adis16460.c
   152  static int adis16460_set_freq(struct iio_dev *indio_dev, int val, int val2)
   153  {
   154          struct adis16460 *st = iio_priv(indio_dev);
   155          unsigned int t;
                ^^^^^^^^^^^^^^

   156
   157          t =  val * 1000 + val2 / 1000;
   158          if (t <= 0)
                    ^^^^^^
Unsigned is not less than zero.
```

The types of `val` && `val2` are obtained from the IIO `write_raw` hook, so
userspace can provide negative values, which can cause weird behavior after
conversion to unsigned.

This patch changes the sign of variable `t` so that -EINVAL will be
returned for negative values as well.

Fixes: db6ed4d23dd1 ("iio: imu: Add support for the ADIS16460 IMU")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
2019-08-18 18:53:15 +01:00
..
accel
iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids
2019-08-18 18:50:56 +01:00
adc
First set of new device support, features and cleanups for IIO in the 5.4 cycle
2019-08-12 22:52:44 +02:00
afe
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
amplifiers
Second set of IIO device support, features, cleanups and minor fixes for 5.3.
2019-07-01 10:58:13 +02:00
buffer
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
chemical
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
common
iio: remove get_irq_data_ready() function pointer and use IRQ number directly
2019-08-05 16:50:08 +01:00
dac
Merge 5.2-rc6 into staging-next
2019-06-23 13:29:03 +02:00
dummy
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
frequency
Second set of IIO device support, features, cleanups and minor fixes for 5.3.
2019-07-01 10:58:13 +02:00
gyro
iio:st_sensors: remove buffer allocation at each buffer enable
2019-08-11 09:26:04 +01:00
health
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
humidity
iio: humidity: Use device-managed APIs
2019-07-27 22:52:06 +01:00
imu
iio: imu: adis16460: fix variable signedness
2019-08-18 18:53:15 +01:00
light
iio:light:noa1305: Fix missing break statement.
2019-08-14 09:37:36 +02:00
magnetometer
iio:st_sensors: remove buffer allocation at each buffer enable
2019-08-11 09:26:04 +01:00
multiplexer
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
orientation
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 309
2019-06-05 17:37:04 +02:00
potentiometer
iio: potentiometer: add a driver for Maxim 5432-5435
2019-08-05 14:25:08 +01:00
potentiostat
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
pressure
iio:st_sensors: remove buffer allocation at each buffer enable
2019-08-11 09:26:04 +01:00
proximity
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
resolver
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
temperature
iio: maxim_thermocouple: Use device-managed APIs
2019-07-27 22:52:06 +01:00
trigger
IIO: stm32: Remove quadrature related functions from trigger driver
2019-07-27 20:11:18 +01:00
iio_core_trigger.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
iio_core.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
industrialio-buffer.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
industrialio-configfs.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
industrialio-core.c
Staging / IIO driver update for 5.3-rc1
2019-07-11 15:36:02 -07:00
industrialio-event.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
industrialio-sw-device.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
industrialio-sw-trigger.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
industrialio-trigger.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
industrialio-triggered-event.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
inkern.c
Driver Core and debugfs changes for 5.3-rc1
2019-07-12 12:24:03 -07:00
Kconfig
Second set of IIO device support, features, cleanups and minor fixes for 5.3.
2019-07-01 10:58:13 +02:00
Makefile
counter: stm32-lptimer: add counter device
2019-04-25 21:33:41 +02:00