Wladislav Wiebe 14c3de73b1 of: fdt: fix memory initialization for expanded DT ...

commit 9e40127526e857fa3f29d51e83277204fbdfc6ba upstream.

Already existing property flags are filled wrong for properties created from
initial FDT. This could cause problems if this DYNAMIC device-tree functions
are used later, i.e. properties are attached/detached/replaced. Simply dumping
flags from the running system show, that some initial static (not allocated via
kzmalloc()) nodes are marked as dynamic.

I putted some debug extensions to property_proc_show(..) :
..
+       if (OF_IS_DYNAMIC(pp))
+               pr_err("DEBUG: xxx : OF_IS_DYNAMIC\n");
+       if (OF_IS_DETACHED(pp))
+               pr_err("DEBUG: xxx : OF_IS_DETACHED\n");

when you operate on the nodes (e.g.: ~$ cat /proc/device-tree/*some_node*) you
will see that those flags are filled wrong, basically in most cases it will dump
a DYNAMIC or DETACHED status, which is in not true.
(BTW. this OF_IS_DETACHED is a own define for debug purposes which which just
make a test_bit(OF_DETACHED, &x->_flags)

If nodes are dynamic kernel is allowed to kfree() them. But it will crash
attempting to do so on the nodes from FDT -- they are not allocated via
kzmalloc().

Signed-off-by: Wladislav Wiebe <wladislav.kw@gmail.com>
Acked-by: Alexander Sverdlin <alexander.sverdlin@nsn.com>
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2013-08-29 09:42:12 -07:00

..

address.c

of/address: use proper endianess in get_flags

2010-12-23 15:57:48 -07:00

base.c

dt: protect against NULL matches passed to of_match_node()

2011-03-23 14:55:55 -06:00

device.c

dt/powerpc: move of_bus_type infrastructure to ibmebus

2011-02-28 01:36:38 -07:00

fdt.c

of: fdt: fix memory initialization for expanded DT

2013-08-29 09:42:12 -07:00

gpio.c

of/gpio: fix of_gpio includes

2010-07-05 16:14:44 -06:00

irq.c

of: Export of_irq_find_parent()

2011-04-20 17:01:19 +10:00

Kconfig

x86: dtb: Add support for PCI devices backed by dtb nodes

2011-02-23 22:27:53 +01:00

Makefile

of/pci: move of_irq_map_pci() into generic code

2011-02-04 11:46:50 -07:00

of_i2c.c

of/i2c: Fix request module by alias

2010-12-24 01:28:54 -07:00

of_mdio.c

Fix common misspellings

2011-03-31 11:26:23 -03:00

of_net.c

of/net: Move of_get_mac_address() to a common source file.

2010-11-01 01:08:14 -04:00

of_pci.c

x86: dtb: Add support for PCI devices backed by dtb nodes

2011-02-23 22:27:53 +01:00

of_spi.c

of/spi: call of_register_spi_devices() from spi core code

2010-07-30 00:03:59 -06:00

pdt.c

of/promtree: allow DT device matching by fixing 'name' brokenness (v5)

2011-03-02 13:45:19 -07:00

platform.c

dt: eliminate OF_NO_DEEP_PROBE and test for NULL match table

2011-03-23 14:55:56 -06:00