Petr Vaganov 6889cd2a93 xfrm: fix one more kernel-infoleak in algo dumping ... During fuzz testing, the following issue was discovered: BUG: KMSAN: kernel-infoleak in _copy_to_iter+0x598/0x2a30 _copy_to_iter+0x598/0x2a30 __skb_datagram_iter+0x168/0x1060 skb_copy_datagram_iter+0x5b/0x220 netlink_recvmsg+0x362/0x1700 sock_recvmsg+0x2dc/0x390 __sys_recvfrom+0x381/0x6d0 __x64_sys_recvfrom+0x130/0x200 x64_sys_call+0x32c8/0x3cc0 do_syscall_64+0xd8/0x1c0 entry_SYSCALL_64_after_hwframe+0x79/0x81 Uninit was stored to memory at: copy_to_user_state_extra+0xcc1/0x1e00 dump_one_state+0x28c/0x5f0 xfrm_state_walk+0x548/0x11e0 xfrm_dump_sa+0x1e0/0x840 netlink_dump+0x943/0x1c40 __netlink_dump_start+0x746/0xdb0 xfrm_user_rcv_msg+0x429/0xc00 netlink_rcv_skb+0x613/0x780 xfrm_netlink_rcv+0x77/0xc0 netlink_unicast+0xe90/0x1280 netlink_sendmsg+0x126d/0x1490 __sock_sendmsg+0x332/0x3d0 ____sys_sendmsg+0x863/0xc30 ___sys_sendmsg+0x285/0x3e0 __x64_sys_sendmsg+0x2d6/0x560 x64_sys_call+0x1316/0x3cc0 do_syscall_64+0xd8/0x1c0 entry_SYSCALL_64_after_hwframe+0x79/0x81 Uninit was created at: __kmalloc+0x571/0xd30 attach_auth+0x106/0x3e0 xfrm_add_sa+0x2aa0/0x4230 xfrm_user_rcv_msg+0x832/0xc00 netlink_rcv_skb+0x613/0x780 xfrm_netlink_rcv+0x77/0xc0 netlink_unicast+0xe90/0x1280 netlink_sendmsg+0x126d/0x1490 __sock_sendmsg+0x332/0x3d0 ____sys_sendmsg+0x863/0xc30 ___sys_sendmsg+0x285/0x3e0 __x64_sys_sendmsg+0x2d6/0x560 x64_sys_call+0x1316/0x3cc0 do_syscall_64+0xd8/0x1c0 entry_SYSCALL_64_after_hwframe+0x79/0x81 Bytes 328-379 of 732 are uninitialized Memory access of size 732 starts at ffff88800e18e000 Data copied to user address 00007ff30f48aff0 CPU: 2 PID: 18167 Comm: syz-executor.0 Not tainted 6.8.11 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 Fixes copying of xfrm algorithms where some random data of the structure fields can end up in userspace. Padding in structures may be filled with random (possibly sensitve) data and should never be given directly to user-space. A similar issue was resolved in the commit 8222d5910d ("xfrm: Zero padding when dumping algos and encap") Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: c7a5899eb2 ("xfrm: redact SA secret with lockdown confidentiality") Cc: stable@vger.kernel.org Co-developed-by: Boris Tonofa <b.tonofa@ideco.ru> Signed-off-by: Boris Tonofa <b.tonofa@ideco.ru> Signed-off-by: Petr Vaganov <p.vaganov@ideco.ru> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>		2024-10-11 09:00:03 +02:00
..
espintcp.c	net: move netdev_max_backlog to net_hotdata	2024-03-07 21:12:42 -08:00
Kconfig	ipsec: Select CRYPTO_AEAD	2023-10-01 16:28:14 +08:00
Makefile	xfrm: support sending NAT keepalives in ESP in UDP states	2024-06-26 13:22:42 +02:00
xfrm_algo.c	net: fill in MODULE_DESCRIPTION()s for xfrm	2024-02-09 14:12:01 -08:00
xfrm_compat.c	xfrm: support sending NAT keepalives in ESP in UDP states	2024-06-26 13:22:42 +02:00
xfrm_device.c	xfrm: extract dst lookup parameters into a struct	2024-09-23 07:02:07 +02:00
xfrm_hash.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
xfrm_hash.h	xfrm: add state hashtable keyed by seq	2021-05-14 13:52:01 +02:00
xfrm_inout.h	xfrm: move xfrm4_extract_header to common helper	2020-05-06 09:40:08 +02:00
xfrm_input.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-07-15 13:19:17 -07:00
xfrm_interface_bpf.c	bpf: treewide: Annotate BPF kfuncs in BTF	2024-01-31 20:40:56 -08:00
xfrm_interface_core.c	netdev_features: convert NETIF_F_LLTX to dev->lltx	2024-09-03 11:36:43 +02:00
xfrm_ipcomp.c	net: introduce and use skb_frag_fill_page_desc()	2023-05-13 19:47:56 +01:00
xfrm_nat_keepalive.c	xfrm: support sending NAT keepalives in ESP in UDP states	2024-06-26 13:22:42 +02:00
xfrm_output.c	Revert "xfrm: add SA information to the offloaded packet"	2024-09-09 11:43:39 +02:00
xfrm_policy.c	xfrm: policy: remove last remnants of pernet inexact list	2024-09-24 09:58:16 +02:00
xfrm_proc.c	xfrm: Add dir validation to "in" data path lookup	2024-05-01 10:06:27 +02:00
xfrm_replay.c	xfrm: Add Direction to the SA in or out	2024-05-01 10:05:11 +02:00
xfrm_state_bpf.c	bpf: treewide: Annotate BPF kfuncs in BTF	2024-01-31 20:40:56 -08:00
xfrm_state.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-07-15 13:19:17 -07:00
xfrm_sysctl.c	net: Remove ctl_table sentinel elements from several networking subsystems	2024-05-03 13:29:42 +01:00
xfrm_user.c	xfrm: fix one more kernel-infoleak in algo dumping	2024-10-11 09:00:03 +02:00