Miaohe Lin c880cc4491 mm/hugetlb: fix possible recursive locking detected warning ... commit 667574e873 upstream. When tries to demote 1G hugetlb folios, a lockdep warning is observed: ============================================ WARNING: possible recursive locking detected 6.10.0-rc6-00452-ga4d0275fa660-dirty #79 Not tainted -------------------------------------------- bash/710 is trying to acquire lock: ffffffff8f0a7850 (&h->resize_lock){+.+.}-{3:3}, at: demote_store+0x244/0x460 but task is already holding lock: ffffffff8f0a6f48 (&h->resize_lock){+.+.}-{3:3}, at: demote_store+0xae/0x460 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&h->resize_lock); lock(&h->resize_lock); *** DEADLOCK *** May be due to missing lock nesting notation 4 locks held by bash/710: #0: ffff8f118439c3f0 (sb_writers#5){.+.+}-{0:0}, at: ksys_write+0x64/0xe0 #1: ffff8f11893b9e88 (&of->mutex#2){+.+.}-{3:3}, at: kernfs_fop_write_iter+0xf8/0x1d0 #2: ffff8f1183dc4428 (kn->active#98){.+.+}-{0:0}, at: kernfs_fop_write_iter+0x100/0x1d0 #3: ffffffff8f0a6f48 (&h->resize_lock){+.+.}-{3:3}, at: demote_store+0xae/0x460 stack backtrace: CPU: 3 PID: 710 Comm: bash Not tainted 6.10.0-rc6-00452-ga4d0275fa660-dirty #79 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 Call Trace: <TASK> dump_stack_lvl+0x68/0xa0 __lock_acquire+0x10f2/0x1ca0 lock_acquire+0xbe/0x2d0 __mutex_lock+0x6d/0x400 demote_store+0x244/0x460 kernfs_fop_write_iter+0x12c/0x1d0 vfs_write+0x380/0x540 ksys_write+0x64/0xe0 do_syscall_64+0xb9/0x1d0 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fa61db14887 RSP: 002b:00007ffc56c48358 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007fa61db14887 RDX: 0000000000000002 RSI: 000055a030050220 RDI: 0000000000000001 RBP: 000055a030050220 R08: 00007fa61dbd1460 R09: 000000007fffffff R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002 R13: 00007fa61dc1b780 R14: 00007fa61dc17600 R15: 00007fa61dc16a00 </TASK> Lockdep considers this an AA deadlock because the different resize_lock mutexes reside in the same lockdep class, but this is a false positive. Place them in distinct classes to avoid these warnings. Link: https://lkml.kernel.org/r/20240712031314.2570452-1-linmiaohe@huawei.com Fixes: 8531fc6f52 ("hugetlb: add hugetlb demote page support") Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Acked-by: Muchun Song <muchun.song@linux.dev> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-08-03 08:49:29 +02:00
..
acpi	ACPI: sleep: Avoid breaking S3 wakeup due to might_sleep()	2023-06-28 11:12:22 +02:00
asm-generic	vmlinux.lds.h: catch .bss..L* sections into BSS")	2024-08-03 08:49:02 +02:00
clocksource
crypto	crypto: af_alg - Disallow multiple in-flight AIO requests	2024-01-25 15:27:21 -08:00
drm	drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()	2024-08-03 08:49:10 +02:00
dt-bindings	clk: renesas: r8a779g0: Correct PFC/GPIO parent clocks	2024-03-26 18:20:48 -04:00
keys
kunit	kunit: add macro to allow conditionally exposing static symbols to tests	2023-11-20 11:52:08 +01:00
kvm	KVM: arm64: Fix host-programmed guest events in nVHE	2024-04-10 16:28:23 +02:00
linux	mm/hugetlb: fix possible recursive locking detected warning	2024-08-03 08:49:29 +02:00
math-emu
media	media: cec: core: avoid recursive cec_claim_log_addrs	2024-06-12 11:03:48 +02:00
memory	memory: renesas-rpc-if: Split-off private data from struct rpcif	2023-03-11 13:55:17 +01:00
misc
net	ipv4: Fix incorrect TOS in route get reply	2024-08-03 08:49:24 +02:00
pcmcia
ras
rdma	RDMA/core: Fix umem iterator when PAGE_SIZE is greater then HCA pgsz	2023-12-13 18:39:15 +01:00
rv
scsi	scsi: mpi3mr: Fix ATA NCQ priority support	2024-06-21 14:35:44 +02:00
soc	soc: qcom: rpmh-rsc: Enhance check for VRM in-flight request	2024-06-16 13:41:33 +02:00
sound	ALSA: dmaengine: Synchronize dma channel after drop()	2024-07-25 09:49:14 +02:00
target	scsi: target: Fix multiple LUN_RESET handling	2023-05-11 23:03:19 +09:00
trace	SUNRPC: Fixup gss_status tracepoint error output	2024-08-03 08:49:16 +02:00
uapi	netfilter: nf_tables: rise cap on SELinux secmark context	2024-08-03 08:49:07 +02:00
ufs	scsi: ufs: exynos: Fix DMA alignment for PAGE_SIZE != 4096	2023-03-10 09:33:15 +01:00
vdso
video
xen	xen: simplify evtchn_do_upcall() call maze	2023-12-08 08:51:20 +01:00