mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-01 10:45:49 +00:00
ae2170d6ea
When a trip point becomes invalid after being crossed on the way up,
it is involved in a mitigation episode that needs to be adjusted to
compensate for the trip going away.
For this reason, introduce thermal_zone_trip_down() as a wrapper
around thermal_trip_crossed() and make thermal_zone_set_trip_temp()
call it if the new temperature of the trip at hand is equal to
THERMAL_TEMP_INVALID and it has been crossed on the way up to trigger
all of the necessary adjustments in user space, the thermal debug
code and the zone governor.
Fixes: 8c69a777e4
("thermal: core: Fix the handling of invalid trip points")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
181 lines
4.4 KiB
C
181 lines
4.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2008 Intel Corp
|
|
* Copyright (C) 2008 Zhang Rui <rui.zhang@intel.com>
|
|
* Copyright (C) 2008 Sujith Thomas <sujith.thomas@intel.com>
|
|
* Copyright 2022 Linaro Limited
|
|
*
|
|
* Thermal trips handling
|
|
*/
|
|
#include "thermal_core.h"
|
|
|
|
int for_each_thermal_trip(struct thermal_zone_device *tz,
|
|
int (*cb)(struct thermal_trip *, void *),
|
|
void *data)
|
|
{
|
|
struct thermal_trip_desc *td;
|
|
int ret;
|
|
|
|
for_each_trip_desc(tz, td) {
|
|
ret = cb(&td->trip, data);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(for_each_thermal_trip);
|
|
|
|
int thermal_zone_for_each_trip(struct thermal_zone_device *tz,
|
|
int (*cb)(struct thermal_trip *, void *),
|
|
void *data)
|
|
{
|
|
int ret;
|
|
|
|
mutex_lock(&tz->lock);
|
|
ret = for_each_thermal_trip(tz, cb, data);
|
|
mutex_unlock(&tz->lock);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(thermal_zone_for_each_trip);
|
|
|
|
int thermal_zone_get_num_trips(struct thermal_zone_device *tz)
|
|
{
|
|
return tz->num_trips;
|
|
}
|
|
EXPORT_SYMBOL_GPL(thermal_zone_get_num_trips);
|
|
|
|
/**
|
|
* __thermal_zone_set_trips - Computes the next trip points for the driver
|
|
* @tz: a pointer to a thermal zone device structure
|
|
*
|
|
* The function computes the next temperature boundaries by browsing
|
|
* the trip points. The result is the closer low and high trip points
|
|
* to the current temperature. These values are passed to the backend
|
|
* driver to let it set its own notification mechanism (usually an
|
|
* interrupt).
|
|
*
|
|
* This function must be called with tz->lock held. Both tz and tz->ops
|
|
* must be valid pointers.
|
|
*
|
|
* It does not return a value
|
|
*/
|
|
void __thermal_zone_set_trips(struct thermal_zone_device *tz)
|
|
{
|
|
const struct thermal_trip_desc *td;
|
|
int low = -INT_MAX, high = INT_MAX;
|
|
int ret;
|
|
|
|
lockdep_assert_held(&tz->lock);
|
|
|
|
if (!tz->ops.set_trips)
|
|
return;
|
|
|
|
for_each_trip_desc(tz, td) {
|
|
const struct thermal_trip *trip = &td->trip;
|
|
int trip_low;
|
|
|
|
trip_low = trip->temperature - trip->hysteresis;
|
|
|
|
if (trip_low < tz->temperature && trip_low > low)
|
|
low = trip_low;
|
|
|
|
if (trip->temperature > tz->temperature &&
|
|
trip->temperature < high)
|
|
high = trip->temperature;
|
|
}
|
|
|
|
/* No need to change trip points */
|
|
if (tz->prev_low_trip == low && tz->prev_high_trip == high)
|
|
return;
|
|
|
|
tz->prev_low_trip = low;
|
|
tz->prev_high_trip = high;
|
|
|
|
dev_dbg(&tz->device,
|
|
"new temperature boundaries: %d < x < %d\n", low, high);
|
|
|
|
/*
|
|
* Set a temperature window. When this window is left the driver
|
|
* must inform the thermal core via thermal_zone_device_update.
|
|
*/
|
|
ret = tz->ops.set_trips(tz, low, high);
|
|
if (ret)
|
|
dev_err(&tz->device, "Failed to set trips: %d\n", ret);
|
|
}
|
|
|
|
int __thermal_zone_get_trip(struct thermal_zone_device *tz, int trip_id,
|
|
struct thermal_trip *trip)
|
|
{
|
|
if (!tz || trip_id < 0 || trip_id >= tz->num_trips || !trip)
|
|
return -EINVAL;
|
|
|
|
*trip = tz->trips[trip_id].trip;
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(__thermal_zone_get_trip);
|
|
|
|
int thermal_zone_get_trip(struct thermal_zone_device *tz, int trip_id,
|
|
struct thermal_trip *trip)
|
|
{
|
|
int ret;
|
|
|
|
mutex_lock(&tz->lock);
|
|
ret = __thermal_zone_get_trip(tz, trip_id, trip);
|
|
mutex_unlock(&tz->lock);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(thermal_zone_get_trip);
|
|
|
|
int thermal_zone_trip_id(const struct thermal_zone_device *tz,
|
|
const struct thermal_trip *trip)
|
|
{
|
|
/*
|
|
* Assume the trip to be located within the bounds of the thermal
|
|
* zone's trips[] table.
|
|
*/
|
|
return trip_to_trip_desc(trip) - tz->trips;
|
|
}
|
|
|
|
void thermal_zone_trip_updated(struct thermal_zone_device *tz,
|
|
const struct thermal_trip *trip)
|
|
{
|
|
thermal_notify_tz_trip_change(tz, trip);
|
|
__thermal_zone_device_update(tz, THERMAL_TRIP_CHANGED);
|
|
}
|
|
|
|
void thermal_zone_set_trip_temp(struct thermal_zone_device *tz,
|
|
struct thermal_trip *trip, int temp)
|
|
{
|
|
if (trip->temperature == temp)
|
|
return;
|
|
|
|
trip->temperature = temp;
|
|
thermal_notify_tz_trip_change(tz, trip);
|
|
|
|
if (temp == THERMAL_TEMP_INVALID) {
|
|
struct thermal_trip_desc *td = trip_to_trip_desc(trip);
|
|
|
|
if (tz->temperature >= td->threshold) {
|
|
/*
|
|
* The trip has been crossed on the way up, so some
|
|
* adjustments are needed to compensate for the lack
|
|
* of it going forward.
|
|
*/
|
|
if (trip->type == THERMAL_TRIP_PASSIVE) {
|
|
tz->passive--;
|
|
WARN_ON_ONCE(tz->passive < 0);
|
|
}
|
|
thermal_zone_trip_down(tz, trip);
|
|
}
|
|
/*
|
|
* Invalidate the threshold to avoid triggering a spurious
|
|
* trip crossing notification when the trip becomes valid.
|
|
*/
|
|
td->threshold = INT_MAX;
|
|
}
|
|
}
|
|
EXPORT_SYMBOL_GPL(thermal_zone_set_trip_temp);
|