Yogesh bdf07ab159 fs: jfs: Fix UBSAN: array-index-out-of-bounds in dbAllocDmapLev ... [ Upstream commit 4e302336d5 ] Syzkaller reported the following issue: UBSAN: array-index-out-of-bounds in fs/jfs/jfs_dmap.c:1965:6 index -84 is out of range for type 's8[341]' (aka 'signed char[341]') CPU: 1 PID: 4995 Comm: syz-executor146 Not tainted 6.4.0-rc6-syzkaller-00037-gb6dad5178cea #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 ubsan_epilogue lib/ubsan.c:217 [inline] __ubsan_handle_out_of_bounds+0x11c/0x150 lib/ubsan.c:348 dbAllocDmapLev+0x3e5/0x430 fs/jfs/jfs_dmap.c:1965 dbAllocCtl+0x113/0x920 fs/jfs/jfs_dmap.c:1809 dbAllocAG+0x28f/0x10b0 fs/jfs/jfs_dmap.c:1350 dbAlloc+0x658/0xca0 fs/jfs/jfs_dmap.c:874 dtSplitUp fs/jfs/jfs_dtree.c:974 [inline] dtInsert+0xda7/0x6b00 fs/jfs/jfs_dtree.c:863 jfs_create+0x7b6/0xbb0 fs/jfs/namei.c:137 lookup_open fs/namei.c:3492 [inline] open_last_lookups fs/namei.c:3560 [inline] path_openat+0x13df/0x3170 fs/namei.c:3788 do_filp_open+0x234/0x490 fs/namei.c:3818 do_sys_openat2+0x13f/0x500 fs/open.c:1356 do_sys_open fs/open.c:1372 [inline] __do_sys_openat fs/open.c:1388 [inline] __se_sys_openat fs/open.c:1383 [inline] __x64_sys_openat+0x247/0x290 fs/open.c:1383 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f1f4e33f7e9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffc21129578 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f1f4e33f7e9 RDX: 000000000000275a RSI: 0000000020000040 RDI: 00000000ffffff9c RBP: 00007f1f4e2ff080 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f1f4e2ff110 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 </TASK> The bug occurs when the dbAllocDmapLev()function attempts to access dp->tree.stree[leafidx + LEAFIND] while the leafidx value is negative. To rectify this, the patch introduces a safeguard within the dbAllocDmapLev() function. A check has been added to verify if leafidx is negative. If it is, the function immediately returns an I/O error, preventing any further execution that could potentially cause harm. Tested via syzbot. Reported-by: syzbot+853a6f4dfa3cf37d3aea@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=ae2f5a27a07ae44b0f17 Signed-off-by: Yogesh <yogi.kernel@gmail.com> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-07-27 08:50:32 +02:00
..
acl.c	vfs: add rcu argument to ->get_acl() callback	2021-08-18 22:08:24 +02:00
file.c	attr: port attribute changes to new types	2022-06-26 18:18:56 +02:00
inode.c	jfs: stop using the nobh helper	2022-08-02 12:34:04 -04:00
ioctl.c	block: add a bdev_discard_granularity helper	2022-04-17 19:49:59 -06:00
jfs_acl.h	vfs: add rcu argument to ->get_acl() callback	2021-08-18 22:08:24 +02:00
jfs_btree.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_debug.c	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
jfs_debug.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_dinode.h	jfs: Avoid field-overflowing memcpy()	2021-06-23 09:21:52 -05:00
jfs_discard.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_discard.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_dmap.c	fs: jfs: Fix UBSAN: array-index-out-of-bounds in dbAllocDmapLev	2023-07-27 08:50:32 +02:00
jfs_dmap.h	jfs: Fix array index bounds check in dbAdjTree	2020-11-13 16:03:07 -06:00
jfs_dtree.c	fs/jfs: Remove dead code	2022-04-25 14:00:33 -05:00
jfs_dtree.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_extent.c	fs/jfs: Remove dead code	2022-04-25 14:00:33 -05:00
jfs_extent.h	jfs: delete duplicated words + other fixes	2020-11-13 13:36:00 -06:00
jfs_filsys.h	jfs: jfs_dmap: Validate db_l2nbperpage while mounting	2023-07-23 13:49:34 +02:00
jfs_imap.c	jfs: Avoid field-overflowing memcpy()	2021-06-23 09:21:52 -05:00
jfs_imap.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_incore.h	jfs: Avoid field-overflowing memcpy()	2021-06-23 09:21:52 -05:00
jfs_inode.c	inode: make init and permission helpers idmapped mount aware	2021-01-24 14:27:16 +01:00
jfs_inode.h	jfs: convert to fileattr	2021-04-12 15:04:29 +02:00
jfs_lock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_logmgr.c	fs/jfs: Remove dead code	2022-04-25 14:00:33 -05:00
jfs_logmgr.h	jfs: delete duplicated words + other fixes	2020-11-13 13:36:00 -06:00
jfs_metapage.c	jfs: Remove check for PageUptodate	2022-06-29 08:51:07 -04:00
jfs_metapage.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_mount.c	fs/jfs: Remove dead code	2022-04-25 14:00:33 -05:00
jfs_superblock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_txnmgr.c	fs/jfs: Remove dead code	2022-04-25 14:00:33 -05:00
jfs_txnmgr.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_types.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_umount.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_unicode.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_unicode.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_uniupr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_xattr.h	jfs: Replace zero-length array with flexible-array member	2020-03-09 15:18:51 -05:00
jfs_xtree.c	fs/jfs: Remove dead code	2022-04-25 14:00:33 -05:00
jfs_xtree.h	fs/jfs: Remove dead code	2022-04-25 14:00:33 -05:00
Kconfig	docs: fix a couple of new broken references	2019-07-31 14:12:26 -06:00
Makefile	fs/jfs: Remove dead code	2022-04-25 14:00:33 -05:00
namei.c	jfs: Fix fortify moan in symlink	2022-12-31 13:32:57 +01:00
resize.c	jfs: use sb_bdev_nr_blocks	2021-10-18 14:43:23 -06:00
super.c	block: remove QUEUE_FLAG_DISCARD	2022-04-17 19:49:59 -06:00
symlink.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
xattr.c	acl: handle idmapped mounts	2021-01-24 14:27:17 +01:00