Paolo Abeni 27f0ad7169 net: fix hangup on napi_disable for threaded napi ... napi_disable() is subject to an hangup, when the threaded mode is enabled and the napi is under heavy traffic. If the relevant napi has been scheduled and the napi_disable() kicks in before the next napi_threaded_wait() completes - so that the latter quits due to the napi_disable_pending() condition, the existing code leaves the NAPI_STATE_SCHED bit set and the napi_disable() loop waiting for such bit will hang. This patch addresses the issue by dropping the NAPI_STATE_DISABLE bit test in napi_thread_wait(). The later napi_threaded_poll() iteration will take care of clearing the NAPI_STATE_SCHED. This also addresses a related problem reported by Jakub: before this patch a napi_disable()/napi_enable() pair killed the napi thread, effectively disabling the threaded mode. On the patched kernel napi_disable() simply stops scheduling the relevant thread. v1 -> v2: - let the main napi_thread_poll() loop clear the SCHED bit Reported-by: Jakub Kicinski <kuba@kernel.org> Fixes: 29863d41bb ("net: implement threaded-able napi poll loop support") Signed-off-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/r/883923fa22745a9589e8610962b7dc59df09fb1f.1617981844.git.pabeni@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2021-04-09 12:50:31 -07:00
..
6lowpan	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
9p	net: 9p: advance iov on empty read	2021-03-03 16:57:59 -08:00
802	net: 802: psnap.c: Use built-in RCU list checking	2020-02-24 13:02:53 -08:00
8021q	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-01-14 18:34:50 -08:00
appletalk	appletalk: Fix skb allocation size in loopback case	2021-02-12 16:40:28 -08:00
atm	net: atm: pppoatm: use new API for wakeup tasklet	2021-01-29 18:24:05 -08:00
ax25	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-07-25 17:49:04 -07:00
batman-adv	batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field	2021-04-05 15:06:03 -07:00
bluetooth	Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kern	2021-02-11 14:59:01 -08:00
bpf	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-01-20 12:16:11 -08:00
bpfilter	net: remove redundant 'depends on NET'	2021-01-27 17:04:12 -08:00
bridge	net: bridge: don't notify switchdev for local FDB addresses	2021-03-23 14:39:41 -07:00
caif	net: caif: Use netif_rx_any_context().	2021-02-15 13:21:48 -08:00
can	can: isotp: fix msg_namelen values depending on CAN_REQUIRED_SIZE	2021-03-29 09:51:43 +02:00
ceph	libceph: remove osdtimeout option entirely	2021-02-16 12:09:52 +01:00
core	net: fix hangup on napi_disable for threaded napi	2021-04-09 12:50:31 -07:00
dcb	net: dcb: use obj-$(CONFIG_DCB) form in net/Makefile	2021-01-27 17:03:52 -08:00
dccp	ipv6: weaken the v4mapped source check	2021-03-18 11:19:23 -07:00
decnet	net: decnet: fix netdev refcount leaking on error path	2021-01-27 17:33:46 -08:00
dns_resolver	net: remove redundant 'depends on NET'	2021-01-27 17:04:12 -08:00
dsa	net: dsa: Fix type was not set for devlink port	2021-03-29 13:49:04 -07:00
ethernet	net: datagram: fix some kernel-doc markups	2020-11-17 14:15:03 -08:00
ethtool	ethtool: Add lanes parameter for ETHTOOL_LINK_MODE_10000baseR_FEC_BIT	2021-04-07 14:53:04 -07:00
hsr	net: hsr: Reset MAC header for Tx path	2021-04-07 14:25:12 -07:00
ieee802154	net: ieee802154: stop dump llsec params for monitors	2021-04-06 22:34:38 +02:00
ife	net: remove redundant 'depends on NET'	2021-01-27 17:04:12 -08:00
ipv4	ipv6: report errors for iftoken via netlink extack	2021-04-08 13:52:36 -07:00
ipv6	net: ipv6: check for validity before dereferencing cfg->fc_nlinfo.nlh	2021-04-08 16:41:46 -07:00
iucv	net/af_iucv: build SG skbs for TRANS_HIPER sockets	2021-01-28 20:36:22 -08:00
kcm	net: group skb_shinfo zerocopy related bits together.	2021-01-07 16:08:37 -08:00
key	af_key: relax availability checks for skb size calculation	2021-01-04 10:05:50 +01:00
l2tp	net: l2tp: reduce log level of messages in receive path, add counter instead	2021-03-03 16:55:02 -08:00
l3mdev	net: l3mdev: use obj-$(CONFIG_NET_L3_MASTER_DEV) form in net/Makefile	2021-01-27 17:03:52 -08:00
lapb	net: lapb: Copy the skb before sending a packet	2021-02-02 08:40:48 -08:00
llc	net: remove redundant 'depends on NET'	2021-01-27 17:04:12 -08:00
mac80211	mac80211: fix time-is-after bug in mlme	2021-04-08 10:14:53 +02:00
mac802154	net: mac802154: Fix general protection fault	2021-04-06 22:42:16 +02:00
mpls	net: avoid infinite loop in mpls_gso_segment when mpls_hlen == 0	2021-03-09 16:12:20 -08:00
mptcp	mptcp: revert "mptcp: provide subflow aware release function"	2021-04-01 16:02:50 -07:00
ncsi	net/ncsi: Avoid channel_monitor hrtimer deadlock	2021-03-30 13:16:23 -07:00
netfilter	netfilter: nftables: skip hook overlap logic if flowtable is stale	2021-03-18 01:08:54 +01:00
netlabel	cipso,calipso: resolve a number of problems with the DOI refcounts	2021-03-04 15:26:57 -08:00
netlink	mptcp: avoid lock_fast usage in accept path	2021-02-12 16:31:46 -08:00
netrom	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
nfc	nfc: Avoid endless loops caused by repeated llcp_sock_connect()	2021-03-25 17:02:01 -07:00
nsh	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
openvswitch	openvswitch: fix send of uninitialized stack memory in ct limit reply	2021-04-05 12:54:42 -07:00
packet	net/packet: Improve the comment about LL header visibility criteria	2021-02-06 14:59:28 -08:00
phonet	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
psample	net: psample: Fix netlink skb length with tunnel info	2021-02-25 09:49:46 -08:00
qrtr	net: qrtr: Fix memory leak on qrtr_tx_wait failure	2021-03-30 13:48:29 -07:00
rds	net/rds: Avoid potential use after free in rds_send_remove_from_sock	2021-04-07 14:01:24 -07:00
rfkill	rfkill: revert back to old userspace API by default	2021-04-08 10:14:45 +02:00
rose	rose: Fix Null pointer dereference in rose_send_frame()	2020-11-20 10:04:58 -08:00
rxrpc	rxrpc: Fix dependency on IPv6 in udp tunnel config	2021-02-12 16:42:05 -08:00
sched	net: sched: sch_teql: fix null-pointer dereference	2021-04-08 14:14:42 -07:00
sctp	net-ipv6: bugfix - raw & sctp - switch to ipv6_can_nonlocal_bind()	2021-04-05 12:56:52 -07:00
smc	net/smc: use memcpy instead of snprintf to avoid out of bounds read	2021-01-12 20:22:01 -08:00
strparser	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-22 08:59:24 -04:00
sunrpc	Miscellaneous NFSD fixes for v5.12-rc.	2021-03-16 10:22:50 -07:00
switchdev	net: bridge: propagate extack through switchdev_port_attr_set	2021-02-14 17:38:11 -08:00
tipc	net: tipc: Fix spelling errors in net/tipc module	2021-04-07 14:29:29 -07:00
tls	net/tls: Select SOCK_RX_QUEUE_MAPPING from TLS_DEVICE	2021-02-11 19:08:06 -08:00
unix	af_unix: handle idmapped mounts	2021-01-24 14:27:18 +01:00
vmw_vsock	selinux: vsock: Set SID for socket returned by accept()	2021-03-19 13:46:55 -07:00
wireless	nl80211: fix beacon head validation	2021-04-08 16:43:05 +02:00
x25	net: x25: Remove unimplemented X.25-over-LLC code stubs	2020-12-12 17:15:33 -08:00
xdp	xsk: Fold xp_assign_dev and __xp_assign_dev	2021-01-25 23:56:33 +01:00
xfrm	xfrm/compat: Cleanup WARN()s that can be user-triggered	2021-03-30 07:29:09 +02:00
compat.c	iov_iter: transparently handle compat iovecs in import_iovec	2020-10-03 00:02:13 -04:00
devres.c	net: devres: rename the release callback of devm_register_netdev()	2020-06-30 15:57:34 -07:00
Kconfig	net/sock: Add kernel config SOCK_RX_QUEUE_MAPPING	2021-02-11 19:08:06 -08:00
Makefile	net: l3mdev: use obj-$(CONFIG_NET_L3_MASTER_DEV) form in net/Makefile	2021-01-27 17:03:52 -08:00
socket.c	io_uring-worker.v3-2021-02-25	2021-02-27 08:29:02 -08:00
sysctl_net.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00