License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 14:07:57 +00:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2013-08-14 12:55:40 +00:00
|
|
|
#ifndef __ASM_PREEMPT_H
|
|
|
|
#define __ASM_PREEMPT_H
|
|
|
|
|
|
|
|
#include <linux/thread_info.h>
|
|
|
|
|
2013-11-28 13:26:41 +00:00
|
|
|
#define PREEMPT_ENABLED (0)
|
|
|
|
|
2013-08-14 12:55:40 +00:00
|
|
|
static __always_inline int preempt_count(void)
|
|
|
|
{
|
2016-05-16 13:01:11 +00:00
|
|
|
return READ_ONCE(current_thread_info()->preempt_count);
|
2013-08-14 12:55:40 +00:00
|
|
|
}
|
|
|
|
|
2016-05-16 13:01:11 +00:00
|
|
|
static __always_inline volatile int *preempt_count_ptr(void)
|
2013-08-14 12:55:40 +00:00
|
|
|
{
|
|
|
|
return ¤t_thread_info()->preempt_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static __always_inline void preempt_count_set(int pc)
|
|
|
|
{
|
|
|
|
*preempt_count_ptr() = pc;
|
|
|
|
}
|
|
|
|
|
2013-08-14 12:55:46 +00:00
|
|
|
/*
|
|
|
|
* must be macros to avoid header recursion hell
|
|
|
|
*/
|
|
|
|
#define init_task_preempt_count(p) do { \
|
2015-09-28 15:52:18 +00:00
|
|
|
task_thread_info(p)->preempt_count = FORK_PREEMPT_COUNT; \
|
2013-08-14 12:55:46 +00:00
|
|
|
} while (0)
|
|
|
|
|
|
|
|
#define init_idle_preempt_count(p, cpu) do { \
|
sched/core: Initialize the idle task with preemption disabled
As pointed out by commit
de9b8f5dcbd9 ("sched: Fix crash trying to dequeue/enqueue the idle thread")
init_idle() can and will be invoked more than once on the same idle
task. At boot time, it is invoked for the boot CPU thread by
sched_init(). Then smp_init() creates the threads for all the secondary
CPUs and invokes init_idle() on them.
As the hotplug machinery brings the secondaries to life, it will issue
calls to idle_thread_get(), which itself invokes init_idle() yet again.
In this case it's invoked twice more per secondary: at _cpu_up(), and at
bringup_cpu().
Given smp_init() already initializes the idle tasks for all *possible*
CPUs, no further initialization should be required. Now, removing
init_idle() from idle_thread_get() exposes some interesting expectations
with regards to the idle task's preempt_count: the secondary startup always
issues a preempt_disable(), requiring some reset of the preempt count to 0
between hot-unplug and hotplug, which is currently served by
idle_thread_get() -> idle_init().
Given the idle task is supposed to have preemption disabled once and never
see it re-enabled, it seems that what we actually want is to initialize its
preempt_count to PREEMPT_DISABLED and leave it there. Do that, and remove
init_idle() from idle_thread_get().
Secondary startups were patched via coccinelle:
@begone@
@@
-preempt_disable();
...
cpu_startup_entry(CPUHP_AP_ONLINE_IDLE);
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210512094636.2958515-1-valentin.schneider@arm.com
2021-05-12 09:46:36 +00:00
|
|
|
task_thread_info(p)->preempt_count = PREEMPT_DISABLED; \
|
2013-08-14 12:55:46 +00:00
|
|
|
} while (0)
|
|
|
|
|
2013-08-14 12:55:40 +00:00
|
|
|
static __always_inline void set_preempt_need_resched(void)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static __always_inline void clear_preempt_need_resched(void)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static __always_inline bool test_preempt_need_resched(void)
|
|
|
|
{
|
2013-11-28 13:26:41 +00:00
|
|
|
return false;
|
2013-08-14 12:55:40 +00:00
|
|
|
}
|
|
|
|
|
2013-09-10 10:15:23 +00:00
|
|
|
/*
|
|
|
|
* The various preempt_count add/sub methods
|
|
|
|
*/
|
|
|
|
|
|
|
|
static __always_inline void __preempt_count_add(int val)
|
|
|
|
{
|
|
|
|
*preempt_count_ptr() += val;
|
|
|
|
}
|
|
|
|
|
|
|
|
static __always_inline void __preempt_count_sub(int val)
|
|
|
|
{
|
|
|
|
*preempt_count_ptr() -= val;
|
|
|
|
}
|
|
|
|
|
|
|
|
static __always_inline bool __preempt_count_dec_and_test(void)
|
|
|
|
{
|
2013-11-28 13:26:41 +00:00
|
|
|
/*
|
|
|
|
* Because of load-store architectures cannot do per-cpu atomic
|
|
|
|
* operations; we cannot use PREEMPT_NEED_RESCHED because it might get
|
|
|
|
* lost.
|
|
|
|
*/
|
|
|
|
return !--*preempt_count_ptr() && tif_need_resched();
|
2013-09-10 10:15:23 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Returns true when we need to resched and can (barring IRQ state).
|
|
|
|
*/
|
2015-07-15 09:52:04 +00:00
|
|
|
static __always_inline bool should_resched(int preempt_offset)
|
2013-09-10 10:15:23 +00:00
|
|
|
{
|
2015-07-15 09:52:04 +00:00
|
|
|
return unlikely(preempt_count() == preempt_offset &&
|
|
|
|
tif_need_resched());
|
2013-09-10 10:15:23 +00:00
|
|
|
}
|
|
|
|
|
2019-07-26 21:19:37 +00:00
|
|
|
#ifdef CONFIG_PREEMPTION
|
2013-08-14 12:51:00 +00:00
|
|
|
extern asmlinkage void preempt_schedule(void);
|
2015-06-04 15:39:08 +00:00
|
|
|
extern asmlinkage void preempt_schedule_notrace(void);
|
riscv: support PREEMPT_DYNAMIC with static keys
Currently, each architecture can support PREEMPT_DYNAMIC through
either static calls or static keys. To support PREEMPT_DYNAMIC on
riscv, we face three choices:
1. only add static calls support to riscv
As Mark pointed out in commit 99cf983cc8bc ("sched/preempt: Add
PREEMPT_DYNAMIC using static keys"), static keys "...should have
slightly lower overhead than non-inline static calls, as this
effectively inlines each trampoline into the start of its callee. This
may avoid redundant work, and may integrate better with CFI schemes."
So even we add static calls(without inline static calls) to riscv,
static keys is still a better choice.
2. add static calls and inline static calls to riscv
Per my understanding, inline static calls requires objtool support
which is not easy.
3. use static keys
While riscv doesn't have static calls support, it supports static keys
perfectly. So this patch selects HAVE_PREEMPT_DYNAMIC_KEY to enable
support for PREEMPT_DYNAMIC on riscv, so that the preemption model can
be chosen at boot time. It also patches asm-generic/preempt.h, mainly
to add __preempt_schedule() and __preempt_schedule_notrace() macros
for PREEMPT_DYNAMIC case. Other architectures which use generic
preempt.h can also benefit from this patch by simply selecting
HAVE_PREEMPT_DYNAMIC_KEY to enable PREEMPT_DYNAMIC if they supports
static keys.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230716164925.1858-1-jszhang@kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
2023-07-16 16:49:25 +00:00
|
|
|
|
|
|
|
#if defined(CONFIG_PREEMPT_DYNAMIC) && defined(CONFIG_HAVE_PREEMPT_DYNAMIC_KEY)
|
|
|
|
|
|
|
|
void dynamic_preempt_schedule(void);
|
|
|
|
void dynamic_preempt_schedule_notrace(void);
|
|
|
|
#define __preempt_schedule() dynamic_preempt_schedule()
|
|
|
|
#define __preempt_schedule_notrace() dynamic_preempt_schedule_notrace()
|
|
|
|
|
|
|
|
#else /* !CONFIG_PREEMPT_DYNAMIC || !CONFIG_HAVE_PREEMPT_DYNAMIC_KEY*/
|
|
|
|
|
|
|
|
#define __preempt_schedule() preempt_schedule()
|
2015-06-04 15:39:08 +00:00
|
|
|
#define __preempt_schedule_notrace() preempt_schedule_notrace()
|
riscv: support PREEMPT_DYNAMIC with static keys
Currently, each architecture can support PREEMPT_DYNAMIC through
either static calls or static keys. To support PREEMPT_DYNAMIC on
riscv, we face three choices:
1. only add static calls support to riscv
As Mark pointed out in commit 99cf983cc8bc ("sched/preempt: Add
PREEMPT_DYNAMIC using static keys"), static keys "...should have
slightly lower overhead than non-inline static calls, as this
effectively inlines each trampoline into the start of its callee. This
may avoid redundant work, and may integrate better with CFI schemes."
So even we add static calls(without inline static calls) to riscv,
static keys is still a better choice.
2. add static calls and inline static calls to riscv
Per my understanding, inline static calls requires objtool support
which is not easy.
3. use static keys
While riscv doesn't have static calls support, it supports static keys
perfectly. So this patch selects HAVE_PREEMPT_DYNAMIC_KEY to enable
support for PREEMPT_DYNAMIC on riscv, so that the preemption model can
be chosen at boot time. It also patches asm-generic/preempt.h, mainly
to add __preempt_schedule() and __preempt_schedule_notrace() macros
for PREEMPT_DYNAMIC case. Other architectures which use generic
preempt.h can also benefit from this patch by simply selecting
HAVE_PREEMPT_DYNAMIC_KEY to enable PREEMPT_DYNAMIC if they supports
static keys.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230716164925.1858-1-jszhang@kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
2023-07-16 16:49:25 +00:00
|
|
|
|
|
|
|
#endif /* CONFIG_PREEMPT_DYNAMIC && CONFIG_HAVE_PREEMPT_DYNAMIC_KEY*/
|
2019-07-26 21:19:37 +00:00
|
|
|
#endif /* CONFIG_PREEMPTION */
|
2013-08-14 12:51:00 +00:00
|
|
|
|
2013-08-14 12:55:40 +00:00
|
|
|
#endif /* __ASM_PREEMPT_H */
|