Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-19 03:31:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

media: pxa_camera: Drop usage of .set_mbus_config()

Browse Source 
The subdev .set_mbus_config() operation is deprecated and will be
dropped. Drop its usage from the pxa_camera driver, querying the sensor
bus configuration instead of setting it. Only the ov6650 driver supports
the operation, any platform that experiences issues with this change
should update the ov6650 configuration to match what pxa_camera
supports.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Laurent Pinchart 2022-01-03 17:24:07 +01:00 committed by Mauro Carvalho Chehab
parent 336136e197
commit 04c66deecf
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/media/platform/pxa_camera.c
View File

@ -1573,17 +1573,16 @@ static int pxa_camera_set_bus_param(struct pxa_camera_dev *pcdev)
mbus_config |= V4L2_MBUS_PCLK_SAMPLE_FALLING; mbus_config |= V4L2_MBUS_PCLK_SAMPLE_FALLING;
mbus_config |= V4L2_MBUS_DATA_ACTIVE_HIGH; mbus_config |= V4L2_MBUS_DATA_ACTIVE_HIGH;
cfg.flags = mbus_config; ret = sensor_call(pcdev, pad, get_mbus_config, 0, &cfg);
ret = sensor_call(pcdev, pad, set_mbus_config, 0, &cfg);
if (ret < 0 && ret != -ENOIOCTLCMD) { if (ret < 0 && ret != -ENOIOCTLCMD) {
dev_err(pcdev_to_dev(pcdev), dev_err(pcdev_to_dev(pcdev),
"Failed to call set_mbus_config: %d\n", ret); "Failed to call get_mbus_config: %d\n", ret);
return ret; return ret;
} }
/* /*
* If the requested media bus configuration has not been fully applied * If the media bus configuration of the sensor differs, make sure it
* make sure it is supported by the platform. * is supported by the platform.
* *
* PXA does not support V4L2_MBUS_DATA_ACTIVE_LOW and the bus mastering * PXA does not support V4L2_MBUS_DATA_ACTIVE_LOW and the bus mastering
* roles should match. * roles should match.