Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-07 13:53:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vduse: Disallow injecting interrupt before DRIVER_OK is set

Browse Source 
The interrupt callback should not be triggered before DRIVER_OK
is set. Otherwise, it might break the virtio device driver.
So let's add a check to avoid the unexpected behavior.

Fixes: c8a6153b6c ("vduse: Introduce VDUSE - vDPA Device in Userspace")
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Link: https://lore.kernel.org/r/20210923075722.98-1-xieyongji@bytedance.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Xie Yongji 2021-09-23 15:57:22 +08:00 committed by Michael S. Tsirkin
parent 6422251513
commit 1394103fd7
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/vdpa/vdpa_user/vduse_dev.c
View File

@ -966,6 +966,10 @@ static long vduse_dev_ioctl(struct file *file, unsigned int cmd,
break;
}
case VDUSE_DEV_INJECT_CONFIG_IRQ:
ret = -EINVAL;
if (!(dev->status & VIRTIO_CONFIG_S_DRIVER_OK))
break;
ret = 0;
queue_work(vduse_irq_wq, &dev->inject);
break;
@ -1045,6 +1049,10 @@ static long vduse_dev_ioctl(struct file *file, unsigned int cmd,
case VDUSE_VQ_INJECT_IRQ: {
u32 index;
ret = -EINVAL;
if (!(dev->status & VIRTIO_CONFIG_S_DRIVER_OK))
break;
ret = -EFAULT;
if (get_user(index, (u32 __user *)argp))
break;