From 2842dc9bc1a53893eec62ec9e49beb3b501702d0 Mon Sep 17 00:00:00 2001 From: Muhammad Usama Anjum Date: Mon, 4 Mar 2024 14:01:03 +0500 Subject: [PATCH] mtd: spi-nor: core: correct type of i The i should be signed to find out the end of the loop. Otherwise, i >= 0 is always true and loop becomes infinite. Make its type to be int. Fixes: 6a9eda34418f ("mtd: spi-nor: core: set mtd->eraseregions for non-uniform erase map") Signed-off-by: Muhammad Usama Anjum Reviewed-by: Tudor Ambarus Reviewed-by: Michael Walle Reviewed-by: Dan Carpenter Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20240304090103.818092-1-usama.anjum@collabora.com --- drivers/mtd/spi-nor/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 65b32ea59afc..3e1f1913536b 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -3373,7 +3373,7 @@ static u32 spi_nor_get_region_erasesize(const struct spi_nor_erase_region *region, const struct spi_nor_erase_type *erase_type) { - u8 i; + int i; if (region->overlaid) return region->size;