Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-10 07:10:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

spmi: pmic-arb: optimize qpnpint_irq_set_type function

Browse Source 
Optimize the qpnpint_irq_set_type() by using a local variable
to hold the handler type. Also clean up other variable usage.

Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kiran Gunda 2017-07-28 12:40:39 +05:30 committed by Greg Kroah-Hartman
parent f2f3156472
commit 325255bc95
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/spmi/spmi-pmic-arb.c
View File

@ -587,35 +587,35 @@ static void qpnpint_irq_unmask(struct irq_data *d)
static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type) static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type)
{ {
struct spmi_pmic_arb_qpnpint_type type; struct spmi_pmic_arb_qpnpint_type type;
irq_flow_handler_t flow_handler;
u8 irq = hwirq_to_irq(d->hwirq); u8 irq = hwirq_to_irq(d->hwirq);
u8 bit_mask_irq = BIT(irq);
qpnpint_spmi_read(d, QPNPINT_REG_SET_TYPE, &type, sizeof(type)); qpnpint_spmi_read(d, QPNPINT_REG_SET_TYPE, &type, sizeof(type));
if (flow_type & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING)) { if (flow_type & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING)) {
type.type |= bit_mask_irq; type.type |= BIT(irq);
if (flow_type & IRQF_TRIGGER_RISING) if (flow_type & IRQF_TRIGGER_RISING)
type.polarity_high |= bit_mask_irq; type.polarity_high |= BIT(irq);
if (flow_type & IRQF_TRIGGER_FALLING) if (flow_type & IRQF_TRIGGER_FALLING)
type.polarity_low |= bit_mask_irq; type.polarity_low |= BIT(irq);
flow_handler = handle_edge_irq;
} else { } else {
if ((flow_type & (IRQF_TRIGGER_HIGH)) && if ((flow_type & (IRQF_TRIGGER_HIGH)) &&
(flow_type & (IRQF_TRIGGER_LOW))) (flow_type & (IRQF_TRIGGER_LOW)))
return -EINVAL; return -EINVAL;
type.type &= ~bit_mask_irq; /* level trig */ type.type &= ~BIT(irq); /* level trig */
if (flow_type & IRQF_TRIGGER_HIGH) if (flow_type & IRQF_TRIGGER_HIGH)
type.polarity_high |= bit_mask_irq; type.polarity_high |= BIT(irq);
else else
type.polarity_low |= bit_mask_irq; type.polarity_low |= BIT(irq);
flow_handler = handle_level_irq;
} }
qpnpint_spmi_write(d, QPNPINT_REG_SET_TYPE, &type, sizeof(type)); qpnpint_spmi_write(d, QPNPINT_REG_SET_TYPE, &type, sizeof(type));
irq_set_handler_locked(d, flow_handler);
if (flow_type & IRQ_TYPE_EDGE_BOTH)
irq_set_handler_locked(d, handle_edge_irq);
else
irq_set_handler_locked(d, handle_level_irq);
return 0; return 0;
} }