SL*B: drop kmem cache argument from constructor

Kmem cache passed to constructor is only needed for constructors that are
themselves multiplexeres.  Nobody uses this "feature", nor does anybody uses
passed kmem cache in non-trivial way, so pass only pointer to object.

Non-trivial places are:
	arch/powerpc/mm/init_64.c
	arch/powerpc/mm/hugetlbpage.c

This is flag day, yes.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Jon Tollefson <kniht@linux.vnet.ibm.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Matt Mackall <mpm@selenic.com>
[akpm@linux-foundation.org: fix arch/powerpc/mm/hugetlbpage.c]
[akpm@linux-foundation.org: fix mm/slab.c]
[akpm@linux-foundation.org: fix ubifs]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alexey Dobriyan 2008-07-25 19:45:34 -07:00 committed by Linus Torvalds
parent d91958815d
commit 51cc50685a
67 changed files with 90 additions and 106 deletions

View File

@ -1304,7 +1304,7 @@ struct sysdev_class dma_sysclass = {
/* kmem cache implementation */
static void s3c2410_dma_cache_ctor(struct kmem_cache *c, void *p)
static void s3c2410_dma_cache_ctor(void *p)
{
memset(p, 0, sizeof(struct s3c2410_dma_buf));
}

View File

@ -286,7 +286,7 @@ static ssize_t rtas_flash_read(struct file *file, char __user *buf,
}
/* constructor for flash_block_cache */
void rtas_block_ctor(struct kmem_cache *cache, void *ptr)
void rtas_block_ctor(void *ptr)
{
memset(ptr, 0, RTAS_BLK_SIZE);
}

View File

@ -113,7 +113,7 @@ static inline pte_t *hugepte_offset(hugepd_t *hpdp, unsigned long addr,
static int __hugepte_alloc(struct mm_struct *mm, hugepd_t *hpdp,
unsigned long address, unsigned int psize)
{
pte_t *new = kmem_cache_alloc(huge_pgtable_cache(psize),
pte_t *new = kmem_cache_zalloc(huge_pgtable_cache(psize),
GFP_KERNEL|__GFP_REPEAT);
if (! new)
@ -730,11 +730,6 @@ static int __init hugepage_setup_sz(char *str)
}
__setup("hugepagesz=", hugepage_setup_sz);
static void zero_ctor(struct kmem_cache *cache, void *addr)
{
memset(addr, 0, kmem_cache_size(cache));
}
static int __init hugetlbpage_init(void)
{
unsigned int psize;
@ -756,7 +751,7 @@ static int __init hugetlbpage_init(void)
HUGEPTE_TABLE_SIZE(psize),
HUGEPTE_TABLE_SIZE(psize),
0,
zero_ctor);
NULL);
if (!huge_pgtable_cache(psize))
panic("hugetlbpage_init(): could not create %s"\
"\n", HUGEPTE_CACHE_NAME(psize));

View File

@ -136,9 +136,14 @@ static int __init setup_kcore(void)
module_init(setup_kcore);
#endif
static void zero_ctor(struct kmem_cache *cache, void *addr)
static void pgd_ctor(void *addr)
{
memset(addr, 0, kmem_cache_size(cache));
memset(addr, 0, PGD_TABLE_SIZE);
}
static void pmd_ctor(void *addr)
{
memset(addr, 0, PMD_TABLE_SIZE);
}
static const unsigned int pgtable_cache_size[2] = {
@ -163,19 +168,8 @@ struct kmem_cache *pgtable_cache[ARRAY_SIZE(pgtable_cache_size)];
void pgtable_cache_init(void)
{
int i;
for (i = 0; i < ARRAY_SIZE(pgtable_cache_size); i++) {
int size = pgtable_cache_size[i];
const char *name = pgtable_cache_name[i];
pr_debug("Allocating page table cache %s (#%d) "
"for size: %08x...\n", name, i, size);
pgtable_cache[i] = kmem_cache_create(name,
size, size,
SLAB_PANIC,
zero_ctor);
}
pgtable_cache[0] = kmem_cache_create(pgtable_cache_name[0], PGD_TABLE_SIZE, PGD_TABLE_SIZE, SLAB_PANIC, pgd_ctor);
pgtable_cache[1] = kmem_cache_create(pgtable_cache_name[1], PMD_TABLE_SIZE, PMD_TABLE_SIZE, SLAB_PANIC, pmd_ctor);
}
#ifdef CONFIG_SPARSEMEM_VMEMMAP

View File

@ -78,7 +78,7 @@ spufs_destroy_inode(struct inode *inode)
}
static void
spufs_init_once(struct kmem_cache *cachep, void *p)
spufs_init_once(void *p)
{
struct spufs_inode_info *ei = p;

View File

@ -293,7 +293,7 @@ void pmb_unmap(unsigned long addr)
} while (pmbe);
}
static void pmb_cache_ctor(struct kmem_cache *cachep, void *pmb)
static void pmb_cache_ctor(void *pmb)
{
struct pmb_entry *pmbe = pmb;

View File

@ -309,7 +309,7 @@ void show_mem(void)
struct kmem_cache *pgtable_cache __read_mostly;
static void pgd_ctor(struct kmem_cache *cache, void* addr)
static void pgd_ctor(void* addr)
{
pte_t* ptep = (pte_t*)addr;
int i;

View File

@ -87,7 +87,7 @@ struct mon_reader_text {
static struct dentry *mon_dir; /* Usually /sys/kernel/debug/usbmon */
static void mon_text_ctor(struct kmem_cache *, void *);
static void mon_text_ctor(void *);
struct mon_text_ptr {
int cnt, limit;
@ -720,7 +720,7 @@ void mon_text_del(struct mon_bus *mbus)
/*
* Slab interface: constructor.
*/
static void mon_text_ctor(struct kmem_cache *slab, void *mem)
static void mon_text_ctor(void *mem)
{
/*
* Nothing to initialize. No, really!

View File

@ -249,7 +249,7 @@ static void adfs_destroy_inode(struct inode *inode)
kmem_cache_free(adfs_inode_cachep, ADFS_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct adfs_inode_info *ei = (struct adfs_inode_info *) foo;

View File

@ -90,7 +90,7 @@ static void affs_destroy_inode(struct inode *inode)
kmem_cache_free(affs_inode_cachep, AFFS_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct affs_inode_info *ei = (struct affs_inode_info *) foo;

View File

@ -27,7 +27,7 @@
#define AFS_FS_MAGIC 0x6B414653 /* 'kAFS' */
static void afs_i_init_once(struct kmem_cache *cachep, void *foo);
static void afs_i_init_once(void *foo);
static int afs_get_sb(struct file_system_type *fs_type,
int flags, const char *dev_name,
void *data, struct vfsmount *mnt);
@ -449,7 +449,7 @@ static void afs_put_super(struct super_block *sb)
/*
* initialise an inode cache slab element prior to any use
*/
static void afs_i_init_once(struct kmem_cache *cachep, void *_vnode)
static void afs_i_init_once(void *_vnode)
{
struct afs_vnode *vnode = _vnode;

View File

@ -289,7 +289,7 @@ befs_destroy_inode(struct inode *inode)
kmem_cache_free(befs_inode_cachep, BEFS_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct befs_inode_info *bi = (struct befs_inode_info *) foo;

View File

@ -264,7 +264,7 @@ static void bfs_destroy_inode(struct inode *inode)
kmem_cache_free(bfs_inode_cachep, BFS_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct bfs_inode_info *bi = foo;

View File

@ -271,7 +271,7 @@ static void bdev_destroy_inode(struct inode *inode)
kmem_cache_free(bdev_cachep, bdi);
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct bdev_inode *ei = (struct bdev_inode *) foo;
struct block_device *bdev = &ei->bdev;

View File

@ -3272,7 +3272,7 @@ int bh_submit_read(struct buffer_head *bh)
EXPORT_SYMBOL(bh_submit_read);
static void
init_buffer_head(struct kmem_cache *cachep, void *data)
init_buffer_head(void *data)
{
struct buffer_head *bh = data;

View File

@ -766,7 +766,7 @@ const struct file_operations cifs_dir_ops = {
};
static void
cifs_init_once(struct kmem_cache *cachep, void *inode)
cifs_init_once(void *inode)
{
struct cifsInodeInfo *cifsi = inode;

View File

@ -58,7 +58,7 @@ static void coda_destroy_inode(struct inode *inode)
kmem_cache_free(coda_inode_cachep, ITOC(inode));
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct coda_inode_info *ei = (struct coda_inode_info *) foo;

View File

@ -578,7 +578,7 @@ static struct file_system_type ecryptfs_fs_type = {
* Initializes the ecryptfs_inode_info_cache when it is created
*/
static void
inode_info_init_once(struct kmem_cache *cachep, void *vptr)
inode_info_init_once(void *vptr)
{
struct ecryptfs_inode_info *ei = (struct ecryptfs_inode_info *)vptr;
@ -589,7 +589,7 @@ static struct ecryptfs_cache_info {
struct kmem_cache **cache;
const char *name;
size_t size;
void (*ctor)(struct kmem_cache *cache, void *obj);
void (*ctor)(void *obj);
} ecryptfs_cache_infos[] = {
{
.cache = &ecryptfs_auth_tok_list_item_cache,

View File

@ -70,7 +70,7 @@ static void efs_destroy_inode(struct inode *inode)
kmem_cache_free(efs_inode_cachep, INODE_INFO(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct efs_inode_info *ei = (struct efs_inode_info *) foo;

View File

@ -159,7 +159,7 @@ static void ext2_destroy_inode(struct inode *inode)
kmem_cache_free(ext2_inode_cachep, EXT2_I(inode));
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct ext2_inode_info *ei = (struct ext2_inode_info *) foo;

View File

@ -472,7 +472,7 @@ static void ext3_destroy_inode(struct inode *inode)
kmem_cache_free(ext3_inode_cachep, EXT3_I(inode));
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct ext3_inode_info *ei = (struct ext3_inode_info *) foo;

View File

@ -595,7 +595,7 @@ static void ext4_destroy_inode(struct inode *inode)
kmem_cache_free(ext4_inode_cachep, EXT4_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct ext4_inode_info *ei = (struct ext4_inode_info *) foo;

View File

@ -36,7 +36,7 @@ static inline int fat_max_cache(struct inode *inode)
static struct kmem_cache *fat_cache_cachep;
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct fat_cache *cache = (struct fat_cache *)foo;

View File

@ -498,7 +498,7 @@ static void fat_destroy_inode(struct inode *inode)
kmem_cache_free(fat_inode_cachep, MSDOS_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct msdos_inode_info *ei = (struct msdos_inode_info *)foo;

View File

@ -956,7 +956,7 @@ static inline void unregister_fuseblk(void)
}
#endif
static void fuse_inode_init_once(struct kmem_cache *cachep, void *foo)
static void fuse_inode_init_once(void *foo)
{
struct inode * inode = foo;

View File

@ -24,7 +24,7 @@
#include "util.h"
#include "glock.h"
static void gfs2_init_inode_once(struct kmem_cache *cachep, void *foo)
static void gfs2_init_inode_once(void *foo)
{
struct gfs2_inode *ip = foo;
@ -33,7 +33,7 @@ static void gfs2_init_inode_once(struct kmem_cache *cachep, void *foo)
ip->i_alloc = NULL;
}
static void gfs2_init_glock_once(struct kmem_cache *cachep, void *foo)
static void gfs2_init_glock_once(void *foo)
{
struct gfs2_glock *gl = foo;

View File

@ -432,7 +432,7 @@ static struct file_system_type hfs_fs_type = {
.fs_flags = FS_REQUIRES_DEV,
};
static void hfs_init_once(struct kmem_cache *cachep, void *p)
static void hfs_init_once(void *p)
{
struct hfs_inode_info *i = p;

View File

@ -485,7 +485,7 @@ static struct file_system_type hfsplus_fs_type = {
.fs_flags = FS_REQUIRES_DEV,
};
static void hfsplus_init_once(struct kmem_cache *cachep, void *p)
static void hfsplus_init_once(void *p)
{
struct hfsplus_inode_info *i = p;

View File

@ -173,7 +173,7 @@ static void hpfs_destroy_inode(struct inode *inode)
kmem_cache_free(hpfs_inode_cachep, hpfs_i(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct hpfs_inode_info *ei = (struct hpfs_inode_info *) foo;

View File

@ -705,7 +705,7 @@ static const struct address_space_operations hugetlbfs_aops = {
};
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct hugetlbfs_inode_info *ei = (struct hugetlbfs_inode_info *)foo;

View File

@ -224,7 +224,7 @@ void inode_init_once(struct inode *inode)
EXPORT_SYMBOL(inode_init_once);
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct inode * inode = (struct inode *) foo;

View File

@ -73,7 +73,7 @@ static void isofs_destroy_inode(struct inode *inode)
kmem_cache_free(isofs_inode_cachep, ISOFS_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct iso_inode_info *ei = foo;

View File

@ -44,7 +44,7 @@ static void jffs2_destroy_inode(struct inode *inode)
kmem_cache_free(jffs2_inode_cachep, JFFS2_INODE_INFO(inode));
}
static void jffs2_i_init_once(struct kmem_cache *cachep, void *foo)
static void jffs2_i_init_once(void *foo)
{
struct jffs2_inode_info *f = foo;

View File

@ -182,7 +182,7 @@ static inline void remove_metapage(struct page *page, struct metapage *mp)
#endif
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct metapage *mp = (struct metapage *)foo;

View File

@ -760,7 +760,7 @@ static struct file_system_type jfs_fs_type = {
.fs_flags = FS_REQUIRES_DEV,
};
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct jfs_inode_info *jfs_ip = (struct jfs_inode_info *) foo;

View File

@ -201,7 +201,7 @@ EXPORT_SYMBOL(locks_init_lock);
* Initialises the fields of the file lock which are invariant for
* free file_locks.
*/
static void init_once(struct kmem_cache *cache, void *foo)
static void init_once(void *foo)
{
struct file_lock *lock = (struct file_lock *) foo;

View File

@ -68,7 +68,7 @@ static void minix_destroy_inode(struct inode *inode)
kmem_cache_free(minix_inode_cachep, minix_i(inode));
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct minix_inode_info *ei = (struct minix_inode_info *) foo;

View File

@ -64,7 +64,7 @@ static void ncp_destroy_inode(struct inode *inode)
kmem_cache_free(ncp_inode_cachep, NCP_FINFO(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct ncp_inode_info *ei = (struct ncp_inode_info *) foo;

View File

@ -1242,7 +1242,7 @@ static inline void nfs4_init_once(struct nfs_inode *nfsi)
#endif
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct nfs_inode *nfsi = (struct nfs_inode *) foo;

View File

@ -3080,7 +3080,7 @@ struct kmem_cache *ntfs_inode_cache;
struct kmem_cache *ntfs_big_inode_cache;
/* Init once constructor for the inode slab cache. */
static void ntfs_big_inode_init_once(struct kmem_cache *cachep, void *foo)
static void ntfs_big_inode_init_once(void *foo)
{
ntfs_inode *ni = (ntfs_inode *)foo;

View File

@ -267,8 +267,7 @@ static ssize_t dlmfs_file_write(struct file *filp,
return writelen;
}
static void dlmfs_init_once(struct kmem_cache *cachep,
void *foo)
static void dlmfs_init_once(void *foo)
{
struct dlmfs_inode_private *ip =
(struct dlmfs_inode_private *) foo;

View File

@ -1118,7 +1118,7 @@ static int ocfs2_statfs(struct dentry *dentry, struct kstatfs *buf)
return status;
}
static void ocfs2_inode_init_once(struct kmem_cache *cachep, void *data)
static void ocfs2_inode_init_once(void *data)
{
struct ocfs2_inode_info *oi = data;

View File

@ -430,7 +430,7 @@ static struct file_system_type openprom_fs_type = {
.kill_sb = kill_anon_super,
};
static void op_inode_init_once(struct kmem_cache * cachep, void *data)
static void op_inode_init_once(void *data)
{
struct op_inode_info *oi = (struct op_inode_info *) data;

View File

@ -94,7 +94,7 @@ static void proc_destroy_inode(struct inode *inode)
kmem_cache_free(proc_inode_cachep, PROC_I(inode));
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct proc_inode *ei = (struct proc_inode *) foo;

View File

@ -553,7 +553,7 @@ static void qnx4_destroy_inode(struct inode *inode)
kmem_cache_free(qnx4_inode_cachep, qnx4_i(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct qnx4_inode_info *ei = (struct qnx4_inode_info *) foo;

View File

@ -521,7 +521,7 @@ static void reiserfs_destroy_inode(struct inode *inode)
kmem_cache_free(reiserfs_inode_cachep, REISERFS_I(inode));
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct reiserfs_inode_info *ei = (struct reiserfs_inode_info *)foo;

View File

@ -577,7 +577,7 @@ static void romfs_destroy_inode(struct inode *inode)
kmem_cache_free(romfs_inode_cachep, ROMFS_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct romfs_inode_info *ei = foo;

View File

@ -67,7 +67,7 @@ static void smb_destroy_inode(struct inode *inode)
kmem_cache_free(smb_inode_cachep, SMB_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct smb_inode_info *ei = (struct smb_inode_info *) foo;

View File

@ -326,7 +326,7 @@ static void sysv_destroy_inode(struct inode *inode)
kmem_cache_free(sysv_inode_cachep, SYSV_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *p)
static void init_once(void *p)
{
struct sysv_inode_info *si = (struct sysv_inode_info *)p;

View File

@ -1841,7 +1841,7 @@ static struct file_system_type ubifs_fs_type = {
/*
* Inode slab cache constructor.
*/
static void inode_slab_ctor(struct kmem_cache *cachep, void *obj)
static void inode_slab_ctor(void *obj)
{
struct ubifs_inode *ui = obj;
inode_init_once(&ui->vfs_inode);

View File

@ -148,7 +148,7 @@ static void udf_destroy_inode(struct inode *inode)
kmem_cache_free(udf_inode_cachep, UDF_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct udf_inode_info *ei = (struct udf_inode_info *)foo;

View File

@ -1302,7 +1302,7 @@ static void ufs_destroy_inode(struct inode *inode)
kmem_cache_free(ufs_inode_cachep, UFS_I(inode));
}
static void init_once(struct kmem_cache * cachep, void *foo)
static void init_once(void *foo)
{
struct ufs_inode_info *ei = (struct ufs_inode_info *) foo;

View File

@ -79,7 +79,7 @@ kmem_zone_init(int size, char *zone_name)
static inline kmem_zone_t *
kmem_zone_init_flags(int size, char *zone_name, unsigned long flags,
void (*construct)(kmem_zone_t *, void *))
void (*construct)(void *))
{
return kmem_cache_create(zone_name, size, 0, flags, construct);
}

View File

@ -843,7 +843,6 @@ xfs_fs_destroy_inode(
STATIC void
xfs_fs_inode_init_once(
kmem_zone_t *zonep,
void *vnode)
{
inode_init_once(vn_to_inode((bhv_vnode_t *)vnode));

View File

@ -58,7 +58,7 @@ int slab_is_available(void);
struct kmem_cache *kmem_cache_create(const char *, size_t, size_t,
unsigned long,
void (*)(struct kmem_cache *, void *));
void (*)(void *));
void kmem_cache_destroy(struct kmem_cache *);
int kmem_cache_shrink(struct kmem_cache *);
void kmem_cache_free(struct kmem_cache *, void *);

View File

@ -85,7 +85,7 @@ struct kmem_cache {
struct kmem_cache_order_objects min;
gfp_t allocflags; /* gfp flags to use on each alloc */
int refcount; /* Refcount for slab cache destroy */
void (*ctor)(struct kmem_cache *, void *);
void (*ctor)(void *);
int inuse; /* Offset to metadata */
int align; /* Alignment */
const char *name; /* Name (only for display!) */

View File

@ -207,7 +207,7 @@ static int mqueue_get_sb(struct file_system_type *fs_type,
return get_sb_single(fs_type, flags, data, mqueue_fill_super, mnt);
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct mqueue_inode_info *p = (struct mqueue_inode_info *) foo;

View File

@ -1442,7 +1442,7 @@ long do_fork(unsigned long clone_flags,
#define ARCH_MIN_MMSTRUCT_ALIGN 0
#endif
static void sighand_ctor(struct kmem_cache *cachep, void *data)
static void sighand_ctor(void *data)
{
struct sighand_struct *sighand = data;

View File

@ -607,7 +607,7 @@ void *idr_replace(struct idr *idp, void *ptr, int id)
}
EXPORT_SYMBOL(idr_replace);
static void idr_cache_ctor(struct kmem_cache *idr_layer_cache, void *idr_layer)
static void idr_cache_ctor(void *idr_layer)
{
memset(idr_layer, 0, sizeof(struct idr_layer));
}

View File

@ -1183,7 +1183,7 @@ int radix_tree_tagged(struct radix_tree_root *root, unsigned int tag)
EXPORT_SYMBOL(radix_tree_tagged);
static void
radix_tree_node_ctor(struct kmem_cache *cachep, void *node)
radix_tree_node_ctor(void *node)
{
memset(node, 0, sizeof(struct radix_tree_node));
}

View File

@ -138,7 +138,7 @@ void anon_vma_unlink(struct vm_area_struct *vma)
anon_vma_free(anon_vma);
}
static void anon_vma_ctor(struct kmem_cache *cachep, void *data)
static void anon_vma_ctor(void *data)
{
struct anon_vma *anon_vma = data;

View File

@ -2352,7 +2352,7 @@ static void shmem_destroy_inode(struct inode *inode)
kmem_cache_free(shmem_inode_cachep, SHMEM_I(inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct shmem_inode_info *p = (struct shmem_inode_info *) foo;

View File

@ -406,7 +406,7 @@ struct kmem_cache {
unsigned int dflags; /* dynamic flags */
/* constructor func */
void (*ctor)(struct kmem_cache *, void *);
void (*ctor)(void *obj);
/* 5) cache creation/removal */
const char *name;
@ -2137,8 +2137,7 @@ static int __init_refok setup_cpu_cache(struct kmem_cache *cachep)
*/
struct kmem_cache *
kmem_cache_create (const char *name, size_t size, size_t align,
unsigned long flags,
void (*ctor)(struct kmem_cache *, void *))
unsigned long flags, void (*ctor)(void *))
{
size_t left_over, slab_size, ralign;
struct kmem_cache *cachep = NULL, *pc;
@ -2653,7 +2652,7 @@ static void cache_init_objs(struct kmem_cache *cachep,
* They must also be threaded.
*/
if (cachep->ctor && !(cachep->flags & SLAB_POISON))
cachep->ctor(cachep, objp + obj_offset(cachep));
cachep->ctor(objp + obj_offset(cachep));
if (cachep->flags & SLAB_RED_ZONE) {
if (*dbg_redzone2(cachep, objp) != RED_INACTIVE)
@ -2669,7 +2668,7 @@ static void cache_init_objs(struct kmem_cache *cachep,
cachep->buffer_size / PAGE_SIZE, 0);
#else
if (cachep->ctor)
cachep->ctor(cachep, objp);
cachep->ctor(objp);
#endif
slab_bufctl(slabp)[i] = i + 1;
}
@ -3093,7 +3092,7 @@ static void *cache_alloc_debugcheck_after(struct kmem_cache *cachep,
#endif
objp += obj_offset(cachep);
if (cachep->ctor && cachep->flags & SLAB_POISON)
cachep->ctor(cachep, objp);
cachep->ctor(objp);
#if ARCH_SLAB_MINALIGN
if ((u32)objp & (ARCH_SLAB_MINALIGN-1)) {
printk(KERN_ERR "0x%p: not aligned to ARCH_SLAB_MINALIGN=%d\n",

View File

@ -525,12 +525,11 @@ struct kmem_cache {
unsigned int size, align;
unsigned long flags;
const char *name;
void (*ctor)(struct kmem_cache *, void *);
void (*ctor)(void *);
};
struct kmem_cache *kmem_cache_create(const char *name, size_t size,
size_t align, unsigned long flags,
void (*ctor)(struct kmem_cache *, void *))
size_t align, unsigned long flags, void (*ctor)(void *))
{
struct kmem_cache *c;
@ -575,7 +574,7 @@ void *kmem_cache_alloc_node(struct kmem_cache *c, gfp_t flags, int node)
b = slob_new_page(flags, get_order(c->size), node);
if (c->ctor)
c->ctor(c, b);
c->ctor(b);
return b;
}

View File

@ -1012,7 +1012,7 @@ __setup("slub_debug", setup_slub_debug);
static unsigned long kmem_cache_flags(unsigned long objsize,
unsigned long flags, const char *name,
void (*ctor)(struct kmem_cache *, void *))
void (*ctor)(void *))
{
/*
* Enable debugging if selected on the kernel commandline.
@ -1040,7 +1040,7 @@ static inline int check_object(struct kmem_cache *s, struct page *page,
static inline void add_full(struct kmem_cache_node *n, struct page *page) {}
static inline unsigned long kmem_cache_flags(unsigned long objsize,
unsigned long flags, const char *name,
void (*ctor)(struct kmem_cache *, void *))
void (*ctor)(void *))
{
return flags;
}
@ -1103,7 +1103,7 @@ static void setup_object(struct kmem_cache *s, struct page *page,
{
setup_object_debug(s, page, object);
if (unlikely(s->ctor))
s->ctor(s, object);
s->ctor(object);
}
static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
@ -2286,7 +2286,7 @@ static int calculate_sizes(struct kmem_cache *s, int forced_order)
static int kmem_cache_open(struct kmem_cache *s, gfp_t gfpflags,
const char *name, size_t size,
size_t align, unsigned long flags,
void (*ctor)(struct kmem_cache *, void *))
void (*ctor)(void *))
{
memset(s, 0, kmem_size);
s->name = name;
@ -3042,7 +3042,7 @@ static int slab_unmergeable(struct kmem_cache *s)
static struct kmem_cache *find_mergeable(size_t size,
size_t align, unsigned long flags, const char *name,
void (*ctor)(struct kmem_cache *, void *))
void (*ctor)(void *))
{
struct kmem_cache *s;
@ -3082,8 +3082,7 @@ static struct kmem_cache *find_mergeable(size_t size,
}
struct kmem_cache *kmem_cache_create(const char *name, size_t size,
size_t align, unsigned long flags,
void (*ctor)(struct kmem_cache *, void *))
size_t align, unsigned long flags, void (*ctor)(void *))
{
struct kmem_cache *s;

View File

@ -265,7 +265,7 @@ static void sock_destroy_inode(struct inode *inode)
container_of(inode, struct socket_alloc, vfs_inode));
}
static void init_once(struct kmem_cache *cachep, void *foo)
static void init_once(void *foo)
{
struct socket_alloc *ei = (struct socket_alloc *)foo;

View File

@ -897,7 +897,7 @@ static struct file_system_type rpc_pipe_fs_type = {
};
static void
init_once(struct kmem_cache * cachep, void *foo)
init_once(void *foo)
{
struct rpc_inode *rpci = (struct rpc_inode *) foo;