Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-09 23:00:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

media: allegro: nal-hevc: Replace array[1] with array[N]

Browse Source 
Structures that have a single element array as the last field can be
mistaken as a "flex array".

We could replace all the single element arrays in the structure with
single element fields, but this driver prefers to follow the ITU-T H.265
specification, which defines it as an array.

If we introduce a new define N_HRD_PARAMS, we make clear our
intentions.

This fixes this cocci warning:
drivers/media/platform/allegro-dvt/nal-hevc.h:102:14-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil: fix typo in subject and commit log]
This commit is contained in:
Ricardo Ribalda 2024-05-27 21:08:51 +00:00 committed by Hans Verkuil
parent 6a4e6e34ce
commit 669d51f8f4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/platform/allegro-dvt/nal-hevc.h
View File

@ -96,10 +96,11 @@ struct nal_hevc_vps {
unsigned int extension_data_flag;
};
#define N_HRD_PARAMS 1
struct nal_hevc_sub_layer_hrd_parameters {
unsigned int bit_rate_value_minus1[1];
unsigned int cpb_size_value_minus1[1];
unsigned int cbr_flag[1];
unsigned int bit_rate_value_minus1[N_HRD_PARAMS];
unsigned int cpb_size_value_minus1[N_HRD_PARAMS];
unsigned int cbr_flag[N_HRD_PARAMS];
};
struct nal_hevc_hrd_parameters {