Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2024-12-29 17:23:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

phy: freescale: fsl-samsung-hdmi: Fix 64-by-32 division cocci warnings

Browse Source 
The Kernel test robot returns the following warning:
 do_div() does a 64-by-32 division, please consider using div64_ul instead.

To prevent the 64-by-32 divsion, consolidate both the multiplication
and the do_div into one line which explicitly uses u64 sizes.

Fixes: 1951dbb41d ("phy: freescale: fsl-samsung-hdmi: Support dynamic integer")
Signed-off-by: Adam Ford <aford173@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412091243.fSObwwPi-lkp@intel.com/

Link: https://lore.kernel.org/r/20241215220555.99113-1-aford173@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Adam Ford 2024-12-15 16:05:55 -06:00 committed by Vinod Koul
parent a2d633cb14
commit 739214dd1c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/phy/freescale/phy-fsl-samsung-hdmi.c
View File

@ -424,8 +424,7 @@ static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u1
* Fvco = (M * f_ref) / P, * Fvco = (M * f_ref) / P,
* where f_ref is 24MHz. * where f_ref is 24MHz.
*/ */
tmp = (u64)_m * 24 * MHZ; tmp = div64_ul((u64)_m * 24 * MHZ, _p);
do_div(tmp, _p);
if (tmp < 750 * MHZ || if (tmp < 750 * MHZ ||
tmp > 3000 * MHZ) tmp > 3000 * MHZ)
continue; continue;